* [PATCH v3 8/8] build: add NFC defconfig file
@ 2013-04-08 10:26 Thierry Escande
2013-04-08 19:31 ` Luis R. Rodriguez
0 siblings, 1 reply; 9+ messages in thread
From: Thierry Escande @ 2013-04-08 10:26 UTC (permalink / raw)
To: backports
Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
---
backport/defconfigs/nfc | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 backport/defconfigs/nfc
diff --git a/backport/defconfigs/nfc b/backport/defconfigs/nfc
new file mode 100644
index 0000000..999127f
--- /dev/null
+++ b/backport/defconfigs/nfc
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 10:26 [PATCH v3 8/8] build: add NFC defconfig file Thierry Escande
@ 2013-04-08 19:31 ` Luis R. Rodriguez
2013-04-08 19:34 ` Johannes Berg
0 siblings, 1 reply; 9+ messages in thread
From: Luis R. Rodriguez @ 2013-04-08 19:31 UTC (permalink / raw)
To: Thierry Escande; +Cc: backports@vger.kernel.org
On Mon, Apr 8, 2013 at 3:26 AM, Thierry Escande
<thierry.escande@linux.intel.com> wrote:
> Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
> ---
> backport/defconfigs/nfc | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 backport/defconfigs/nfc
>
> diff --git a/backport/defconfigs/nfc b/backport/defconfigs/nfc
> new file mode 100644
> index 0000000..999127f
> --- /dev/null
> +++ b/backport/defconfigs/nfc
> @@ -0,0 +1,11 @@
> +CPTCFG_NFC=m
> +CPTCFG_NFC_NCI=m
> +CPTCFG_NFC_HCI=m
> +CPTCFG_NFC_SHDLC=y
> +CPTCFG_NFC_LLCP=y
> +CPTCFG_NFC_PN533=m
> +CPTCFG_NFC_WILINK=m
> +CPTCFG_NFC_PN544=m
> +CPTCFG_NFC_PN544_I2C=m
> +CPTCFG_NFC_MICROREAD=m
> +CPTCFG_NFC_MICROREAD_I2C=m
Johannes, do we want to be disabling the other subsystems in these ?
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 19:31 ` Luis R. Rodriguez
@ 2013-04-08 19:34 ` Johannes Berg
2013-04-08 19:37 ` Luis R. Rodriguez
0 siblings, 1 reply; 9+ messages in thread
From: Johannes Berg @ 2013-04-08 19:34 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, 2013-04-08 at 12:31 -0700, Luis R. Rodriguez wrote:
> On Mon, Apr 8, 2013 at 3:26 AM, Thierry Escande
> <thierry.escande@linux.intel.com> wrote:
> > Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
> > ---
> > backport/defconfigs/nfc | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> > create mode 100644 backport/defconfigs/nfc
> >
> > diff --git a/backport/defconfigs/nfc b/backport/defconfigs/nfc
> > new file mode 100644
> > index 0000000..999127f
> > --- /dev/null
> > +++ b/backport/defconfigs/nfc
> > @@ -0,0 +1,11 @@
> > +CPTCFG_NFC=m
> > +CPTCFG_NFC_NCI=m
> > +CPTCFG_NFC_HCI=m
> > +CPTCFG_NFC_SHDLC=y
> > +CPTCFG_NFC_LLCP=y
> > +CPTCFG_NFC_PN533=m
> > +CPTCFG_NFC_WILINK=m
> > +CPTCFG_NFC_PN544=m
> > +CPTCFG_NFC_PN544_I2C=m
> > +CPTCFG_NFC_MICROREAD=m
> > +CPTCFG_NFC_MICROREAD_I2C=m
>
> Johannes, do we want to be disabling the other subsystems in these ?
Well anything not listed will have the default values, so that should be
OK, right? Most things should be default off.
And yeah I think for an NFC defconfig everything else is probably
desired off, no?
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 19:34 ` Johannes Berg
@ 2013-04-08 19:37 ` Luis R. Rodriguez
2013-04-08 19:40 ` Johannes Berg
0 siblings, 1 reply; 9+ messages in thread
From: Luis R. Rodriguez @ 2013-04-08 19:37 UTC (permalink / raw)
To: Johannes Berg; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, Apr 8, 2013 at 12:34 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2013-04-08 at 12:31 -0700, Luis R. Rodriguez wrote:
>> On Mon, Apr 8, 2013 at 3:26 AM, Thierry Escande
>> <thierry.escande@linux.intel.com> wrote:
>> > Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
>> > ---
>> > backport/defconfigs/nfc | 11 +++++++++++
>> > 1 file changed, 11 insertions(+)
>> > create mode 100644 backport/defconfigs/nfc
>> >
>> > diff --git a/backport/defconfigs/nfc b/backport/defconfigs/nfc
>> > new file mode 100644
>> > index 0000000..999127f
>> > --- /dev/null
>> > +++ b/backport/defconfigs/nfc
>> > @@ -0,0 +1,11 @@
>> > +CPTCFG_NFC=m
>> > +CPTCFG_NFC_NCI=m
>> > +CPTCFG_NFC_HCI=m
>> > +CPTCFG_NFC_SHDLC=y
>> > +CPTCFG_NFC_LLCP=y
>> > +CPTCFG_NFC_PN533=m
>> > +CPTCFG_NFC_WILINK=m
>> > +CPTCFG_NFC_PN544=m
>> > +CPTCFG_NFC_PN544_I2C=m
>> > +CPTCFG_NFC_MICROREAD=m
>> > +CPTCFG_NFC_MICROREAD_I2C=m
>>
>> Johannes, do we want to be disabling the other subsystems in these ?
>
> Well anything not listed will have the default values, so that should be
> OK, right? Most things should be default off.
OK so the default would be -- "if you have it on your kernel then
we'll enable at build time", is that right? I wasn't clear on this,
that's all.
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 19:37 ` Luis R. Rodriguez
@ 2013-04-08 19:40 ` Johannes Berg
2013-04-08 20:51 ` Luis R. Rodriguez
0 siblings, 1 reply; 9+ messages in thread
From: Johannes Berg @ 2013-04-08 19:40 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, 2013-04-08 at 12:37 -0700, Luis R. Rodriguez wrote:
> >> > +CPTCFG_NFC=m
[...]
> >> Johannes, do we want to be disabling the other subsystems in these ?
> >
> > Well anything not listed will have the default values, so that should be
> > OK, right? Most things should be default off.
>
> OK so the default would be -- "if you have it on your kernel then
> we'll enable at build time", is that right? I wasn't clear on this,
> that's all.
No, because of the prefix rename (CONFIG_ -> CPTCFG_) the kernel's
configuration has no influence on our configuration at all.
So the default is just whatever the default is in the Kconfig files,
which is essentially everything else turned off.
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 19:40 ` Johannes Berg
@ 2013-04-08 20:51 ` Luis R. Rodriguez
2013-04-08 20:56 ` Johannes Berg
0 siblings, 1 reply; 9+ messages in thread
From: Luis R. Rodriguez @ 2013-04-08 20:51 UTC (permalink / raw)
To: Johannes Berg; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, Apr 8, 2013 at 12:40 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2013-04-08 at 12:37 -0700, Luis R. Rodriguez wrote:
>
>> >> > +CPTCFG_NFC=m
> [...]
>> >> Johannes, do we want to be disabling the other subsystems in these ?
>> >
>> > Well anything not listed will have the default values, so that should be
>> > OK, right? Most things should be default off.
>>
>> OK so the default would be -- "if you have it on your kernel then
>> we'll enable at build time", is that right? I wasn't clear on this,
>> that's all.
>
> No, because of the prefix rename (CONFIG_ -> CPTCFG_) the kernel's
> configuration has no influence on our configuration at all.
>
> So the default is just whatever the default is in the Kconfig files,
> which is essentially everything else turned off.
Odd, when I tried to do media with similar defconfig I got wireless
building :( but its great this was the goal, I'll try again.
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 20:51 ` Luis R. Rodriguez
@ 2013-04-08 20:56 ` Johannes Berg
2013-04-08 20:57 ` Luis R. Rodriguez
0 siblings, 1 reply; 9+ messages in thread
From: Johannes Berg @ 2013-04-08 20:56 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, 2013-04-08 at 13:51 -0700, Luis R. Rodriguez wrote:
> > So the default is just whatever the default is in the Kconfig files,
> > which is essentially everything else turned off.
>
> Odd, when I tried to do media with similar defconfig I got wireless
> building :( but its great this was the goal, I'll try again.
Did you create a new tree or rm .config first?
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 8/8] build: add NFC defconfig file
2013-04-08 20:56 ` Johannes Berg
@ 2013-04-08 20:57 ` Luis R. Rodriguez
0 siblings, 0 replies; 9+ messages in thread
From: Luis R. Rodriguez @ 2013-04-08 20:57 UTC (permalink / raw)
To: Johannes Berg; +Cc: Thierry Escande, backports@vger.kernel.org
On Mon, Apr 8, 2013 at 1:56 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2013-04-08 at 13:51 -0700, Luis R. Rodriguez wrote:
>
>> > So the default is just whatever the default is in the Kconfig files,
>> > which is essentially everything else turned off.
>>
>> Odd, when I tried to do media with similar defconfig I got wireless
>> building :( but its great this was the goal, I'll try again.
>
> Did you create a new tree or rm .config first?
I've corrected my habbits now, git clean -f -x -d and always new tree generated.
Luis
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 8/8] build: add NFC defconfig file
@ 2013-04-05 21:20 Thierry Escande
0 siblings, 0 replies; 9+ messages in thread
From: Thierry Escande @ 2013-04-05 21:20 UTC (permalink / raw)
To: backports
Signed-off-by: Thierry Escande <thierry.escande@linux.intel.com>
---
backport/defconfigs/nfc | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 backport/defconfigs/nfc
diff --git a/backport/defconfigs/nfc b/backport/defconfigs/nfc
new file mode 100644
index 0000000..999127f
--- /dev/null
+++ b/backport/defconfigs/nfc
@@ -0,0 +1,11 @@
+CPTCFG_NFC=m
+CPTCFG_NFC_NCI=m
+CPTCFG_NFC_HCI=m
+CPTCFG_NFC_SHDLC=y
+CPTCFG_NFC_LLCP=y
+CPTCFG_NFC_PN533=m
+CPTCFG_NFC_WILINK=m
+CPTCFG_NFC_PN544=m
+CPTCFG_NFC_PN544_I2C=m
+CPTCFG_NFC_MICROREAD=m
+CPTCFG_NFC_MICROREAD_I2C=m
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-08 20:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08 10:26 [PATCH v3 8/8] build: add NFC defconfig file Thierry Escande
2013-04-08 19:31 ` Luis R. Rodriguez
2013-04-08 19:34 ` Johannes Berg
2013-04-08 19:37 ` Luis R. Rodriguez
2013-04-08 19:40 ` Johannes Berg
2013-04-08 20:51 ` Luis R. Rodriguez
2013-04-08 20:56 ` Johannes Berg
2013-04-08 20:57 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2013-04-05 21:20 Thierry Escande
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.