* [PATCH] tcf-agent: Use kill instead of killproc to stop agent
@ 2013-04-08 11:58 Bogdan Marinescu
2013-04-08 12:16 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Bogdan Marinescu @ 2013-04-08 11:58 UTC (permalink / raw)
To: openembedded-core
From: Ioana Grigoropol <ioanax.grigoropol@intel.com>
[Yocto #3928]
Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
---
.../tcf-agent/tcf-agent/fix_tcf-agent.init.patch | 6 ++++--
meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
index fefaf04..8ea5b43 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
@@ -13,7 +13,7 @@ Upstream-Status: Inappropriate [poky-specific script]
install -c -t $(INSTALLROOT)$(INCLUDE)/tcf/services -m 644 services/*.h
--- /dev/null
+++ b/tcf-agent.init
-@@ -0,0 +1,78 @@
+@@ -0,0 +1,80 @@
+#!/bin/sh
+### BEGIN INIT INFO
+# Provides: tcf-agent
@@ -50,14 +50,16 @@ Upstream-Status: Inappropriate [poky-specific script]
+ stop)
+ echo -n "Stopping $DAEMON_NAME: "
+ count=0
++ pid=$(/bin/pidof $DAEMON_PATH)
+ while [ -n "`/bin/pidof $DAEMON_PATH`" -a $count -lt 10 ] ; do
-+ killproc $DAEMON_PATH >& /dev/null
++ kill $pid > /dev/null 2>&1
+ sleep 1
+ RETVAL=$?
+ if [ $RETVAL != 0 -o -n "`/bin/pidof $DAEMON_PATH`" ] ; then
+ sleep 3
+ fi
+ count=`expr $count + 1`
++ pid=$(/bin/pidof $DAEMON_PATH)
+ done
+ rm -f /var/lock/subsys/$DAEMON_NAME
+ if [ -n "`/bin/pidof $DAEMON_PATH`" ] ; then
diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index 4d43c62..ced2b41 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://edl-v10.html;md5=522a390a83dc186513f0500543ad3679"
SRCREV = "4ef94ecb927a8912c3d79ce137182247786cff8f"
PV = "0.4.0+git${SRCPV}"
-PR = "r0"
+PR = "r1"
SRC_URI = "git://git.eclipse.org/gitroot/tcf/org.eclipse.tcf.agent.git;protocol=git \
file://fix_ranlib.patch \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tcf-agent: Use kill instead of killproc to stop agent
2013-04-08 11:58 [PATCH] tcf-agent: Use kill instead of killproc to stop agent Bogdan Marinescu
@ 2013-04-08 12:16 ` Richard Purdie
2013-04-08 12:51 ` Marinescu, Bogdan A
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2013-04-08 12:16 UTC (permalink / raw)
To: Bogdan Marinescu, Ioana Grigoropol; +Cc: openembedded-core
On Mon, 2013-04-08 at 14:58 +0300, Bogdan Marinescu wrote:
> From: Ioana Grigoropol <ioanax.grigoropol@intel.com>
Why?
> [Yocto #3928]
I could read this but I shouldn't have to...
Cheers,
Richard
> Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
> .../tcf-agent/tcf-agent/fix_tcf-agent.init.patch | 6 ++++--
> meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> index fefaf04..8ea5b43 100644
> --- a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> +++ b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> @@ -13,7 +13,7 @@ Upstream-Status: Inappropriate [poky-specific script]
> install -c -t $(INSTALLROOT)$(INCLUDE)/tcf/services -m 644 services/*.h
> --- /dev/null
> +++ b/tcf-agent.init
> -@@ -0,0 +1,78 @@
> +@@ -0,0 +1,80 @@
> +#!/bin/sh
> +### BEGIN INIT INFO
> +# Provides: tcf-agent
> @@ -50,14 +50,16 @@ Upstream-Status: Inappropriate [poky-specific script]
> + stop)
> + echo -n "Stopping $DAEMON_NAME: "
> + count=0
> ++ pid=$(/bin/pidof $DAEMON_PATH)
> + while [ -n "`/bin/pidof $DAEMON_PATH`" -a $count -lt 10 ] ; do
> -+ killproc $DAEMON_PATH >& /dev/null
> ++ kill $pid > /dev/null 2>&1
> + sleep 1
> + RETVAL=$?
> + if [ $RETVAL != 0 -o -n "`/bin/pidof $DAEMON_PATH`" ] ; then
> + sleep 3
> + fi
> + count=`expr $count + 1`
> ++ pid=$(/bin/pidof $DAEMON_PATH)
> + done
> + rm -f /var/lock/subsys/$DAEMON_NAME
> + if [ -n "`/bin/pidof $DAEMON_PATH`" ] ; then
> diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> index 4d43c62..ced2b41 100644
> --- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> +++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://edl-v10.html;md5=522a390a83dc186513f0500543ad3679"
>
> SRCREV = "4ef94ecb927a8912c3d79ce137182247786cff8f"
> PV = "0.4.0+git${SRCPV}"
> -PR = "r0"
> +PR = "r1"
>
> SRC_URI = "git://git.eclipse.org/gitroot/tcf/org.eclipse.tcf.agent.git;protocol=git \
> file://fix_ranlib.patch \
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tcf-agent: Use kill instead of killproc to stop agent
2013-04-08 12:16 ` Richard Purdie
@ 2013-04-08 12:51 ` Marinescu, Bogdan A
0 siblings, 0 replies; 3+ messages in thread
From: Marinescu, Bogdan A @ 2013-04-08 12:51 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 3010 bytes --]
On Mon, Apr 8, 2013 at 3:16 PM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Mon, 2013-04-08 at 14:58 +0300, Bogdan Marinescu wrote:
> > From: Ioana Grigoropol <ioanax.grigoropol@intel.com>
>
> Why?
>
Because she is the author of the patch, I've just added a "signed-off-by"
line.
>
> > [Yocto #3928]
>
> I could read this but I shouldn't have to...
>
I've sent the second version of the patch to address this issue.
Thanks,
Bogdan
>
> Cheers,
>
> Richard
>
> > Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com>
> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> > ---
> > .../tcf-agent/tcf-agent/fix_tcf-agent.init.patch | 6 ++++--
> > meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
> > 2 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> > index fefaf04..8ea5b43 100644
> > --- a/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> > +++ b/meta/recipes-devtools/tcf-agent/tcf-agent/fix_tcf-agent.init.patch
> > @@ -13,7 +13,7 @@ Upstream-Status: Inappropriate [poky-specific script]
> > install -c -t $(INSTALLROOT)$(INCLUDE)/tcf/services -m 644
> services/*.h
> > --- /dev/null
> > +++ b/tcf-agent.init
> > -@@ -0,0 +1,78 @@
> > +@@ -0,0 +1,80 @@
> > +#!/bin/sh
> > +### BEGIN INIT INFO
> > +# Provides: tcf-agent
> > @@ -50,14 +50,16 @@ Upstream-Status: Inappropriate [poky-specific script]
> > + stop)
> > + echo -n "Stopping $DAEMON_NAME: "
> > + count=0
> > ++ pid=$(/bin/pidof $DAEMON_PATH)
> > + while [ -n "`/bin/pidof $DAEMON_PATH`" -a $count -lt 10 ] ; do
> > -+ killproc $DAEMON_PATH >& /dev/null
> > ++ kill $pid > /dev/null 2>&1
> > + sleep 1
> > + RETVAL=$?
> > + if [ $RETVAL != 0 -o -n "`/bin/pidof $DAEMON_PATH`" ] ;
> then
> > + sleep 3
> > + fi
> > + count=`expr $count + 1`
> > ++ pid=$(/bin/pidof $DAEMON_PATH)
> > + done
> > + rm -f /var/lock/subsys/$DAEMON_NAME
> > + if [ -n "`/bin/pidof $DAEMON_PATH`" ] ; then
> > diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bbb/meta/recipes-devtools/tcf-agent/
> tcf-agent_git.bb
> > index 4d43c62..ced2b41 100644
> > --- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> > +++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
> > @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM =
> "file://edl-v10.html;md5=522a390a83dc186513f0500543ad3679"
> >
> > SRCREV = "4ef94ecb927a8912c3d79ce137182247786cff8f"
> > PV = "0.4.0+git${SRCPV}"
> > -PR = "r0"
> > +PR = "r1"
> >
> > SRC_URI = "git://
> git.eclipse.org/gitroot/tcf/org.eclipse.tcf.agent.git;protocol=git \
> > file://fix_ranlib.patch \
>
>
>
[-- Attachment #2: Type: text/html, Size: 4672 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08 11:58 [PATCH] tcf-agent: Use kill instead of killproc to stop agent Bogdan Marinescu
2013-04-08 12:16 ` Richard Purdie
2013-04-08 12:51 ` Marinescu, Bogdan A
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.