* [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs
@ 2013-04-10 21:02 Daya, Dilip (Telco Linux)
2013-04-11 13:28 ` Neil Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Daya, Dilip (Telco Linux) @ 2013-04-10 21:02 UTC (permalink / raw)
To: linux-sctp
From: Dilip Daya <dilip.daya@hp.com>
This patch adds the following fields to /proc/net/sctp/assocs output:
- sk->sk_wmem_alloc (transmit queue bytes committed)
- sk->sk_wmem_queued (persistent queue size)
- sk->sk_sndbuf (size of send buffer in bytes)
- sk->sk_rcvbuf (size of receive buffer in bytes)
When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
(assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching maximum
value of sk_sndbuf.
TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values are
incremented in sctp_set_owner_w() for outgoing data chunks. Having access to
the above values in /proc/net/sctp/assocs will provide a better understanding
of SCTP buffer management.
With patch applied, example output when peer.rwnd = 0
where:
ASSOC ffff880132298000 is sender
ffff880125343000 is receiver
# cat /proc/net/sctp/assocs
ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE \
ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656 0 \
ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0 524520 \
UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
4 0 0 72 525633 440320 524288 524288
4 0 0 0 1 0 524288 524288
Signed-off-by: Dilip Daya <dilip.daya@hp.com>
---
net/sctp/proc.c | 20 +++++++++++++-------
1 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index 7923164..56636db 100644
--- a/net/sctp/proc.c
+++ b/net/sctp/proc.c
@@ -293,10 +293,11 @@ static void * sctp_assocs_seq_start(struct seq_file *seq, loff_t *pos)
*pos = 0;
if (*pos = 0)
- seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
- "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT "
- "RPORT LADDRS <-> RADDRS "
- "HBINT INS OUTS MAXRT T1X T2X RTXC\n");
+ seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
+ "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT RPORT "
+ "LADDRS <-> RADDRS HBINT INS OUTS MAXRT T1X"
+ " T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf"
+ " sk_rcvbuf\n");
return (void *)pos;
}
@@ -340,7 +341,7 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v)
sk = epb->sk;
seq_printf(seq,
"%8pK %8pK %-3d %-3d %-2d %-4d "
- "%4d %8d %8d %7d %5lu %-5d %5d ",
+ "%4d %8d %8d %7d %5lu %-5d %5d ",
assoc, sk, sctp_sk(sk)->type, sk->sk_state,
assoc->state, hash,
assoc->assoc_id,
@@ -353,11 +354,16 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v)
sctp_seq_dump_local_addrs(seq, epb);
seq_printf(seq, "<-> ");
sctp_seq_dump_remote_addrs(seq, assoc);
- seq_printf(seq, "\t%8lu %5d %5d %4d %4d %4d %8d ",
+ seq_printf(seq, "\t%8lu %5d %5d %4d %4d %4d %8d "
+ " %8d %8d %8d %8d",
assoc->hbinterval, assoc->c.sinit_max_instreams,
assoc->c.sinit_num_ostreams, assoc->max_retrans,
assoc->init_retries, assoc->shutdown_retries,
- assoc->rtx_data_chunks);
+ assoc->rtx_data_chunks,
+ atomic_read(&sk->sk_wmem_alloc),
+ sk->sk_wmem_queued,
+ sk->sk_sndbuf,
+ sk->sk_rcvbuf);
seq_printf(seq, "\n");
}
read_unlock(&head->lock);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs
2013-04-10 21:02 [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs Daya, Dilip (Telco Linux)
@ 2013-04-11 13:28 ` Neil Horman
2013-04-11 17:04 ` Dilip Daya
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Neil Horman @ 2013-04-11 13:28 UTC (permalink / raw)
To: linux-sctp
On Wed, Apr 10, 2013 at 09:02:19PM +0000, Daya, Dilip (Telco Linux) wrote:
> From: Dilip Daya <dilip.daya@hp.com>
>
> This patch adds the following fields to /proc/net/sctp/assocs output:
>
> - sk->sk_wmem_alloc (transmit queue bytes committed)
> - sk->sk_wmem_queued (persistent queue size)
> - sk->sk_sndbuf (size of send buffer in bytes)
> - sk->sk_rcvbuf (size of receive buffer in bytes)
>
> When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
> (assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
> peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching maximum
> value of sk_sndbuf.
>
> TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values are
> incremented in sctp_set_owner_w() for outgoing data chunks. Having access to
> the above values in /proc/net/sctp/assocs will provide a better understanding
> of SCTP buffer management.
>
> With patch applied, example output when peer.rwnd = 0
>
> where:
> ASSOC ffff880132298000 is sender
> ffff880125343000 is receiver
>
> # cat /proc/net/sctp/assocs
> ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE \
> ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656 0 \
> ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0 524520 \
>
> UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
> 0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
> 0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
>
> MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
> 4 0 0 72 525633 440320 524288 524288
> 4 0 0 0 1 0 524288 524288
>
>
>
> Signed-off-by: Dilip Daya <dilip.daya@hp.com>
> ---
> net/sctp/proc.c | 20 +++++++++++++-------
> 1 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 7923164..56636db 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -293,10 +293,11 @@ static void * sctp_assocs_seq_start(struct seq_file *seq, loff_t *pos)
> *pos = 0;
>
> if (*pos = 0)
> - seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
> - "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT "
> - "RPORT LADDRS <-> RADDRS "
> - "HBINT INS OUTS MAXRT T1X T2X RTXC\n");
> + seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
> + "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT RPORT "
> + "LADDRS <-> RADDRS HBINT INS OUTS MAXRT T1X"
> + " T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf"
> + " sk_rcvbuf\n");
>
I'm a bit leery of changing the spacing between the fields in the file like
you've done above. I know it would look better, but changing things like that
can change the behavior of user space parsers, which we need to be careful of.
Also, can't you get this information via ss -m?
Neil
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs
2013-04-10 21:02 [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs Daya, Dilip (Telco Linux)
2013-04-11 13:28 ` Neil Horman
@ 2013-04-11 17:04 ` Dilip Daya
2013-04-11 17:30 ` Neil Horman
2013-04-11 18:44 ` Daniel Borkmann
3 siblings, 0 replies; 5+ messages in thread
From: Dilip Daya @ 2013-04-11 17:04 UTC (permalink / raw)
To: linux-sctp
Hi Neil,
On Thu, 2013-04-11 at 09:28 -0400, Neil Horman wrote:
> On Wed, Apr 10, 2013 at 09:02:19PM +0000, Daya, Dilip (Telco Linux) wrote:
> > From: Dilip Daya <dilip.daya@hp.com>
> >
> > This patch adds the following fields to /proc/net/sctp/assocs output:
> >
> > - sk->sk_wmem_alloc (transmit queue bytes committed)
> > - sk->sk_wmem_queued (persistent queue size)
> > - sk->sk_sndbuf (size of send buffer in bytes)
> > - sk->sk_rcvbuf (size of receive buffer in bytes)
> >
> > When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
> > (assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
> > peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching maximum
> > value of sk_sndbuf.
> >
> > TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values are
> > incremented in sctp_set_owner_w() for outgoing data chunks. Having access to
> > the above values in /proc/net/sctp/assocs will provide a better understanding
> > of SCTP buffer management.
> >
> > With patch applied, example output when peer.rwnd = 0
> >
> > where:
> > ASSOC ffff880132298000 is sender
> > ffff880125343000 is receiver
> >
> > # cat /proc/net/sctp/assocs
> > ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE \
> > ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656 0 \
> > ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0 524520 \
> >
> > UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
> > 0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
> > 0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
> >
> > MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
> > 4 0 0 72 525633 440320 524288 524288
> > 4 0 0 0 1 0 524288 524288
> >
> >
> >
> > Signed-off-by: Dilip Daya <dilip.daya@hp.com>
> > ---
> > net/sctp/proc.c | 20 +++++++++++++-------
> > 1 files changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> > index 7923164..56636db 100644
> > --- a/net/sctp/proc.c
> > +++ b/net/sctp/proc.c
> > @@ -293,10 +293,11 @@ static void * sctp_assocs_seq_start(struct seq_file *seq, loff_t *pos)
> > *pos = 0;
> >
> > if (*pos = 0)
> > - seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
> > - "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT "
> > - "RPORT LADDRS <-> RADDRS "
> > - "HBINT INS OUTS MAXRT T1X T2X RTXC\n");
> > + seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
> > + "ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT RPORT "
> > + "LADDRS <-> RADDRS HBINT INS OUTS MAXRT T1X"
> > + " T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf"
> > + " sk_rcvbuf\n");
> >
> I'm a bit leery of changing the spacing between the fields in the file like
> you've done above. I know it would look better, but changing things like that
> can change the behavior of user space parsers, which we need to be careful of.
>
> Also, can't you get this information via ss -m?
For TCP connections, 'yes', not for SCTP associations.
Thank you for reviewing this.
So, here is v2 of the patch with the fields spacing taken care of:
---
From: Dilip Daya <dilip.daya@hp.com>
This patch adds the following fields to /proc/net/sctp/assocs output:
- sk->sk_wmem_alloc (transmit queue bytes committed)
- sk->sk_wmem_queued (persistent queue size)
- sk->sk_sndbuf (size of send buffer in bytes)
- sk->sk_rcvbuf (size of receive buffer in bytes)
When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
(assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching
maximum value of sk_sndbuf.
TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values
are incremented in sctp_set_owner_w() for outgoing data chunks. Having
access to the above values in /proc/net/sctp/assocs will provide a
better understanding of SCTP buffer management.
With patch applied, example output when peer.rwnd = 0
where:
ASSOC ffff880132298000 is sender
ffff880125343000 is receiver
ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE
RX_QUEUE \
ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656
0 \
ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0
524520 \
UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
4 0 0 72 525633 440320 524288 524288
4 0 0 0 1 0 524288 524288
Signed-off-by: Dilip Daya <dilip.daya@hp.com>
---
net/sctp/proc.c | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index 8c19e97..763abb3 100644
--- a/net/sctp/proc.c
+++ b/net/sctp/proc.c
@@ -296,7 +296,8 @@ static void * sctp_assocs_seq_start(struct seq_file
*seq, loff_t *pos)
seq_printf(seq, " ASSOC SOCK STY SST ST HBKT "
"ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT "
"RPORT LADDRS <-> RADDRS "
- "HBINT INS OUTS MAXRT T1X T2X RTXC\n");
+ "HBINT INS OUTS MAXRT T1X T2X RTXC "
+ "sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf\n");
return (void *)pos;
}
@@ -351,11 +352,16 @@ static int sctp_assocs_seq_show(struct seq_file
*seq, void *v)
sctp_seq_dump_local_addrs(seq, epb);
seq_printf(seq, "<-> ");
sctp_seq_dump_remote_addrs(seq, assoc);
- seq_printf(seq, "\t%8lu %5d %5d %4d %4d %4d %8d ",
+ seq_printf(seq, "\t%8lu %5d %5d %4d %4d %4d %8d "
+ "%8d %8d %8d %8d",
assoc->hbinterval, assoc->c.sinit_max_instreams,
assoc->c.sinit_num_ostreams, assoc->max_retrans,
assoc->init_retries, assoc->shutdown_retries,
- assoc->rtx_data_chunks);
+ assoc->rtx_data_chunks,
+ atomic_read(&sk->sk_wmem_alloc),
+ sk->sk_wmem_queued,
+ sk->sk_sndbuf,
+ sk->sk_rcvbuf);
seq_printf(seq, "\n");
}
read_unlock(&head->lock);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs
2013-04-10 21:02 [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs Daya, Dilip (Telco Linux)
2013-04-11 13:28 ` Neil Horman
2013-04-11 17:04 ` Dilip Daya
@ 2013-04-11 17:30 ` Neil Horman
2013-04-11 18:44 ` Daniel Borkmann
3 siblings, 0 replies; 5+ messages in thread
From: Neil Horman @ 2013-04-11 17:30 UTC (permalink / raw)
To: linux-sctp
On Thu, Apr 11, 2013 at 01:04:59PM -0400, Dilip Daya wrote:
> Hi Neil,
>
> On Thu, 2013-04-11 at 09:28 -0400, Neil Horman wrote:
> > On Wed, Apr 10, 2013 at 09:02:19PM +0000, Daya, Dilip (Telco Linux) wrote:
> > > From: Dilip Daya <dilip.daya@hp.com>
> > >
> > > This patch adds the following fields to /proc/net/sctp/assocs output:
> > >
> > > - sk->sk_wmem_alloc (transmit queue bytes committed)
> > > - sk->sk_wmem_queued (persistent queue size)
> > > - sk->sk_sndbuf (size of send buffer in bytes)
> > > - sk->sk_rcvbuf (size of receive buffer in bytes)
> > >
> > > When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
> > > (assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
> > > peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching maximum
> > > value of sk_sndbuf.
> > >
> > > TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values are
> > > incremented in sctp_set_owner_w() for outgoing data chunks. Having access to
> > > the above values in /proc/net/sctp/assocs will provide a better understanding
> > > of SCTP buffer management.
> > >
> > > With patch applied, example output when peer.rwnd = 0
> > >
> > > where:
> > > ASSOC ffff880132298000 is sender
> > > ffff880125343000 is receiver
> > >
> > > # cat /proc/net/sctp/assocs
> > > ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE \
> > > ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656 0 \
> > > ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0 524520 \
> > >
> > > UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
> > > 0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
> > > 0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
> > >
> > > MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
> > > 4 0 0 72 525633 440320 524288 524288
> > > 4 0 0 0 1 0 524288 524288
> > >
> > >
> > >
> > > Signed-off-by: Dilip Daya <dilip.daya@hp.com>
Its still a bit risky, but we've done it before, so I don't see a problem with
this at this point. Thanks!
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs
2013-04-10 21:02 [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs Daya, Dilip (Telco Linux)
` (2 preceding siblings ...)
2013-04-11 17:30 ` Neil Horman
@ 2013-04-11 18:44 ` Daniel Borkmann
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Borkmann @ 2013-04-11 18:44 UTC (permalink / raw)
To: linux-sctp
On 04/11/2013 07:30 PM, Neil Horman wrote:
> On Thu, Apr 11, 2013 at 01:04:59PM -0400, Dilip Daya wrote:
>> On Thu, 2013-04-11 at 09:28 -0400, Neil Horman wrote:
>>> On Wed, Apr 10, 2013 at 09:02:19PM +0000, Daya, Dilip (Telco Linux) wrote:
>>>> From: Dilip Daya <dilip.daya@hp.com>
>>>>
>>>> This patch adds the following fields to /proc/net/sctp/assocs output:
>>>>
>>>> - sk->sk_wmem_alloc (transmit queue bytes committed)
>>>> - sk->sk_wmem_queued (persistent queue size)
>>>> - sk->sk_sndbuf (size of send buffer in bytes)
>>>> - sk->sk_rcvbuf (size of receive buffer in bytes)
>>>>
>>>> When small DATA chunks containing 136 bytes data are sent the TX_QUEUE
>>>> (assoc->sndbuf_used) reaches a maximum of 40.9% of sk_sndbuf value when
>>>> peer.rwnd = 0. This was diagnosed from sk_wmem_alloc value reaching maximum
>>>> value of sk_sndbuf.
>>>>
>>>> TX_QUEUE (assoc->sndbuf_used), sk_wmem_alloc and sk_wmem_queued values are
>>>> incremented in sctp_set_owner_w() for outgoing data chunks. Having access to
>>>> the above values in /proc/net/sctp/assocs will provide a better understanding
>>>> of SCTP buffer management.
>>>>
>>>> With patch applied, example output when peer.rwnd = 0
>>>>
>>>> where:
>>>> ASSOC ffff880132298000 is sender
>>>> ffff880125343000 is receiver
>>>>
>>>> # cat /proc/net/sctp/assocs
>>>> ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE \
>>>> ffff880132298000 ffff880124a0a0c0 2 1 3 29325 1 214656 0 \
>>>> ffff880125343000 ffff8801237d7700 2 1 3 36210 2 0 524520 \
>>>>
>>>> UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS \
>>>> 0 25108 3455 3456 *10.4.8.3 <-> *10.5.8.3 7500 2 2 \
>>>> 0 27819 3456 3455 *10.5.8.3 <-> *10.4.8.3 7500 2 2 \
>>>>
>>>> MAXRT T1X T2X RTXC sk_wmem_alloc sk_wmem_queued sk_sndbuf sk_rcvbuf
>>>> 4 0 0 72 525633 440320 524288 524288
>>>> 4 0 0 0 1 0 524288 524288
>>>>
>>>>
>>>>
>>>> Signed-off-by: Dilip Daya <dilip.daya@hp.com>
> Its still a bit risky, but we've done it before, so I don't see a problem with
> this at this point. Thanks!
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Dilip, you also need to CC netdev at least, otherwise your patch will not
land in patchwork, so that Dave can pick it up.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-11 18:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-10 21:02 [PATCH] sctp: Add buffer utilization fields to /proc/net/sctp/assocs Daya, Dilip (Telco Linux)
2013-04-11 13:28 ` Neil Horman
2013-04-11 17:04 ` Dilip Daya
2013-04-11 17:30 ` Neil Horman
2013-04-11 18:44 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.