From: Nishanth Menon <nm@ti.com>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Paul Sokolovsky <paul.sokolovsky@linaro.org>
Subject: [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
Date: Fri, 12 Apr 2013 18:28:26 -0500 [thread overview]
Message-ID: <1365809306-1323-1-git-send-email-nm@ti.com> (raw)
From: Paul Sokolovsky <paul.sokolovsky@linaro.org>
An ifdef in drm.h expects to be compiled with full-fledged Linux
toolchain, but it's common to compile kernel with just bare-metal
toolchain which doesn't define __linux__. So, also add __KERNEL__
check.
[nm@ti.com: port forward to 3.9-rc6 and post to dri devel for feedback as RFC]
Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
---
Paul, Dri devel list,
I picked up this patch from linaro tree:
https://git.linaro.org/gitweb?p=people/asac/android/kernel/lt-ti.git;a=patch;h=719fbc876740cf75e82dd082ae5a00dfcf6fff7a
Discussion thread: http://lists.linaro.org/pipermail/linaro-dev/2011-June/thread.html#4874
Seems to me as a valid fix even for upstream perhaps?
Regards,
Nishanth Menon
include/uapi/drm/drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
index 8d1e2bb..73a99e4 100644
--- a/include/uapi/drm/drm.h
+++ b/include/uapi/drm/drm.h
@@ -36,7 +36,7 @@
#ifndef _DRM_H_
#define _DRM_H_
-#if defined(__linux__)
+#if defined(__KERNEL__) || defined(__linux__)
#include <linux/types.h>
#include <asm/ioctl.h>
--
1.7.9.5
next reply other threads:[~2013-04-12 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 23:28 Nishanth Menon [this message]
2013-04-16 3:15 ` [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain Dave Airlie
[not found] ` <1365809306-1323-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2013-04-16 9:48 ` Paul Sokolovsky
2013-04-16 10:50 ` Arnd Bergmann
2013-04-16 19:48 ` Nishanth Menon
2013-04-17 10:43 ` Arnd Bergmann
[not found] ` <201304171243.49854.arnd-r2nGTMty4D4@public.gmane.org>
2013-04-17 11:13 ` Rob Clark
2013-04-17 10:55 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365809306-1323-1-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=paul.sokolovsky@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.