From: "Jon Medhurst (Tixy)" <tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
dri-devel
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.
Date: Wed, 17 Apr 2013 11:55:37 +0100 [thread overview]
Message-ID: <1366196137.3383.54.camel@linaro1.home> (raw)
In-Reply-To: <26789313.AOGUY9QNc3@wuerfel>
On Tue, 2013-04-16 at 12:50 +0200, Arnd Bergmann wrote:
> On Tuesday 16 April 2013 12:48:28 Paul Sokolovsky wrote:
> > > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
> > > index 8d1e2bb..73a99e4 100644
> > > --- a/include/uapi/drm/drm.h
> > > +++ b/include/uapi/drm/drm.h
> > > @@ -36,7 +36,7 @@
> > > #ifndef _DRM_H_
> > > #define _DRM_H_
> > >
> > > -#if defined(__linux__)
> > > +#if defined(__KERNEL__) || defined(__linux__)
> > >
> > > #include <linux/types.h>
> > > #include <asm/ioctl.h>
>
> This is still completely bogus, the __KERNEL__ symbol has no significance here.
> Either make the compiler define __linux__, or remove this #ifdef completely.
I don't have the full background here but thought I would point out that
a similar issue seems to have just cropped up with fuse.h ...
http://lkml.org/lkml/2013/4/15/487
--
Tixy
prev parent reply other threads:[~2013-04-17 10:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 23:28 [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain Nishanth Menon
2013-04-16 3:15 ` Dave Airlie
[not found] ` <1365809306-1323-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2013-04-16 9:48 ` Paul Sokolovsky
2013-04-16 10:50 ` Arnd Bergmann
2013-04-16 19:48 ` Nishanth Menon
2013-04-17 10:43 ` Arnd Bergmann
[not found] ` <201304171243.49854.arnd-r2nGTMty4D4@public.gmane.org>
2013-04-17 11:13 ` Rob Clark
2013-04-17 10:55 ` Jon Medhurst (Tixy) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366196137.3383.54.camel@linaro1.home \
--to=tixy-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.