* [PATCH v4] systemd: added python-systemd package generation.
@ 2013-04-23 9:13 Yevhen Kyriukha
2013-04-23 13:41 ` Burton, Ross
2013-04-23 15:32 ` Saul Wold
0 siblings, 2 replies; 9+ messages in thread
From: Yevhen Kyriukha @ 2013-04-23 9:13 UTC (permalink / raw)
To: openembedded-core; +Cc: Yevhen Kyriukha
---
meta/recipes-core/systemd/systemd_199.bb | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
index 5240443..bbae6f8 100644
--- a/meta/recipes-core/systemd/systemd_199.bb
+++ b/meta/recipes-core/systemd/systemd_199.bb
@@ -16,7 +16,13 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
SECTION = "base/shell"
-inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives
+inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives pythonnative python-dir
+
+# need to export these variables for python-config to work
+export BUILD_SYS
+export HOST_SYS
+export STAGING_INCDIR
+export STAGING_LIBDIR
SRC_URI = "http://www.freedesktop.org/software/systemd/systemd-${PV}.tar.xz \
file://touchscreen.rules \
@@ -46,11 +52,13 @@ LDFLAGS_libc-uclibc_append = " -lrt"
GTKDOC_DOCDIR = "${S}/docs/"
-PACKAGECONFIG ??= "xz"
+PACKAGECONFIG ??= "xz python"
# Sign the journal for anti-tampering
PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
# Compress the journal
PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
+# Use python-systemd
+PACKAGECONFIG[python] = "--with-python,--without-python,python"
CACHED_CONFIGUREVARS = "ac_cv_path_KILL=${base_bindir}/kill"
@@ -65,7 +73,6 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
--disable-tcpwrap \
--enable-split-usr \
--disable-microhttpd \
- --without-python \
--with-sysvrcnd-path=${sysconfdir} \
--with-firmware-path=/lib/firmware \
ac_cv_path_KILL=${base_bindir}/kill \
@@ -119,7 +126,7 @@ python populate_packages_prepend (){
}
PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
-PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-kernel-install"
+PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-kernel-install python-${PN} python-${PN}-dbg python-${PN}-dev"
USERADD_PACKAGES = "${PN}"
GROUPADD_PARAM_${PN} = "-r lock; -r systemd-journal"
@@ -129,6 +136,11 @@ FILES_${PN}-analyze = "${bindir}/systemd-analyze"
FILES_${PN}-initramfs = "/init"
RDEPENDS_${PN}-initramfs = "${PN}"
+FILES_python-${PN} = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.py* ${PYTHON_SITEPACKAGES_DIR}/systemd/*.so"
+RDEPENDS_python-${PN} = "python-core python-datetime python-logging python-syslog"
+FILES_python-${PN}-dev = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.la"
+FILES_python-${PN}-dbg = "${PYTHON_SITEPACKAGES_DIR}/systemd/.debug"
+
FILES_${PN}-gui = "${bindir}/systemadm"
FILES_${PN}-vconsole-setup = "${systemd_unitdir}/systemd-vconsole-setup \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 9:13 [PATCH v4] systemd: added python-systemd package generation Yevhen Kyriukha
@ 2013-04-23 13:41 ` Burton, Ross
2013-04-23 13:52 ` Richard Purdie
2013-04-23 15:32 ` Saul Wold
1 sibling, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2013-04-23 13:41 UTC (permalink / raw)
To: Yevhen Kyriukha; +Cc: openembedded-core
On 23 April 2013 10:13, Yevhen Kyriukha <kirgene@gmail.com> wrote:
> +inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives pythonnative python-dir
Does this really need pythonnative? That's adding a python-native
dependency to build systemd.
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 13:41 ` Burton, Ross
@ 2013-04-23 13:52 ` Richard Purdie
2013-04-23 14:26 ` Yevhen Kyriukha
0 siblings, 1 reply; 9+ messages in thread
From: Richard Purdie @ 2013-04-23 13:52 UTC (permalink / raw)
To: Burton, Ross; +Cc: Yevhen Kyriukha, openembedded-core
On Tue, 2013-04-23 at 14:41 +0100, Burton, Ross wrote:
> On 23 April 2013 10:13, Yevhen Kyriukha <kirgene@gmail.com> wrote:
> > +inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives pythonnative python-dir
>
> Does this really need pythonnative? That's adding a python-native
> dependency to build systemd.
To handle python modules correctly, I suspect the answer is yes. It
would be better if we could make this inherit conditional somehow. I'm
also sceptical about the separate -dev/=dbg packages for the python
pieces, this isn't the standard practise.
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 13:52 ` Richard Purdie
@ 2013-04-23 14:26 ` Yevhen Kyriukha
2013-04-23 14:36 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Yevhen Kyriukha @ 2013-04-23 14:26 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
2013/4/23 Richard Purdie <richard.purdie@linuxfoundation.org>:
> On Tue, 2013-04-23 at 14:41 +0100, Burton, Ross wrote:
>> On 23 April 2013 10:13, Yevhen Kyriukha <kirgene@gmail.com> wrote:
>> > +inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives pythonnative python-dir
>>
>> Does this really need pythonnative? That's adding a python-native
>> dependency to build systemd.
>
> To handle python modules correctly, I suspect the answer is yes. It
> would be better if we could make this inherit conditional somehow. I'm
> also sceptical about the separate -dev/=dbg packages for the python
> pieces, this isn't the standard practise.
>
> Cheers,
>
> Richard
>
It isn't a pure python package but a combination of C library and
python therefore -dev and -dbg are needed.
Best regards,
Yevhen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 14:26 ` Yevhen Kyriukha
@ 2013-04-23 14:36 ` Burton, Ross
2013-04-23 14:42 ` Yevhen Kyriukha
0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2013-04-23 14:36 UTC (permalink / raw)
To: Yevhen Kyriukha; +Cc: Patches and discussions about the oe-core layer
On 23 April 2013 15:26, Yevhen Kyriukha <kirgene@gmail.com> wrote:
> It isn't a pure python package but a combination of C library and
> python therefore -dev and -dbg are needed.
FILES_python-${PN}-dev = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.la"
Nobody will be linking to that library as it's a shared module and
Python won't read .la files when looking for modules, so you don't
need this. Just delete it instead of packaging a useless file in a
useless package.
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 14:36 ` Burton, Ross
@ 2013-04-23 14:42 ` Yevhen Kyriukha
2013-04-23 14:55 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Yevhen Kyriukha @ 2013-04-23 14:42 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer
OK, and what about -dbg?
Best regards,
Yevhen
2013/4/23 Burton, Ross <ross.burton@intel.com>:
> On 23 April 2013 15:26, Yevhen Kyriukha <kirgene@gmail.com> wrote:
>> It isn't a pure python package but a combination of C library and
>> python therefore -dev and -dbg are needed.
>
> FILES_python-${PN}-dev = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.la"
>
> Nobody will be linking to that library as it's a shared module and
> Python won't read .la files when looking for modules, so you don't
> need this. Just delete it instead of packaging a useless file in a
> useless package.
>
> Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 9:13 [PATCH v4] systemd: added python-systemd package generation Yevhen Kyriukha
2013-04-23 13:41 ` Burton, Ross
@ 2013-04-23 15:32 ` Saul Wold
2013-04-23 16:01 ` Yevhen Kyriukha
1 sibling, 1 reply; 9+ messages in thread
From: Saul Wold @ 2013-04-23 15:32 UTC (permalink / raw)
To: Yevhen Kyriukha; +Cc: openembedded-core
On 04/23/2013 02:13 AM, Yevhen Kyriukha wrote:
> ---
> meta/recipes-core/systemd/systemd_199.bb | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
> index 5240443..bbae6f8 100644
> --- a/meta/recipes-core/systemd/systemd_199.bb
> +++ b/meta/recipes-core/systemd/systemd_199.bb
> @@ -16,7 +16,13 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
>
> SECTION = "base/shell"
>
> -inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives
> +inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d update-alternatives pythonnative python-dir
> +
> +# need to export these variables for python-config to work
> +export BUILD_SYS
> +export HOST_SYS
> +export STAGING_INCDIR
> +export STAGING_LIBDIR
>
> SRC_URI = "http://www.freedesktop.org/software/systemd/systemd-${PV}.tar.xz \
> file://touchscreen.rules \
> @@ -46,11 +52,13 @@ LDFLAGS_libc-uclibc_append = " -lrt"
>
> GTKDOC_DOCDIR = "${S}/docs/"
>
> -PACKAGECONFIG ??= "xz"
> +PACKAGECONFIG ??= "xz python"
I believe that the default should be python is not enabled.
Sau!
> # Sign the journal for anti-tampering
> PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
> # Compress the journal
> PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
> +# Use python-systemd
> +PACKAGECONFIG[python] = "--with-python,--without-python,python"
>
> CACHED_CONFIGUREVARS = "ac_cv_path_KILL=${base_bindir}/kill"
>
> @@ -65,7 +73,6 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
> --disable-tcpwrap \
> --enable-split-usr \
> --disable-microhttpd \
> - --without-python \
> --with-sysvrcnd-path=${sysconfdir} \
> --with-firmware-path=/lib/firmware \
> ac_cv_path_KILL=${base_bindir}/kill \
> @@ -119,7 +126,7 @@ python populate_packages_prepend (){
> }
> PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
>
> -PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-kernel-install"
> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-kernel-install python-${PN} python-${PN}-dbg python-${PN}-dev"
>
> USERADD_PACKAGES = "${PN}"
> GROUPADD_PARAM_${PN} = "-r lock; -r systemd-journal"
> @@ -129,6 +136,11 @@ FILES_${PN}-analyze = "${bindir}/systemd-analyze"
> FILES_${PN}-initramfs = "/init"
> RDEPENDS_${PN}-initramfs = "${PN}"
>
> +FILES_python-${PN} = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.py* ${PYTHON_SITEPACKAGES_DIR}/systemd/*.so"
> +RDEPENDS_python-${PN} = "python-core python-datetime python-logging python-syslog"
> +FILES_python-${PN}-dev = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.la"
> +FILES_python-${PN}-dbg = "${PYTHON_SITEPACKAGES_DIR}/systemd/.debug"
> +
> FILES_${PN}-gui = "${bindir}/systemadm"
>
> FILES_${PN}-vconsole-setup = "${systemd_unitdir}/systemd-vconsole-setup \
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v4] systemd: added python-systemd package generation.
2013-04-23 15:32 ` Saul Wold
@ 2013-04-23 16:01 ` Yevhen Kyriukha
0 siblings, 0 replies; 9+ messages in thread
From: Yevhen Kyriukha @ 2013-04-23 16:01 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
I'll send new patch without python in PACKAGECONFIG.
Best regards,
Yevhen
2013/4/23 Saul Wold <sgw@linux.intel.com>:
> On 04/23/2013 02:13 AM, Yevhen Kyriukha wrote:
>>
>> ---
>> meta/recipes-core/systemd/systemd_199.bb | 20 ++++++++++++++++----
>> 1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-core/systemd/systemd_199.bb
>> b/meta/recipes-core/systemd/systemd_199.bb
>> index 5240443..bbae6f8 100644
>> --- a/meta/recipes-core/systemd/systemd_199.bb
>> +++ b/meta/recipes-core/systemd/systemd_199.bb
>> @@ -16,7 +16,13 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam',
>> 'libpam', '', d)}"
>>
>> SECTION = "base/shell"
>>
>> -inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d
>> update-alternatives
>> +inherit gtk-doc useradd pkgconfig autotools perlnative update-rc.d
>> update-alternatives pythonnative python-dir
>> +
>> +# need to export these variables for python-config to work
>> +export BUILD_SYS
>> +export HOST_SYS
>> +export STAGING_INCDIR
>> +export STAGING_LIBDIR
>>
>> SRC_URI =
>> "http://www.freedesktop.org/software/systemd/systemd-${PV}.tar.xz \
>> file://touchscreen.rules \
>> @@ -46,11 +52,13 @@ LDFLAGS_libc-uclibc_append = " -lrt"
>>
>> GTKDOC_DOCDIR = "${S}/docs/"
>>
>> -PACKAGECONFIG ??= "xz"
>> +PACKAGECONFIG ??= "xz python"
>
>
> I believe that the default should be python is not enabled.
>
> Sau!
>
>
>> # Sign the journal for anti-tampering
>> PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
>> # Compress the journal
>> PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
>> +# Use python-systemd
>> +PACKAGECONFIG[python] = "--with-python,--without-python,python"
>>
>> CACHED_CONFIGUREVARS = "ac_cv_path_KILL=${base_bindir}/kill"
>>
>> @@ -65,7 +73,6 @@ EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
>> --disable-tcpwrap \
>> --enable-split-usr \
>> --disable-microhttpd \
>> - --without-python \
>> --with-sysvrcnd-path=${sysconfdir} \
>> --with-firmware-path=/lib/firmware \
>> ac_cv_path_KILL=${base_bindir}/kill \
>> @@ -119,7 +126,7 @@ python populate_packages_prepend (){
>> }
>> PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
>>
>> -PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze
>> ${PN}-kernel-install"
>> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze
>> ${PN}-kernel-install python-${PN} python-${PN}-dbg python-${PN}-dev"
>>
>> USERADD_PACKAGES = "${PN}"
>> GROUPADD_PARAM_${PN} = "-r lock; -r systemd-journal"
>> @@ -129,6 +136,11 @@ FILES_${PN}-analyze = "${bindir}/systemd-analyze"
>> FILES_${PN}-initramfs = "/init"
>> RDEPENDS_${PN}-initramfs = "${PN}"
>>
>> +FILES_python-${PN} = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.py*
>> ${PYTHON_SITEPACKAGES_DIR}/systemd/*.so"
>> +RDEPENDS_python-${PN} = "python-core python-datetime python-logging
>> python-syslog"
>> +FILES_python-${PN}-dev = "${PYTHON_SITEPACKAGES_DIR}/systemd/*.la"
>> +FILES_python-${PN}-dbg = "${PYTHON_SITEPACKAGES_DIR}/systemd/.debug"
>> +
>> FILES_${PN}-gui = "${bindir}/systemadm"
>>
>> FILES_${PN}-vconsole-setup = "${systemd_unitdir}/systemd-vconsole-setup
>> \
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-23 16:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-23 9:13 [PATCH v4] systemd: added python-systemd package generation Yevhen Kyriukha
2013-04-23 13:41 ` Burton, Ross
2013-04-23 13:52 ` Richard Purdie
2013-04-23 14:26 ` Yevhen Kyriukha
2013-04-23 14:36 ` Burton, Ross
2013-04-23 14:42 ` Yevhen Kyriukha
2013-04-23 14:55 ` Burton, Ross
2013-04-23 15:32 ` Saul Wold
2013-04-23 16:01 ` Yevhen Kyriukha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.