From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Rik van Riel <riel@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH v2 2/6] mm: make shrink_page_list with pages work from multiple zones
Date: Wed, 24 Apr 2013 10:41:00 +0900 [thread overview]
Message-ID: <1366767664-17541-3-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1366767664-17541-1-git-send-email-minchan@kernel.org>
Shrink_page_list expects all pages come from a same zone
but it's too limited to use.
This patch removes the dependency so next patch can use
shrink_page_list with pages from multiple zones.
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/vmscan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 6934f5b..82f4d6c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -706,7 +706,8 @@ static unsigned long shrink_page_list(struct list_head *page_list,
goto keep;
VM_BUG_ON(PageActive(page));
- VM_BUG_ON(page_zone(page) != zone);
+ if (zone)
+ VM_BUG_ON(page_zone(page) != zone);
sc->nr_scanned++;
@@ -952,7 +953,7 @@ keep:
* back off and wait for congestion to clear because further reclaim
* will encounter the same problem
*/
- if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc))
+ if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc) && zone)
zone_set_flag(zone, ZONE_CONGESTED);
free_hot_cold_page_list(&free_pages, 1);
--
1.8.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>,
Rik van Riel <riel@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH v2 2/6] mm: make shrink_page_list with pages work from multiple zones
Date: Wed, 24 Apr 2013 10:41:00 +0900 [thread overview]
Message-ID: <1366767664-17541-3-git-send-email-minchan@kernel.org> (raw)
In-Reply-To: <1366767664-17541-1-git-send-email-minchan@kernel.org>
Shrink_page_list expects all pages come from a same zone
but it's too limited to use.
This patch removes the dependency so next patch can use
shrink_page_list with pages from multiple zones.
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
mm/vmscan.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 6934f5b..82f4d6c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -706,7 +706,8 @@ static unsigned long shrink_page_list(struct list_head *page_list,
goto keep;
VM_BUG_ON(PageActive(page));
- VM_BUG_ON(page_zone(page) != zone);
+ if (zone)
+ VM_BUG_ON(page_zone(page) != zone);
sc->nr_scanned++;
@@ -952,7 +953,7 @@ keep:
* back off and wait for congestion to clear because further reclaim
* will encounter the same problem
*/
- if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc))
+ if (nr_dirty && nr_dirty == nr_congested && global_reclaim(sc) && zone)
zone_set_flag(zone, ZONE_CONGESTED);
free_hot_cold_page_list(&free_pages, 1);
--
1.8.2
next prev parent reply other threads:[~2013-04-24 1:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 1:40 [PATCH v2 0/6] Per process reclaim Minchan Kim
2013-04-24 1:40 ` Minchan Kim
2013-04-24 1:40 ` [PATCH v2 1/6] mm: " Minchan Kim
2013-04-24 1:40 ` Minchan Kim
2013-04-24 1:41 ` Minchan Kim [this message]
2013-04-24 1:41 ` [PATCH v2 2/6] mm: make shrink_page_list with pages work from multiple zones Minchan Kim
2013-04-24 1:41 ` [PATCH v2 3/6] mm: Remove shrink_page Minchan Kim
2013-04-24 1:41 ` Minchan Kim
2013-04-24 1:41 ` [PATCH v2 4/6] mm: Enhance per process reclaim to consider shared pages Minchan Kim
2013-04-24 1:41 ` Minchan Kim
2013-04-24 1:41 ` [PATCH v2 5/6] mm: Support address range reclaim Minchan Kim
2013-04-24 1:41 ` Minchan Kim
2013-04-24 11:01 ` Namhyung Kim
2013-04-24 11:01 ` Namhyung Kim
2013-04-25 0:50 ` Minchan Kim
2013-04-25 0:50 ` Minchan Kim
2013-04-24 1:41 ` [PATCH v2 6/6] add documentation on proc.txt Minchan Kim
2013-04-24 1:41 ` Minchan Kim
2013-04-24 6:49 ` Rob Landley
2013-04-24 6:49 ` Rob Landley
2013-04-24 8:18 ` Minchan Kim
2013-04-24 8:18 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366767664-17541-3-git-send-email-minchan@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.