All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-s390 <linux-s390@vger.kernel.org>,
	linux-bcache <linux-bcache@vger.kernel.org>,
	Coly Li <colyli@suse.de>,
	"open list:SOFTWARE RAID \(Multiple Disks\) SUPPORT"
	<linux-raid@vger.kernel.org>, Song Liu <song@kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	linux-block <linux-block@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [dm-devel] [PATCH 05/10] block: do not reassig ->bi_bdev when partition remapping
Date: Mon, 25 Jan 2021 11:03:24 -0700	[thread overview]
Message-ID: <13667b22-029b-d7be-02da-96fce22cfd8f@kernel.dk> (raw)
In-Reply-To: <2b600368-96fa-7caf-f05b-321de616f7c9@kernel.dk>

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

On 1/25/21 10:57 AM, Jens Axboe wrote:
> On 1/25/21 10:55 AM, Christoph Hellwig wrote:
>> On Mon, Jan 25, 2021 at 10:53:36AM -0700, Jens Axboe wrote:
>>> On Sun, Jan 24, 2021 at 3:05 AM Christoph Hellwig <hch@lst.de> wrote:
>>>>
>>>> There is no good reason to reassign ->bi_bdev when remapping the
>>>> partition-relative block number to the device wide one, as all the
>>>> information required by the drivers comes from the gendisk anyway.
>>>>
>>>> Keeping the original ->bi_bdev alive will allow to greatly simplify
>>>> the partition-away I/O accounting.
>>>
>>> This one causes boot failures for me on my laptop...
>>
>> Any output to share?  Details of the config?
> 
> .config attached - hard to share any output, as it seems to load the
> kernel fine, but latter parts of the boot process end up with errors
> after the screen blanks. It's a laptop, so nothing fancy in terms of
> logging. FWIW, it did boot on my test box.
> 
> Let me try and do a video...

Here you go, complaining about EOD access on partition 6.

sudo fdisk -l /dev/nvme0n1
Disk /dev/nvme0n1: 953.89 GiB, 1024209543168 bytes, 2000409264 sectors
Disk model: SAMSUNG MZVLB1T0HBLR-000L7              
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 51484599-D608-465A-A3A9-D36F1D6D126E

Device               Start        End   Sectors   Size Type
/dev/nvme0n1p1        2048     534527    532480   260M EFI System
/dev/nvme0n1p2      534528     567295     32768    16M Microsoft reserved
/dev/nvme0n1p3      567296  257560575 256993280 122.6G Microsoft basic data
/dev/nvme0n1p4  1998360576 2000408575   2048000  1000M Windows recovery environment
/dev/nvme0n1p5   257560576  261718015   4157440     2G Linux filesystem
/dev/nvme0n1p6   261718016  390625279 128907264  61.5G Linux filesystem
/dev/nvme0n1p7   390625280  421875711  31250432  14.9G Linux swap
/dev/nvme0n1p8   421875712 1007812607 585936896 279.4G Linux filesystem
/dev/nvme0n1p9  1007812608 1398437887 390625280 186.3G Linux filesystem
/dev/nvme0n1p10 1398437888 1593749503 195311616  93.1G Linux filesystem

Partition table entries are not in disk order.

-- 
Jens Axboe


[-- Attachment #2: 142655107_199537265212012_2586972813533745854_n.jpg --]
[-- Type: image/jpeg, Size: 70665 bytes --]

[-- Attachment #3: Type: text/plain, Size: 93 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Tejun Heo <tj@kernel.org>, Coly Li <colyli@suse.de>,
	Song Liu <song@kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	linux-bcache <linux-bcache@vger.kernel.org>,
	"open list:SOFTWARE RAID (Multiple Disks) SUPPORT" 
	<linux-raid@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH 05/10] block: do not reassig ->bi_bdev when partition remapping
Date: Mon, 25 Jan 2021 11:03:24 -0700	[thread overview]
Message-ID: <13667b22-029b-d7be-02da-96fce22cfd8f@kernel.dk> (raw)
In-Reply-To: <2b600368-96fa-7caf-f05b-321de616f7c9@kernel.dk>

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

On 1/25/21 10:57 AM, Jens Axboe wrote:
> On 1/25/21 10:55 AM, Christoph Hellwig wrote:
>> On Mon, Jan 25, 2021 at 10:53:36AM -0700, Jens Axboe wrote:
>>> On Sun, Jan 24, 2021 at 3:05 AM Christoph Hellwig <hch@lst.de> wrote:
>>>>
>>>> There is no good reason to reassign ->bi_bdev when remapping the
>>>> partition-relative block number to the device wide one, as all the
>>>> information required by the drivers comes from the gendisk anyway.
>>>>
>>>> Keeping the original ->bi_bdev alive will allow to greatly simplify
>>>> the partition-away I/O accounting.
>>>
>>> This one causes boot failures for me on my laptop...
>>
>> Any output to share?  Details of the config?
> 
> .config attached - hard to share any output, as it seems to load the
> kernel fine, but latter parts of the boot process end up with errors
> after the screen blanks. It's a laptop, so nothing fancy in terms of
> logging. FWIW, it did boot on my test box.
> 
> Let me try and do a video...

Here you go, complaining about EOD access on partition 6.

sudo fdisk -l /dev/nvme0n1
Disk /dev/nvme0n1: 953.89 GiB, 1024209543168 bytes, 2000409264 sectors
Disk model: SAMSUNG MZVLB1T0HBLR-000L7              
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 51484599-D608-465A-A3A9-D36F1D6D126E

Device               Start        End   Sectors   Size Type
/dev/nvme0n1p1        2048     534527    532480   260M EFI System
/dev/nvme0n1p2      534528     567295     32768    16M Microsoft reserved
/dev/nvme0n1p3      567296  257560575 256993280 122.6G Microsoft basic data
/dev/nvme0n1p4  1998360576 2000408575   2048000  1000M Windows recovery environment
/dev/nvme0n1p5   257560576  261718015   4157440     2G Linux filesystem
/dev/nvme0n1p6   261718016  390625279 128907264  61.5G Linux filesystem
/dev/nvme0n1p7   390625280  421875711  31250432  14.9G Linux swap
/dev/nvme0n1p8   421875712 1007812607 585936896 279.4G Linux filesystem
/dev/nvme0n1p9  1007812608 1398437887 390625280 186.3G Linux filesystem
/dev/nvme0n1p10 1398437888 1593749503 195311616  93.1G Linux filesystem

Partition table entries are not in disk order.

-- 
Jens Axboe


[-- Attachment #2: 142655107_199537265212012_2586972813533745854_n.jpg --]
[-- Type: image/jpeg, Size: 70665 bytes --]

  reply	other threads:[~2021-01-25 18:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24 10:02 [dm-devel] store a pointer to the block_device in struct bio (again) v2 Christoph Hellwig
2021-01-24 10:02 ` Christoph Hellwig
2021-01-24 10:02 ` [dm-devel] [PATCH 01/10] brd: remove the end of device check in brd_do_bvec Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 13:51   ` [dm-devel] " Johannes Thumshirn
2021-01-25 13:51     ` Johannes Thumshirn
2021-01-24 10:02 ` [dm-devel] [PATCH 02/10] dcssblk: remove the end of device check in dcssblk_submit_bio Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 13:52   ` [dm-devel] " Johannes Thumshirn
2021-01-25 13:52     ` Johannes Thumshirn
2021-01-24 10:02 ` [dm-devel] [PATCH 03/10] block: store a block_device pointer in struct bio Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-24 10:02 ` [dm-devel] [PATCH 04/10] block: simplify submit_bio_checks a bit Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 14:02   ` [dm-devel] " Johannes Thumshirn
2021-01-25 14:02     ` Johannes Thumshirn
2021-01-24 10:02 ` [dm-devel] [PATCH 05/10] block: do not reassig ->bi_bdev when partition remapping Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 17:53   ` [dm-devel] " Jens Axboe
2021-01-25 17:53     ` Jens Axboe
2021-01-25 17:55     ` [dm-devel] " Christoph Hellwig
2021-01-25 17:55       ` Christoph Hellwig
2021-01-25 17:57       ` [dm-devel] " Jens Axboe
2021-01-25 18:03         ` Jens Axboe [this message]
2021-01-25 18:03           ` Jens Axboe
2021-01-25 18:13           ` [dm-devel] " Christoph Hellwig
2021-01-25 18:13             ` Christoph Hellwig
2021-01-25 18:15             ` [dm-devel] " Jens Axboe
2021-01-25 18:15               ` Jens Axboe
2021-01-25 18:18               ` [dm-devel] " Christoph Hellwig
2021-01-25 18:18                 ` Christoph Hellwig
2021-01-25 18:19                 ` [dm-devel] " Jens Axboe
2021-01-25 18:19                   ` Jens Axboe
2021-01-25 18:21                   ` [dm-devel] " Christoph Hellwig
2021-01-25 18:21                     ` Christoph Hellwig
2021-01-25 18:31                     ` [dm-devel] " Jens Axboe
2021-01-25 18:31                       ` Jens Axboe
2021-01-24 10:02 ` [dm-devel] [PATCH 06/10] block: use ->bi_bdev for bio based I/O accounting Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-24 10:02 ` [dm-devel] [PATCH 07/10] blk-mq: use ->bi_bdev for " Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-24 10:02 ` [dm-devel] [PATCH 08/10] block: add a disk_uevent helper Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 14:14   ` [dm-devel] " Johannes Thumshirn
2021-01-25 14:14     ` Johannes Thumshirn
2021-01-24 10:02 ` [dm-devel] [PATCH 09/10] block: remove DISK_PITER_REVERSE Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-24 10:02 ` [dm-devel] [PATCH 10/10] block: use an xarray for disk->part_tbl Christoph Hellwig
2021-01-24 10:02   ` Christoph Hellwig
2021-01-25 16:24 ` [dm-devel] store a pointer to the block_device in struct bio (again) v2 Jens Axboe
2021-01-25 16:24   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13667b22-029b-d7be-02da-96fce22cfd8f@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.