From: Scott Wood <scottwood@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v5 0/8] In-kernel XICS interrupt controller emulation
Date: Sat, 27 Apr 2013 00:08:44 +0000 [thread overview]
Message-ID: <1367021324.26749.13@snotra> (raw)
In-Reply-To: <20130426235247.GB5743@iris.ozlabs.ibm.com> (from paulus@samba.org on Fri Apr 26 18:52:47 2013)
On 04/26/2013 06:52:47 PM, Paul Mackerras wrote:
> On Fri, Apr 26, 2013 at 12:13:33PM -0500, Scott Wood wrote:
>
> > Also please note that we no longer hold kvm->lock during device
> > creation, so your EEXIST check looks racy.
>
> Huh? Patch 2/8 adds this code:
>
> + mutex_lock(&kvm->lock);
> + if (kvm->arch.xics)
> + ret = -EEXIST;
> + else
> + kvm->arch.xics = xics;
> + mutex_unlock(&kvm->lock);
>
> How is that racy?
Sorry, it's not -- I must have been looking at the previous version of
the patchset by mistake. :-(
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Alexander Graf <agraf@suse.de>, <kvm@vger.kernel.org>,
<kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH v5 0/8] In-kernel XICS interrupt controller emulation
Date: Fri, 26 Apr 2013 19:08:44 -0500 [thread overview]
Message-ID: <1367021324.26749.13@snotra> (raw)
In-Reply-To: <20130426235247.GB5743@iris.ozlabs.ibm.com> (from paulus@samba.org on Fri Apr 26 18:52:47 2013)
On 04/26/2013 06:52:47 PM, Paul Mackerras wrote:
> On Fri, Apr 26, 2013 at 12:13:33PM -0500, Scott Wood wrote:
>
> > Also please note that we no longer hold kvm->lock during device
> > creation, so your EEXIST check looks racy.
>
> Huh? Patch 2/8 adds this code:
>
> + mutex_lock(&kvm->lock);
> + if (kvm->arch.xics)
> + ret = -EEXIST;
> + else
> + kvm->arch.xics = xics;
> + mutex_unlock(&kvm->lock);
>
> How is that racy?
Sorry, it's not -- I must have been looking at the previous version of
the patchset by mistake. :-(
-Scott
next prev parent reply other threads:[~2013-04-27 0:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 6:29 [PATCH v5 0/8] In-kernel XICS interrupt controller emulation Paul Mackerras
2013-04-18 6:29 ` Paul Mackerras
2013-04-18 6:30 ` [PATCH 1/8] KVM: PPC: Book3S: Add infrastructure to implement kernel-side RTAS calls Paul Mackerras
2013-04-18 6:30 ` Paul Mackerras
2013-04-18 6:30 ` [PATCH 2/8] KVM: PPC: Book3S: Add kernel emulation for the XICS interrupt controller Paul Mackerras
2013-04-18 6:30 ` Paul Mackerras
2013-04-18 6:30 ` [PATCH 3/8] KVM: PPC: Book3S HV: Speed up wakeups of CPUs on HV KVM Paul Mackerras
2013-04-18 6:30 ` Paul Mackerras
2013-04-18 6:31 ` [PATCH 4/8] KVM: PPC: Book3S HV: Add support for real mode ICP in XICS emulation Paul Mackerras
2013-04-18 6:31 ` Paul Mackerras
2013-04-18 6:31 ` [PATCH 5/8] KVM: PPC: Book3S HV: Improve real-mode handling of external interrupts Paul Mackerras
2013-04-18 6:31 ` Paul Mackerras
2013-04-18 6:32 ` [PATCH 6/8] KVM: PPC: Book3S: Add support for ibm,int-on/off RTAS calls Paul Mackerras
2013-04-18 6:32 ` Paul Mackerras
2013-04-18 6:32 ` [PATCH 7/8] KVM: PPC: Book3S: Facilities to save/restore XICS presentation ctrler state Paul Mackerras
2013-04-18 6:32 ` Paul Mackerras
2013-04-18 6:32 ` [PATCH 8/8] KVM: PPC: Book 3S: Add API for in-kernel XICS emulation Paul Mackerras
2013-04-18 6:32 ` Paul Mackerras
2013-04-26 14:30 ` [PATCH v5 0/8] In-kernel XICS interrupt controller emulation Alexander Graf
2013-04-26 14:30 ` Alexander Graf
2013-04-26 17:13 ` Scott Wood
2013-04-26 17:13 ` Scott Wood
2013-04-26 23:52 ` Paul Mackerras
2013-04-26 23:52 ` Paul Mackerras
2013-04-27 0:08 ` Scott Wood [this message]
2013-04-27 0:08 ` Scott Wood
2013-04-27 8:36 ` Paul Mackerras
2013-04-27 8:36 ` Paul Mackerras
2013-04-28 9:50 ` Alexander Graf
2013-04-28 9:50 ` Alexander Graf
2013-04-28 12:05 ` Paul Mackerras
2013-04-28 12:05 ` Paul Mackerras
2013-04-30 9:59 ` Alexander Graf
2013-04-30 9:59 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367021324.26749.13@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.