From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
David Miller <davem@davemloft.net>,
David Gibson <dwg@au1.ibm.com>
Subject: Re: net/eth/ibmveth: Fixup retrieval of MAC address
Date: Sat, 04 May 2013 07:17:32 +1000 [thread overview]
Message-ID: <1367615852.4389.98.camel@pasglop> (raw)
In-Reply-To: <1367598632.2756.3.camel@bwh-desktop.uk.solarflarecom.com>
On Fri, 2013-05-03 at 17:30 +0100, Ben Hutchings wrote:
> > + /* Workaround for old/broken pHyp */
> > + if (mac_len == 8)
> > + mac_addr_p += 2;
> > + if (mac_len != 6) {
>
> Missing 'else' before the second if?
Absolutely... oops :-) I couldn't find a version of pHyp with the wrong
property to test with. I suppose I could hack it up in OFW before boot.
I'll fix that and respin, sorry about that.
Cheers,
Ben.
> > + dev_err(&dev->dev, "VETH_MAC_ADDR attribute wrong len %d\n",
> > + mac_len);
> > + return -EINVAL;
> > + }
> [...]
>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
David Gibson <dwg@au1.ibm.com>
Subject: Re: net/eth/ibmveth: Fixup retrieval of MAC address
Date: Sat, 04 May 2013 07:17:32 +1000 [thread overview]
Message-ID: <1367615852.4389.98.camel@pasglop> (raw)
In-Reply-To: <1367598632.2756.3.camel@bwh-desktop.uk.solarflarecom.com>
On Fri, 2013-05-03 at 17:30 +0100, Ben Hutchings wrote:
> > + /* Workaround for old/broken pHyp */
> > + if (mac_len == 8)
> > + mac_addr_p += 2;
> > + if (mac_len != 6) {
>
> Missing 'else' before the second if?
Absolutely... oops :-) I couldn't find a version of pHyp with the wrong
property to test with. I suppose I could hack it up in OFW before boot.
I'll fix that and respin, sorry about that.
Cheers,
Ben.
> > + dev_err(&dev->dev, "VETH_MAC_ADDR attribute wrong len %d\n",
> > + mac_len);
> > + return -EINVAL;
> > + }
> [...]
>
next prev parent reply other threads:[~2013-05-03 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 1:35 net/eth/ibmveth: Fixup retrieval of MAC address Benjamin Herrenschmidt
2013-05-02 1:35 ` Benjamin Herrenschmidt
2013-05-03 16:30 ` Ben Hutchings
2013-05-03 16:30 ` Ben Hutchings
2013-05-03 21:17 ` Benjamin Herrenschmidt [this message]
2013-05-03 21:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367615852.4389.98.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.