From: Scott Wood <scottwood@freescale.com>
To: Caraman Mihai Claudiu-B02008 <B02008@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs
Date: Fri, 03 May 2013 23:30:46 +0000 [thread overview]
Message-ID: <1367623846.19391.15@snotra> (raw)
In-Reply-To: <300B73AA675FCE4A93EB4FC1D42459FF3E9D81@039-SN2MPN1-013.039d.mgd.msft.net> (from B02008@freescale.com on Fri May 3 17:59:32 2013)
On 05/03/2013 05:59:32 PM, Caraman Mihai Claudiu-B02008 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, May 04, 2013 1:07 AM
> > To: Caraman Mihai Claudiu-B02008
> > Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org;
> > linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and
> hangs
> >
> > I replaced the two calls to kvmppc_lazy_ee_enable() with calls to
> > hard_irq_disable(), and it seems to be working fine.
>
> Please take a look on 'KVM: PPC64: booke: Hard disable interrupts when
> entering guest' RFC thread and see if your solution addresses Ben's
> comments.
My original one didn't (there was a race if an interrupt comes in
between soft-disabling and hard-disabling, it wouldn't be received
until the guest exits for some other reason).
Instead, I turned the local_irq_disable() into hard_irq_disable() plus
trace_hardirqs_off(). This worked without warnings.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Caraman Mihai Claudiu-B02008 <B02008@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs
Date: Fri, 3 May 2013 18:30:46 -0500 [thread overview]
Message-ID: <1367623846.19391.15@snotra> (raw)
In-Reply-To: <300B73AA675FCE4A93EB4FC1D42459FF3E9D81@039-SN2MPN1-013.039d.mgd.msft.net> (from B02008@freescale.com on Fri May 3 17:59:32 2013)
On 05/03/2013 05:59:32 PM, Caraman Mihai Claudiu-B02008 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, May 04, 2013 1:07 AM
> > To: Caraman Mihai Claudiu-B02008
> > Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org;
> > linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and =20
> hangs
> >
> > I replaced the two calls to kvmppc_lazy_ee_enable() with calls to
> > hard_irq_disable(), and it seems to be working fine.
>=20
> Please take a look on 'KVM: PPC64: booke: Hard disable interrupts when
> entering guest' RFC thread and see if your solution addresses Ben's
> comments.
My original one didn't (there was a race if an interrupt comes in =20
between soft-disabling and hard-disabling, it wouldn't be received =20
until the guest exits for some other reason).
Instead, I turned the local_irq_disable() into hard_irq_disable() plus =20
trace_hardirqs_off(). This worked without warnings.
-Scott=
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Caraman Mihai Claudiu-B02008 <B02008@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs
Date: Fri, 3 May 2013 18:30:46 -0500 [thread overview]
Message-ID: <1367623846.19391.15@snotra> (raw)
In-Reply-To: <300B73AA675FCE4A93EB4FC1D42459FF3E9D81@039-SN2MPN1-013.039d.mgd.msft.net> (from B02008@freescale.com on Fri May 3 17:59:32 2013)
On 05/03/2013 05:59:32 PM, Caraman Mihai Claudiu-B02008 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, May 04, 2013 1:07 AM
> > To: Caraman Mihai Claudiu-B02008
> > Cc: Wood Scott-B07421; kvm-ppc@vger.kernel.org; kvm@vger.kernel.org;
> > linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and
> hangs
> >
> > I replaced the two calls to kvmppc_lazy_ee_enable() with calls to
> > hard_irq_disable(), and it seems to be working fine.
>
> Please take a look on 'KVM: PPC64: booke: Hard disable interrupts when
> entering guest' RFC thread and see if your solution addresses Ben's
> comments.
My original one didn't (there was a race if an interrupt comes in
between soft-disabling and hard-disabling, it wouldn't be received
until the guest exits for some other reason).
Instead, I turned the local_irq_disable() into hard_irq_disable() plus
trace_hardirqs_off(). This worked without warnings.
-Scott
next prev parent reply other threads:[~2013-05-03 23:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 16:11 [PATCH] KVM: PPC: Book3E 64: Fix IRQs warnings and hangs Mihai Caraman
2013-05-03 16:11 ` Mihai Caraman
2013-05-03 16:11 ` Mihai Caraman
2013-05-03 16:24 ` Alexander Graf
2013-05-03 16:24 ` Alexander Graf
2013-05-03 16:24 ` Alexander Graf
2013-05-03 22:03 ` Benjamin Herrenschmidt
2013-05-03 22:03 ` Benjamin Herrenschmidt
2013-05-03 22:03 ` Benjamin Herrenschmidt
2013-05-03 18:04 ` Scott Wood
2013-05-03 18:04 ` Scott Wood
2013-05-03 18:04 ` Scott Wood
2013-05-03 20:01 ` Caraman Mihai Claudiu-B02008
2013-05-03 20:01 ` Caraman Mihai Claudiu-B02008
2013-05-03 20:01 ` Caraman Mihai Claudiu-B02008
2013-05-03 20:15 ` Scott Wood
2013-05-03 20:15 ` Scott Wood
2013-05-03 20:15 ` Scott Wood
2013-05-03 20:56 ` Caraman Mihai Claudiu-B02008
2013-05-03 20:56 ` Caraman Mihai Claudiu-B02008
2013-05-03 20:56 ` Caraman Mihai Claudiu-B02008
2013-05-03 22:06 ` Scott Wood
2013-05-03 22:06 ` Scott Wood
2013-05-03 22:06 ` Scott Wood
2013-05-03 22:59 ` Caraman Mihai Claudiu-B02008
2013-05-03 22:59 ` Caraman Mihai Claudiu-B02008
2013-05-03 22:59 ` Caraman Mihai Claudiu-B02008
2013-05-03 23:30 ` Scott Wood [this message]
2013-05-03 23:30 ` Scott Wood
2013-05-03 23:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367623846.19391.15@snotra \
--to=scottwood@freescale.com \
--cc=B02008@freescale.com \
--cc=B07421@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.