From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: "tiejun.chen" <tiejun.chen@windriver.com>,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Mihai Caraman <mihai.caraman@freescale.com>,
Paul Mackerras <paulus@au1.ibm.com>
Subject: Re: [PATCH] kvm/ppc: interrupt disabling fixes
Date: Tue, 07 May 2013 20:23:24 +0000 [thread overview]
Message-ID: <1367958204.25488.14.camel@pasglop> (raw)
In-Reply-To: <1367953139.3398.28@snotra>
On Tue, 2013-05-07 at 13:58 -0500, Scott Wood wrote:
> This will have to wait until book3s_hv disables interrupts as well. If
> this does eventually happen, then the
> local_irq_enable()/kvmppc_lazy_ee_enable() should also probably go into
> kvmppc_prepare_to_enter() -- though that could cause problems in
> book3s_pr, if it's depending on the kvmppc_lazy_ee_enable() happening
> as late as it does.
Is book3s calling prepare_to_enter at all ? It has its own things with
no interrupt disabling which afaik is racy vs. checking for signals & resched...
(CC'ing Paul).
BTW. Linus just pulled my tree which contains my changed to hard_irq_disable()
to do the trace_hardirqs_off() when neeed.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: "tiejun.chen" <tiejun.chen@windriver.com>,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Mihai Caraman <mihai.caraman@freescale.com>,
Paul Mackerras <paulus@au1.ibm.com>
Subject: Re: [PATCH] kvm/ppc: interrupt disabling fixes
Date: Wed, 08 May 2013 06:23:24 +1000 [thread overview]
Message-ID: <1367958204.25488.14.camel@pasglop> (raw)
In-Reply-To: <1367953139.3398.28@snotra>
On Tue, 2013-05-07 at 13:58 -0500, Scott Wood wrote:
> This will have to wait until book3s_hv disables interrupts as well. If
> this does eventually happen, then the
> local_irq_enable()/kvmppc_lazy_ee_enable() should also probably go into
> kvmppc_prepare_to_enter() -- though that could cause problems in
> book3s_pr, if it's depending on the kvmppc_lazy_ee_enable() happening
> as late as it does.
Is book3s calling prepare_to_enter at all ? It has its own things with
no interrupt disabling which afaik is racy vs. checking for signals & resched...
(CC'ing Paul).
BTW. Linus just pulled my tree which contains my changed to hard_irq_disable()
to do the trace_hardirqs_off() when neeed.
Cheers,
Ben.
next parent reply other threads:[~2013-05-07 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1367953139.3398.28@snotra>
2013-05-07 20:23 ` Benjamin Herrenschmidt [this message]
2013-05-07 20:23 ` [PATCH] kvm/ppc: interrupt disabling fixes Benjamin Herrenschmidt
[not found] <1368059739.3398.64@snotra>
2013-05-09 2:51 ` Benjamin Herrenschmidt
2013-05-09 2:51 ` Benjamin Herrenschmidt
2013-05-07 3:32 Scott Wood
2013-05-07 3:32 ` Scott Wood
2013-05-07 3:55 ` Benjamin Herrenschmidt
2013-05-07 3:55 ` Benjamin Herrenschmidt
2013-05-07 10:00 ` tiejun.chen
2013-05-07 10:00 ` tiejun.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367958204.25488.14.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mihai.caraman@freescale.com \
--cc=paulus@au1.ibm.com \
--cc=scottwood@freescale.com \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.