All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Ren, Qiaowei" <qiaowei.ren@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log
Date: Thu, 9 May 2013 12:02:18 +0000	[thread overview]
Message-ID: <1368100938.2425.36.camel@x230> (raw)
In-Reply-To: <9E0BE1322F2F2246BD820DA9FC397ADE9A9BD2@SHSMSX102.ccr.corp.intel.com>

On Thu, 2013-05-09 at 08:05 +0000, Ren, Qiaowei wrote:
> On 2013-05-08, Matthew Garrett wrote:
> > How different are these logs to the TPM measurements exported via
> > securityfs?
> 
> These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM module that uses Intel® Trusted Execution Technology (Intel® TXT) to perform a measured and verified launch of an OS kernel/VMM.), and should be different from those TPM measurements (from BIOS?) exported via security.

Different in what way? What are they actually logging?

> > So I write a value here and then I see different chunks of log? This
> > doesn't seem like an optimal interface. What do these logs actually
> > contain? How do I know which block I should be reading?
> 
> Yes. Since total log size is bigger than one page 4K, the log have to be displayed in 4K-block indexed by block_index.
> These logs will be very helpful for txt related debugging.

If they're only intended for debugging then sysfs probably isn't the
best place for them. debugfs might make more sense.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "Ren, Qiaowei" <qiaowei.ren@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"Wei, Gang" <gang.wei@intel.com>
Subject: Re: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log
Date: Thu, 9 May 2013 12:02:18 +0000	[thread overview]
Message-ID: <1368100938.2425.36.camel@x230> (raw)
In-Reply-To: <9E0BE1322F2F2246BD820DA9FC397ADE9A9BD2@SHSMSX102.ccr.corp.intel.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1252 bytes --]

On Thu, 2013-05-09 at 08:05 +0000, Ren, Qiaowei wrote:
> On 2013-05-08, Matthew Garrett wrote:
> > How different are these logs to the TPM measurements exported via
> > securityfs?
> 
> These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM module that uses Intel® Trusted Execution Technology (Intel® TXT) to perform a measured and verified launch of an OS kernel/VMM.), and should be different from those TPM measurements (from BIOS?) exported via security.

Different in what way? What are they actually logging?

> > So I write a value here and then I see different chunks of log? This
> > doesn't seem like an optimal interface. What do these logs actually
> > contain? How do I know which block I should be reading?
> 
> Yes. Since total log size is bigger than one page 4K, the log have to be displayed in 4K-block indexed by block_index.
> These logs will be very helpful for txt related debugging.

If they're only intended for debugging then sysfs probably isn't the
best place for them. debugfs might make more sense.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2013-05-09 12:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 14:55 [PATCH 0/4] Intel TXT driver Qiaowei Ren
2013-05-07 14:55 ` [PATCH 1/4] driver: add TXT driver in kernel Qiaowei Ren
2013-05-08  2:32   ` Matthew Garrett
2013-05-08  2:32     ` Matthew Garrett
2013-05-10  3:38     ` Ren, Qiaowei
2013-05-10  3:38       ` Ren, Qiaowei
2013-05-07 14:55 ` [PATCH 2/4] driver: provide sysfs interfaces to access TXT config space Qiaowei Ren
2013-05-08  2:44   ` Matthew Garrett
2013-05-08  2:44     ` Matthew Garrett
2013-05-07 14:55 ` [PATCH 3/4] driver: provide sysfs interfaces to access TXT log Qiaowei Ren
2013-05-08  5:16   ` Matthew Garrett
2013-05-08  5:16     ` Matthew Garrett
2013-05-09  8:05     ` Ren, Qiaowei
2013-05-09  8:05       ` Ren, Qiaowei
2013-05-09 12:02       ` Matthew Garrett [this message]
2013-05-09 12:02         ` Matthew Garrett
2013-05-10  1:50         ` Ren, Qiaowei
2013-05-10  1:50           ` Ren, Qiaowei
2013-05-07 14:55 ` [PATCH 4/4] driver: provide sysfs interfaces to access SMX parameter Qiaowei Ren
2013-05-08  5:24   ` Matthew Garrett
2013-05-08  5:24     ` Matthew Garrett
2013-05-10  7:05     ` Ren, Qiaowei
2013-05-10  7:05       ` Ren, Qiaowei
2013-05-10 13:07       ` Matthew Garrett
2013-05-10 13:07         ` Matthew Garrett
2013-05-11  0:01         ` Ren, Qiaowei
2013-05-11  0:01           ` Ren, Qiaowei
2013-05-08  2:28 ` [PATCH 0/4] Intel TXT driver Matthew Garrett
2013-05-08  2:28   ` Matthew Garrett
2013-05-09  8:19   ` Ren, Qiaowei
2013-05-09  8:19     ` Ren, Qiaowei
2013-05-09 12:02     ` Matthew Garrett
2013-05-09 12:02       ` Matthew Garrett
2013-05-10  2:20       ` Ren, Qiaowei
2013-05-10  2:20         ` Ren, Qiaowei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368100938.2425.36.camel@x230 \
    --to=matthew.garrett@nebula.com \
    --cc=gang.wei@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qiaowei.ren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.