From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
Luciano Coelho <coelho@ti.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH 2/2] cfg80211/nl80211: Add coalesce support
Date: Wed, 22 May 2013 20:23:14 +0200 [thread overview]
Message-ID: <1369246994.8207.24.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F70430E801DC176@SC-VEXCH1.marvell.com>
> > Before you make any changes (I didn't get around to commenting on your
> > patches yesterday), I think you have to be more careful with the renames
> > to not break the API. Please provide defines or so to not break
> > compilation in the rename.
>
> "[PATCH 1/2] cfg80211/nl80211: rename packet pattern related
> structures and enums" should have taken care of the renames. Please
> let me know if I missed anything here.
It did in the kernel, I was referring to the changes in nl80211.h, as
far as I can tell those break existing userspace tools. You should be
able to compile tools like iw and wpa_supplicant with the new nl80211.h
without changing anything in them.
johannes
next prev parent reply other threads:[~2013-05-22 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 1:31 [PATCH 1/2] cfg80211/nl80211: rename packet pattern related structures and enums Bing Zhao
2013-05-21 1:31 ` [PATCH 2/2] cfg80211/nl80211: Add coalesce support Bing Zhao
2013-05-21 23:23 ` Luis R. Rodriguez
2013-05-21 23:59 ` Bing Zhao
2013-05-22 8:12 ` Johannes Berg
2013-05-22 18:06 ` Bing Zhao
2013-05-22 18:23 ` Johannes Berg [this message]
2013-05-22 18:46 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369246994.8207.24.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=coelho@ti.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rodrigue@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.