From: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
Luciano Coelho <coelho@ti.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH 2/2] cfg80211/nl80211: Add coalesce support
Date: Tue, 21 May 2013 16:23:03 -0700 [thread overview]
Message-ID: <20130521232303.GX6529@pogo> (raw)
In-Reply-To: <1369099918-4921-2-git-send-email-bzhao@marvell.com>
On Mon, May 20, 2013 at 06:31:58PM -0700, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> Add set/get configuration support for packet coalesce.
>
> This feature needs to be advertised during driver initialization.
> Drivers can do required hardware settings based on user configuration.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
I see nothing documenting clearly what this "coalesce" does.
Can you elaborate quite a bit both on the commit log and also
the documentation on nl80211.h what this is exactly? It would
also be good for you to express on your previous patch why
you want the rename.
If you add this also can you please be sure to update the wiki
for iw to document support for this?
Luis
next prev parent reply other threads:[~2013-05-21 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 1:31 [PATCH 1/2] cfg80211/nl80211: rename packet pattern related structures and enums Bing Zhao
2013-05-21 1:31 ` [PATCH 2/2] cfg80211/nl80211: Add coalesce support Bing Zhao
2013-05-21 23:23 ` Luis R. Rodriguez [this message]
2013-05-21 23:59 ` Bing Zhao
2013-05-22 8:12 ` Johannes Berg
2013-05-22 18:06 ` Bing Zhao
2013-05-22 18:23 ` Johannes Berg
2013-05-22 18:46 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521232303.GX6529@pogo \
--to=rodrigue@qca.qualcomm.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=coelho@ti.com \
--cc=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.