From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 4/6] ARM: dts: imx6q: add pinctrl for WEIM NOR
Date: Thu, 23 May 2013 13:14:00 +0400 [thread overview]
Message-ID: <1369300440.725629549@f101.mail.ru> (raw)
In-Reply-To: <1369296978-7669-5-git-send-email-b32955@freescale.com>
> Add a pinctrl for WEIM nor.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> arch/arm/boot/dts/imx6q.dtsi | 56 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 56 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
> index ed11bcf..2a6327a 100644
> --- a/arch/arm/boot/dts/imx6q.dtsi
> +++ b/arch/arm/boot/dts/imx6q.dtsi
> @@ -323,6 +323,62 @@
> >;
> };
> };
> +
> + weim {
> + pinctrl_weim_nor_1: weim_norgrp-1 {
I suggest remove "nor" label here since it can be used for other devices later.
> + fsl,pins = <
> + MX6Q_PAD_EIM_CS0__EIM_CS0_B 0xb0b1
Since driver can support multiple chipselects it would be nice to
define EIM_CSX in other place for possible using other chipselects.
> + MX6Q_PAD_EIM_OE__EIM_OE_B 0xb0b1
> + MX6Q_PAD_EIM_RW__EIM_RW 0xb0b1
> + MX6Q_PAD_EIM_WAIT__EIM_WAIT_B 0xb060
> +
> + /* data */
> + MX6Q_PAD_EIM_D16__EIM_DATA16 0xb0b1
> + MX6Q_PAD_EIM_D17__EIM_DATA17 0xb0b1
> + MX6Q_PAD_EIM_D18__EIM_DATA18 0xb0b1
> + MX6Q_PAD_EIM_D19__EIM_DATA19 0xb0b1
> + MX6Q_PAD_EIM_D20__EIM_DATA20 0xb0b1
> + MX6Q_PAD_EIM_D21__EIM_DATA21 0xb0b1
> + MX6Q_PAD_EIM_D22__EIM_DATA22 0xb0b1
> + MX6Q_PAD_EIM_D23__EIM_DATA23 0xb0b1
> + MX6Q_PAD_EIM_D24__EIM_DATA24 0xb0b1
> + MX6Q_PAD_EIM_D25__EIM_DATA25 0xb0b1
> + MX6Q_PAD_EIM_D26__EIM_DATA26 0xb0b1
> + MX6Q_PAD_EIM_D27__EIM_DATA27 0xb0b1
> + MX6Q_PAD_EIM_D28__EIM_DATA28 0xb0b1
> + MX6Q_PAD_EIM_D29__EIM_DATA29 0xb0b1
> + MX6Q_PAD_EIM_D30__EIM_DATA30 0xb0b1
> + MX6Q_PAD_EIM_D31__EIM_DATA31 0xb0b1
> +
> + /* address */
> + MX6Q_PAD_EIM_A23__EIM_ADDR23 0xb0b1
> + MX6Q_PAD_EIM_A22__EIM_ADDR22 0xb0b1
> + MX6Q_PAD_EIM_A21__EIM_ADDR21 0xb0b1
> + MX6Q_PAD_EIM_A20__EIM_ADDR20 0xb0b1
> + MX6Q_PAD_EIM_A19__EIM_ADDR19 0xb0b1
> + MX6Q_PAD_EIM_A18__EIM_ADDR18 0xb0b1
> + MX6Q_PAD_EIM_A17__EIM_ADDR17 0xb0b1
> + MX6Q_PAD_EIM_A16__EIM_ADDR16 0xb0b1
> + MX6Q_PAD_EIM_DA15__EIM_AD15 0xb0b1
> + MX6Q_PAD_EIM_DA14__EIM_AD14 0xb0b1
> + MX6Q_PAD_EIM_DA13__EIM_AD13 0xb0b1
> + MX6Q_PAD_EIM_DA12__EIM_AD12 0xb0b1
> + MX6Q_PAD_EIM_DA11__EIM_AD11 0xb0b1
> + MX6Q_PAD_EIM_DA10__EIM_AD10 0xb0b1
> + MX6Q_PAD_EIM_DA9__EIM_AD09 0xb0b1
> + MX6Q_PAD_EIM_DA8__EIM_AD08 0xb0b1
> + MX6Q_PAD_EIM_DA7__EIM_AD07 0xb0b1
> + MX6Q_PAD_EIM_DA6__EIM_AD06 0xb0b1
> + MX6Q_PAD_EIM_DA5__EIM_AD05 0xb0b1
> + MX6Q_PAD_EIM_DA4__EIM_AD04 0xb0b1
> + MX6Q_PAD_EIM_DA3__EIM_AD03 0xb0b1
> + MX6Q_PAD_EIM_DA2__EIM_AD02 0xb0b1
> + MX6Q_PAD_EIM_DA1__EIM_AD01 0xb0b1
> + MX6Q_PAD_EIM_DA0__EIM_AD00 0xb0b1
> + >;
> + };
> +
> + };
> };
> };
>
> --
---
WARNING: multiple messages have this Message-ID (diff)
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Huang Shijie" <b32955@freescale.com>
Cc: s.hauer@pengutronix.de, arnd@arndb.de,
devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
grant.likely@linaro.org, shawn.guo@linaro.org,
Alison_Chaiken@mentor.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 4/6] ARM: dts: imx6q: add pinctrl for WEIM NOR
Date: Thu, 23 May 2013 13:14:00 +0400 [thread overview]
Message-ID: <1369300440.725629549@f101.mail.ru> (raw)
In-Reply-To: <1369296978-7669-5-git-send-email-b32955@freescale.com>
> Add a pinctrl for WEIM nor.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> arch/arm/boot/dts/imx6q.dtsi | 56 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 56 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
> index ed11bcf..2a6327a 100644
> --- a/arch/arm/boot/dts/imx6q.dtsi
> +++ b/arch/arm/boot/dts/imx6q.dtsi
> @@ -323,6 +323,62 @@
> >;
> };
> };
> +
> + weim {
> + pinctrl_weim_nor_1: weim_norgrp-1 {
I suggest remove "nor" label here since it can be used for other devices later.
> + fsl,pins = <
> + MX6Q_PAD_EIM_CS0__EIM_CS0_B 0xb0b1
Since driver can support multiple chipselects it would be nice to
define EIM_CSX in other place for possible using other chipselects.
> + MX6Q_PAD_EIM_OE__EIM_OE_B 0xb0b1
> + MX6Q_PAD_EIM_RW__EIM_RW 0xb0b1
> + MX6Q_PAD_EIM_WAIT__EIM_WAIT_B 0xb060
> +
> + /* data */
> + MX6Q_PAD_EIM_D16__EIM_DATA16 0xb0b1
> + MX6Q_PAD_EIM_D17__EIM_DATA17 0xb0b1
> + MX6Q_PAD_EIM_D18__EIM_DATA18 0xb0b1
> + MX6Q_PAD_EIM_D19__EIM_DATA19 0xb0b1
> + MX6Q_PAD_EIM_D20__EIM_DATA20 0xb0b1
> + MX6Q_PAD_EIM_D21__EIM_DATA21 0xb0b1
> + MX6Q_PAD_EIM_D22__EIM_DATA22 0xb0b1
> + MX6Q_PAD_EIM_D23__EIM_DATA23 0xb0b1
> + MX6Q_PAD_EIM_D24__EIM_DATA24 0xb0b1
> + MX6Q_PAD_EIM_D25__EIM_DATA25 0xb0b1
> + MX6Q_PAD_EIM_D26__EIM_DATA26 0xb0b1
> + MX6Q_PAD_EIM_D27__EIM_DATA27 0xb0b1
> + MX6Q_PAD_EIM_D28__EIM_DATA28 0xb0b1
> + MX6Q_PAD_EIM_D29__EIM_DATA29 0xb0b1
> + MX6Q_PAD_EIM_D30__EIM_DATA30 0xb0b1
> + MX6Q_PAD_EIM_D31__EIM_DATA31 0xb0b1
> +
> + /* address */
> + MX6Q_PAD_EIM_A23__EIM_ADDR23 0xb0b1
> + MX6Q_PAD_EIM_A22__EIM_ADDR22 0xb0b1
> + MX6Q_PAD_EIM_A21__EIM_ADDR21 0xb0b1
> + MX6Q_PAD_EIM_A20__EIM_ADDR20 0xb0b1
> + MX6Q_PAD_EIM_A19__EIM_ADDR19 0xb0b1
> + MX6Q_PAD_EIM_A18__EIM_ADDR18 0xb0b1
> + MX6Q_PAD_EIM_A17__EIM_ADDR17 0xb0b1
> + MX6Q_PAD_EIM_A16__EIM_ADDR16 0xb0b1
> + MX6Q_PAD_EIM_DA15__EIM_AD15 0xb0b1
> + MX6Q_PAD_EIM_DA14__EIM_AD14 0xb0b1
> + MX6Q_PAD_EIM_DA13__EIM_AD13 0xb0b1
> + MX6Q_PAD_EIM_DA12__EIM_AD12 0xb0b1
> + MX6Q_PAD_EIM_DA11__EIM_AD11 0xb0b1
> + MX6Q_PAD_EIM_DA10__EIM_AD10 0xb0b1
> + MX6Q_PAD_EIM_DA9__EIM_AD09 0xb0b1
> + MX6Q_PAD_EIM_DA8__EIM_AD08 0xb0b1
> + MX6Q_PAD_EIM_DA7__EIM_AD07 0xb0b1
> + MX6Q_PAD_EIM_DA6__EIM_AD06 0xb0b1
> + MX6Q_PAD_EIM_DA5__EIM_AD05 0xb0b1
> + MX6Q_PAD_EIM_DA4__EIM_AD04 0xb0b1
> + MX6Q_PAD_EIM_DA3__EIM_AD03 0xb0b1
> + MX6Q_PAD_EIM_DA2__EIM_AD02 0xb0b1
> + MX6Q_PAD_EIM_DA1__EIM_AD01 0xb0b1
> + MX6Q_PAD_EIM_DA0__EIM_AD00 0xb0b1
> + >;
> + };
> +
> + };
> };
> };
>
> --
---
next prev parent reply other threads:[~2013-05-23 9:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:16 [PATCH V2 0/6] ARM: imx6q{dl}: add the WEIM driver Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 1/6] drivers: bus: add a new driver for WEIM Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 8:46 ` Alexander Shiyan
2013-05-23 8:46 ` Alexander Shiyan
2013-05-23 9:02 ` Huang Shijie
2013-05-23 9:02 ` Huang Shijie
2013-05-23 9:23 ` Sascha Hauer
2013-05-23 9:23 ` Sascha Hauer
2013-05-23 9:35 ` Huang Shijie
2013-05-23 9:35 ` Huang Shijie
2013-05-23 9:53 ` Arnd Bergmann
2013-05-23 9:53 ` Arnd Bergmann
2013-05-23 11:55 ` Sascha Hauer
2013-05-23 11:55 ` Sascha Hauer
2013-05-23 13:09 ` Arnd Bergmann
2013-05-23 13:09 ` Arnd Bergmann
2013-05-24 7:16 ` Huang Shijie
2013-05-24 7:16 ` Huang Shijie
2013-05-24 7:19 ` Sascha Hauer
2013-05-24 7:19 ` Sascha Hauer
2013-05-23 10:19 ` Russell King - ARM Linux
2013-05-23 10:19 ` Russell King - ARM Linux
2013-05-24 2:42 ` Huang Shijie
2013-05-24 2:42 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 2/6] ARM: dts: imx6q{dl}: fix the pin conflict between SPI and WEIM Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 3/6] ARM: dts: imx6qdl: add more information for WEIM Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 4/6] ARM: dts: imx6q: add pinctrl for WEIM NOR Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 9:14 ` Alexander Shiyan [this message]
2013-05-23 9:14 ` Alexander Shiyan
2013-05-23 9:27 ` Huang Shijie
2013-05-23 9:27 ` Huang Shijie
2013-05-23 9:39 ` Re[2]: " Alexander Shiyan
2013-05-23 9:39 ` Alexander Shiyan
2013-05-23 9:52 ` Huang Shijie
2013-05-23 9:52 ` Huang Shijie
2013-05-23 9:55 ` Re[2]: " Alexander Shiyan
2013-05-23 9:55 ` Alexander Shiyan
2013-05-24 2:41 ` Huang Shijie
2013-05-24 2:41 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 5/6] ARM: dts: imx6dl: add a " Huang Shijie
2013-05-23 8:16 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 6/6] ARM: dts: imx6qdl: enable the " Huang Shijie
2013-05-23 8:16 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369300440.725629549@f101.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.