From: David Ahern <dsahern@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: acme@ghostprotocols.net, mingo@kernel.org, fweisbec@gmail.com,
peterz@infradead.org, jolsa@redhat.com, namhyung@kernel.org,
xiaoguangrong@linux.vnet.ibm.com, runzhen@linux.vnet.ibm.com,
Runzhen Wang <icycoder@gmail.com>,
David Ahern <dsahern@gmail.com>
Subject: [PATCH 14/16] perf kvm: reuse some code of perf_kvm__timerfd_create()
Date: Sat, 25 May 2013 18:24:54 -0600 [thread overview]
Message-ID: <1369527896-3650-15-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1369527896-3650-1-git-send-email-dsahern@gmail.com>
From: Runzhen Wang <icycoder@gmail.com>
Create a new function perf_kvm__timerfd_set() to reuse some code
in perf_kvm__timerfd_create()
Signed-off-by: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
tools/perf/builtin-kvm.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 76cfe59..7392538 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -940,16 +940,9 @@ static void sig_handler(int sig __maybe_unused)
done = 1;
}
-static int perf_kvm__timerfd_create(struct perf_kvm_stat *kvm)
+static int perf_kvm__timerfd_set(struct perf_kvm_stat *kvm)
{
struct itimerspec new_value;
- int rc = -1;
-
- kvm->timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK);
- if (kvm->timerfd < 0) {
- pr_err("timerfd_create failed\n");
- goto out;
- }
new_value.it_value.tv_sec = kvm->display_time;
new_value.it_value.tv_nsec = 0;
@@ -959,12 +952,20 @@ static int perf_kvm__timerfd_create(struct perf_kvm_stat *kvm)
if (timerfd_settime(kvm->timerfd, 0, &new_value, NULL) != 0) {
pr_err("timerfd_settime failed: %d\n", errno);
close(kvm->timerfd);
- goto out;
+ return -1;
}
- rc = 0;
-out:
- return rc;
+ return 0;
+}
+
+static int perf_kvm__timerfd_create(struct perf_kvm_stat *kvm)
+{
+ kvm->timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK);
+ if (kvm->timerfd < 0) {
+ pr_err("timerfd_create failed\n");
+ return -1;
+ }
+ return perf_kvm__timerfd_set(kvm);
}
static int perf_kvm__handle_timerfd(struct perf_kvm_stat *kvm)
--
1.7.10.1
next prev parent reply other threads:[~2013-05-26 0:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 0:24 [PATCH 00/16] perf: kvm live mode David Ahern
2013-05-26 0:24 ` [PATCH 01/16] perf evlist: restore methods removed in earlier cleanup David Ahern
2013-05-26 0:24 ` [PATCH 02/16] perf evlist: move tracepoint processing code to evlist.c David Ahern
2013-05-26 0:24 ` [PATCH 03/16 v2] perf evlist: add initialzation function for tracepoints David Ahern
2013-05-26 0:24 ` [PATCH 04/16 v2] perf session: export a few functions for event processing David Ahern
2013-05-26 0:24 ` [PATCH 05/16] perf top: move CONSOLE_CLEAR to header file David Ahern
2013-05-26 0:24 ` [PATCH 06/16] perf kvm: handle realloc failures David Ahern
2013-05-31 11:49 ` [tip:perf/core] perf kvm: Handle " tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 07/16] perf kvm: split out tracepoints from record args David Ahern
2013-05-26 0:24 ` [PATCH 08/16] perf stats: fix divide by 0 in variance David Ahern
2013-05-31 11:51 ` [tip:perf/core] perf stats: Fix " tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 09/16] perf stats: add max and min stats David Ahern
2013-05-26 0:24 ` [PATCH 10/16 v2] perf kvm: add live mode David Ahern
2013-05-26 0:24 ` [PATCH 11/16] perf kvm: add min and max stats to display David Ahern
2013-05-26 0:24 ` [PATCH 12/16] perf kvm: option to print events that exceed a threshold David Ahern
2013-05-26 0:24 ` [PATCH 13/16] perf kvm: debug for missing vmexit/vmentry event David Ahern
2013-05-26 0:24 ` David Ahern [this message]
2013-09-12 13:08 ` [PATCH 14/16] perf kvm: reuse some code of perf_kvm__timerfd_create() Ingo Molnar
2013-09-12 13:34 ` David Ahern
2013-09-12 13:40 ` Ingo Molnar
2013-10-29 13:23 ` Ingo Molnar
2013-10-29 13:53 ` David Ahern
2013-10-29 13:58 ` Ingo Molnar
2013-05-26 0:24 ` [PATCH 15/16] perf kvm: move the prompt_integer() to /util/top.c David Ahern
2013-05-26 0:24 ` [PATCH 16/16] perf kvm: set live mode refresh time dynamically David Ahern
2013-05-26 0:29 ` Fwd: [PATCH 00/16] perf: kvm live mode David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369527896-3650-15-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=icycoder@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.