From: Ingo Molnar <mingo@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org, acme@ghostprotocols.net,
fweisbec@gmail.com, peterz@infradead.org, jolsa@redhat.com,
namhyung@kernel.org, xiaoguangrong@linux.vnet.ibm.com,
runzhen@linux.vnet.ibm.com, Runzhen Wang <icycoder@gmail.com>
Subject: Re: [PATCH 14/16] perf kvm: reuse some code of perf_kvm__timerfd_create()
Date: Thu, 12 Sep 2013 15:08:49 +0200 [thread overview]
Message-ID: <20130912130849.GA23826@gmail.com> (raw)
In-Reply-To: <1369527896-3650-15-git-send-email-dsahern@gmail.com>
btw., I tried to build perf on a really old distro that has no timerfd.h,
and got:
builtin-kvm.c:22:25: error: sys/timerfd.h: No such file or directory
cc1: warnings being treated as errors
builtin-kvm.c: In function ‘perf_kvm__timerfd_create’:
builtin-kvm.c:967: warning: implicit declaration of function ‘timerfd_create’
builtin-kvm.c:967: warning: nested extern declaration of ‘timerfd_create’
builtin-kvm.c:967: error: ‘TFD_NONBLOCK’ undeclared (first use in this function)
builtin-kvm.c:967: error: (Each undeclared identifier is reported only once
builtin-kvm.c:967: error: for each function it appears in.)
builtin-kvm.c:978: warning: implicit declaration of function ‘timerfd_settime’
builtin-kvm.c:978: warning: nested extern declaration of ‘timerfd_settime’
make: *** [builtin-kvm.o] Error 1
make: *** Waiting for unfinished jobs....
The quick patch below made it build - but it's incomplete, I have not
filled in the config/* details to generate HAVE_TIMERFD, I only made
builtin-kvm.o build.
Thanks,
Ingo
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 935d522..5cae8f2 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -19,7 +19,22 @@
#include "util/top.h"
#include <sys/prctl.h>
-#include <sys/timerfd.h>
+#ifdef HAVE_TIMERFD
+# include <sys/timerfd.h>
+#else
+# define TFD_NONBLOCK -1
+static int timerfd_create(clockid_t __clock_id __maybe_unused, int __flags __maybe_unused)
+{
+ return -1;
+}
+static int timerfd_settime(int __ufd __maybe_unused, int __flags __maybe_unused,
+ const struct itimerspec *__utmr __maybe_unused,
+ struct itimerspec *__otmr __maybe_unused)
+{
+ return -1;
+}
+
+#endif
#include <termios.h>
#include <semaphore.h>
next prev parent reply other threads:[~2013-09-12 13:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 0:24 [PATCH 00/16] perf: kvm live mode David Ahern
2013-05-26 0:24 ` [PATCH 01/16] perf evlist: restore methods removed in earlier cleanup David Ahern
2013-05-26 0:24 ` [PATCH 02/16] perf evlist: move tracepoint processing code to evlist.c David Ahern
2013-05-26 0:24 ` [PATCH 03/16 v2] perf evlist: add initialzation function for tracepoints David Ahern
2013-05-26 0:24 ` [PATCH 04/16 v2] perf session: export a few functions for event processing David Ahern
2013-05-26 0:24 ` [PATCH 05/16] perf top: move CONSOLE_CLEAR to header file David Ahern
2013-05-26 0:24 ` [PATCH 06/16] perf kvm: handle realloc failures David Ahern
2013-05-31 11:49 ` [tip:perf/core] perf kvm: Handle " tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 07/16] perf kvm: split out tracepoints from record args David Ahern
2013-05-26 0:24 ` [PATCH 08/16] perf stats: fix divide by 0 in variance David Ahern
2013-05-31 11:51 ` [tip:perf/core] perf stats: Fix " tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 09/16] perf stats: add max and min stats David Ahern
2013-05-26 0:24 ` [PATCH 10/16 v2] perf kvm: add live mode David Ahern
2013-05-26 0:24 ` [PATCH 11/16] perf kvm: add min and max stats to display David Ahern
2013-05-26 0:24 ` [PATCH 12/16] perf kvm: option to print events that exceed a threshold David Ahern
2013-05-26 0:24 ` [PATCH 13/16] perf kvm: debug for missing vmexit/vmentry event David Ahern
2013-05-26 0:24 ` [PATCH 14/16] perf kvm: reuse some code of perf_kvm__timerfd_create() David Ahern
2013-09-12 13:08 ` Ingo Molnar [this message]
2013-09-12 13:34 ` David Ahern
2013-09-12 13:40 ` Ingo Molnar
2013-10-29 13:23 ` Ingo Molnar
2013-10-29 13:53 ` David Ahern
2013-10-29 13:58 ` Ingo Molnar
2013-05-26 0:24 ` [PATCH 15/16] perf kvm: move the prompt_integer() to /util/top.c David Ahern
2013-05-26 0:24 ` [PATCH 16/16] perf kvm: set live mode refresh time dynamically David Ahern
2013-05-26 0:29 ` Fwd: [PATCH 00/16] perf: kvm live mode David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912130849.GA23826@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=icycoder@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.