[PATCH] xserver-xf86-config: re-enable AutoAddDevices for beagleboard

[PATCH] xserver-xf86-config: re-enable AutoAddDevices for beagleboard

[Paul Eggleton]

This was added quite a long time ago because of poor interactions
between HAL and the X server when it came to enabling input devices.
HAL is long gone and I think it's safe to say we don't need to disable
this any longer, especially as it gets in the way of being able to plug
in the keyboard/mouse after boot.

(This has already effectively been removed for the other BSPs in
meta-yocto-bsp).

Fixes [YOCTO #1823].

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
index 0335e6a..264f3c9 100644
--- a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
+++ b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
@@ -30,5 +30,4 @@ EndSection
 
 Section "ServerFlags"
 	Option		"DontZap"  "0"
-        Option		"AutoAddDevices" "False"
 EndSection
-- 
1.8.1.2

Re: [PATCH] xserver-xf86-config: re-enable AutoAddDevices for beagleboard

[Burton, Ross]

On 29 May 2013 16:01, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> This was added quite a long time ago because of poor interactions
> between HAL and the X server when it came to enabling input devices.
> HAL is long gone and I think it's safe to say we don't need to disable
> this any longer, especially as it gets in the way of being able to plug
> in the keyboard/mouse after boot.
>
> (This has already effectively been removed for the other BSPs in
> meta-yocto-bsp).
>
> Fixes [YOCTO #1823].
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> index 0335e6a..264f3c9 100644
> --- a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> +++ b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> @@ -30,5 +30,4 @@ EndSection
>
>  Section "ServerFlags"
>         Option          "DontZap"  "0"
> -        Option         "AutoAddDevices" "False"
>  EndSection

Signed-off-by: Ross Burton <ross.burton@intel.com>

Ross

Re: [PATCH] xserver-xf86-config: re-enable AutoAddDevices for beagleboard

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On Wed, May 29, 2013 at 04:01:12PM +0100, Paul Eggleton wrote:
> This was added quite a long time ago because of poor interactions
> between HAL and the X server when it came to enabling input devices.
> HAL is long gone and I think it's safe to say we don't need to disable
> this any longer, especially as it gets in the way of being able to plug
> in the keyboard/mouse after boot.
> 
> (This has already effectively been removed for the other BSPs in
> meta-yocto-bsp).
> 
> Fixes [YOCTO #1823].

Doesn't this break touchscreen calibration? At least when I was adding
it to my BSP it was also solving issues with xinput-calibrator expecting
input devices with specified names (and autoadded were different)

> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  .../xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf               | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> index 0335e6a..264f3c9 100644
> --- a/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> +++ b/meta-yocto-bsp/recipes-graphics/xorg-xserver/xserver-xf86-config/beagleboard/xorg.conf
> @@ -30,5 +30,4 @@ EndSection
>  
>  Section "ServerFlags"
>  	Option		"DontZap"  "0"
> -        Option		"AutoAddDevices" "False"
>  EndSection
> -- 
> 1.8.1.2
> 
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] xserver-xf86-config: re-enable AutoAddDevices for beagleboard

[Paul Eggleton]

On Wednesday 29 May 2013 17:56:24 Martin Jansa wrote:
> On Wed, May 29, 2013 at 04:01:12PM +0100, Paul Eggleton wrote:
> > This was added quite a long time ago because of poor interactions
> > between HAL and the X server when it came to enabling input devices.
> > HAL is long gone and I think it's safe to say we don't need to disable
> > this any longer, especially as it gets in the way of being able to plug
> > in the keyboard/mouse after boot.
> > 
> > (This has already effectively been removed for the other BSPs in
> > meta-yocto-bsp).
> > 
> > Fixes [YOCTO #1823].
> 
> Doesn't this break touchscreen calibration? 

I'd hope not...

> At least when I was adding it to my BSP it was also solving issues with
> xinput-calibrator expecting input devices with specified names (and autoadded
> were different)

Surely that's a deficiency in xinput-calibrator that should be fixed there if it 
is still a problem?

I didn't mention it in the commit message, but FWIW I did look at the meta-ti 
xorg.conf files and they don't have this line.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre