From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Yuanquan Chen <Yuanquan.Chen@freescale.com>,
Hiroo Matsumoto <matsumoto.hiroo@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Chen Yuanquan-B41889 <B41889@freescale.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pci: Improve device hotplug initialization
Date: Fri, 31 May 2013 15:44:07 +1000 [thread overview]
Message-ID: <1369979047.3928.112.camel@pasglop> (raw)
In-Reply-To: <20130531051423.GA15505@roeck-us.net>
On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote:
> On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote:
> > On 05/29/2013 01:35 AM, Guenter Roeck wrote:
> > >bios_add_device(). Drop explicit calls to pcibios_setup_device();
> > >this makes pcibios_setup_bus_devices() a noop function which could
> > >eve
> >
> > Yeah, it's more reasonable to do the irq and DMA related initialization
> > in one code path for all devices.
> >
> Any comments / feedback on the code itself ?
Sorry, I haven't had a chance to review it yet, I'm fairly bogged down
at the moment. I want to tread carefully because the previous iteration
of changing that stuff did break a few platforms in the end.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Chen Yuanquan-B41889 <B41889@freescale.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Yuanquan Chen <Yuanquan.Chen@freescale.com>,
Hiroo Matsumoto <matsumoto.hiroo@jp.fujitsu.com>
Subject: Re: [PATCH] powerpc/pci: Improve device hotplug initialization
Date: Fri, 31 May 2013 15:44:07 +1000 [thread overview]
Message-ID: <1369979047.3928.112.camel@pasglop> (raw)
In-Reply-To: <20130531051423.GA15505@roeck-us.net>
On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote:
> On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote:
> > On 05/29/2013 01:35 AM, Guenter Roeck wrote:
> > >bios_add_device(). Drop explicit calls to pcibios_setup_device();
> > >this makes pcibios_setup_bus_devices() a noop function which could
> > >eve
> >
> > Yeah, it's more reasonable to do the irq and DMA related initialization
> > in one code path for all devices.
> >
> Any comments / feedback on the code itself ?
Sorry, I haven't had a chance to review it yet, I'm fairly bogged down
at the moment. I want to tread carefully because the previous iteration
of changing that stuff did break a few platforms in the end.
Cheers,
Ben.
next prev parent reply other threads:[~2013-05-31 5:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:35 [PATCH] powerpc/pci: Improve device hotplug initialization Guenter Roeck
2013-05-28 17:35 ` Guenter Roeck
2013-05-29 9:30 ` Chen Yuanquan-B41889
2013-05-29 9:30 ` Chen Yuanquan-B41889
2013-05-31 5:14 ` Guenter Roeck
2013-05-31 5:14 ` Guenter Roeck
2013-05-31 5:44 ` Benjamin Herrenschmidt [this message]
2013-05-31 5:44 ` Benjamin Herrenschmidt
2013-06-01 13:58 ` Guenter Roeck
2013-06-01 13:58 ` Guenter Roeck
2013-06-03 2:28 ` Chen Yuanquan-B41889
2013-06-03 2:28 ` Chen Yuanquan-B41889
2013-06-03 4:11 ` Guenter Roeck
2013-06-03 4:11 ` Guenter Roeck
2013-06-06 1:00 ` Benjamin Herrenschmidt
2013-06-06 1:00 ` Benjamin Herrenschmidt
2013-06-06 5:25 ` Guenter Roeck
2013-06-06 5:25 ` Guenter Roeck
2013-06-06 5:44 ` Benjamin Herrenschmidt
2013-06-06 5:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369979047.3928.112.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B41889@freescale.com \
--cc=Yuanquan.Chen@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matsumoto.hiroo@jp.fujitsu.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.