All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Cc: jkenisto@linux.vnet.ibm.com, tony.luck@intel.com,
	mahesh@linux.vnet.ibm.com, cbouatmailru@gmail.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	paulus@samba.org, anton@samba.org, ccross@android.com,
	keescook@chromium.org
Subject: Re: [PATCH v3 0/8] Nvram-to-pstore
Date: Sat, 01 Jun 2013 15:25:48 +1000	[thread overview]
Message-ID: <1370064348.3766.37.camel@pasglop> (raw)
In-Reply-To: <20130425100952.21017.51799.stgit@aruna-ThinkPad-T420>

Another question...

Should the core pstore fail to unlink partitions that don't have
an ->erase callback ? IE. Why would you let anyone erase the OFW
common partition for example ? That means that userspace tools
can no longer manipulate it but we certainly don't want to remove
it from the nvram itself.

That leads to a deeper concern. Looking at how efi-pstore works,
it looks like they create a file for each var.

This looks like something valuable we could do for something like
the common partition since typically it's made of name,value pairs.

However, pstore is a flat space, while we have patitions which
themselves can be organized in name,value pairs (some at least)

I wonder if it's time to introduce pstore directories... Or do
we stick to our special tools to interpret/change the name,value
pairs ?

Also do we want to add an ability to resize partitions ? Possibly
based on how much is written to them ?

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
	linux-kernel@vger.kernel.org, jkenisto@linux.vnet.ibm.com,
	tony.luck@intel.com, ananth@in.ibm.com,
	mahesh@linux.vnet.ibm.com, ccross@android.com, anton@samba.org,
	cbouatmailru@gmail.com, keescook@chromium.org
Subject: Re: [PATCH v3 0/8] Nvram-to-pstore
Date: Sat, 01 Jun 2013 15:25:48 +1000	[thread overview]
Message-ID: <1370064348.3766.37.camel@pasglop> (raw)
In-Reply-To: <20130425100952.21017.51799.stgit@aruna-ThinkPad-T420>

Another question...

Should the core pstore fail to unlink partitions that don't have
an ->erase callback ? IE. Why would you let anyone erase the OFW
common partition for example ? That means that userspace tools
can no longer manipulate it but we certainly don't want to remove
it from the nvram itself.

That leads to a deeper concern. Looking at how efi-pstore works,
it looks like they create a file for each var.

This looks like something valuable we could do for something like
the common partition since typically it's made of name,value pairs.

However, pstore is a flat space, while we have patitions which
themselves can be organized in name,value pairs (some at least)

I wonder if it's time to introduce pstore directories... Or do
we stick to our special tools to interpret/change the name,value
pairs ?

Also do we want to add an ability to resize partitions ? Possibly
based on how much is written to them ?

Cheers,
Ben.



  parent reply	other threads:[~2013-06-01  5:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 10:17 [PATCH v3 0/8] Nvram-to-pstore Aruna Balakrishnaiah
2013-04-25 10:17 ` Aruna Balakrishnaiah
2013-04-25 10:18 ` [PATCH v3 1/8] powerpc/pseries: Remove syslog prefix in uncompressed oops text Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-04-25 10:18 ` [PATCH v3 2/8] powerpc/pseries: Add version and timestamp to oops header Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-04-25 10:18 ` [PATCH v3 3/8] powerpc/pseries: Introduce generic read function to read nvram-partitions Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-04-25 10:18 ` [PATCH v3 4/8] powerpc/pseries: Read/Write oops nvram partition via pstore Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-04-25 10:18 ` [PATCH v3 5/8] powerpc/pseries: Read rtas " Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-06-01  4:49   ` Benjamin Herrenschmidt
2013-06-01  4:49     ` Benjamin Herrenschmidt
2013-06-01  4:50     ` Benjamin Herrenschmidt
2013-06-01  4:50       ` Benjamin Herrenschmidt
2013-04-25 10:18 ` [PATCH v3 6/8] powerpc/pseries: Distinguish between a os-partition and non-os partition Aruna Balakrishnaiah
2013-04-25 10:18   ` Aruna Balakrishnaiah
2013-04-25 10:19 ` [PATCH v3 7/8] powerpc/pseries: Read of-config partition via pstore Aruna Balakrishnaiah
2013-04-25 10:19   ` Aruna Balakrishnaiah
2013-04-25 10:19 ` [PATCH v3 8/8] powerpc/pseries: Read common " Aruna Balakrishnaiah
2013-04-25 10:19   ` Aruna Balakrishnaiah
2013-06-01  4:52   ` Benjamin Herrenschmidt
2013-06-01  4:52     ` Benjamin Herrenschmidt
2013-06-04  9:02     ` Aruna Balakrishnaiah
2013-06-04  9:02       ` Aruna Balakrishnaiah
2013-06-01  4:40 ` [PATCH v3 0/8] Nvram-to-pstore Benjamin Herrenschmidt
2013-06-01  4:40   ` Benjamin Herrenschmidt
2013-06-01  4:43   ` Benjamin Herrenschmidt
2013-06-01  4:43     ` Benjamin Herrenschmidt
2013-06-01  5:25 ` Benjamin Herrenschmidt [this message]
2013-06-01  5:25   ` Benjamin Herrenschmidt
2013-06-05  9:00   ` Aruna Balakrishnaiah
2013-06-05  9:00     ` Aruna Balakrishnaiah
2013-06-05  9:43     ` Benjamin Herrenschmidt
2013-06-05  9:43       ` Benjamin Herrenschmidt
2013-06-05  9:52       ` Aruna Balakrishnaiah
2013-06-05  9:52         ` Aruna Balakrishnaiah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370064348.3766.37.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=anton@samba.org \
    --cc=aruna@linux.vnet.ibm.com \
    --cc=cbouatmailru@gmail.com \
    --cc=ccross@android.com \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.