All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2] Use a union of sigval instead of sigval_t
Date: Thu, 7 Jan 2016 08:43:27 -0500 (EST)	[thread overview]
Message-ID: <1370167031.5338451.1452174207521.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1452169516-104606-1-git-send-email-raj.khem@gmail.com>



----- Original Message -----
> From: "Khem Raj" <raj.khem@gmail.com>
> To: ltp@lists.linux.it
> Sent: Thursday, 7 January, 2016 1:25:16 PM
> Subject: [LTP] [PATCH V2] Use a union of sigval instead of sigval_t
> 
> sigval_t is glibc only construct, we use a union of sigval
> which pretty much is same effect as sigval_t
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Reviewed-by: Jan Stancek <jstancek@redhat.com>

Looks good to me, I think this should be safe to apply before release.
(I tested it across RHEL5.6/6.0/7.0)

Cyril, do you agree?

Regards,
Jan

> ---
>  lib/tlibio.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/tlibio.c b/lib/tlibio.c
> index 6b6103f..7b6bb33 100644
> --- a/lib/tlibio.c
> +++ b/lib/tlibio.c
> @@ -130,9 +130,6 @@
>  #endif
>  
>  static void lio_async_signal_handler();
> -#ifdef sgi
> -static void lio_async_callback_handler();
> -#endif
>  
>  /*
>   * Define the structure as used in lio_parse_arg1 and lio_help1
> @@ -441,7 +438,7 @@ static void lio_async_signal_handler(int sig)
>   * If the handler is called, it will increment the Received_callback
>   * global variable.
>   ***********************************************************************/
> -static void lio_async_callback_handler(sigval_t sigval)
> +static void lio_async_callback_handler(union sigval sigval)
>  {
>  	if (Debug_level)
>  		printf
> --
> 2.7.0
> 
> 
> --
> Mailing list info: http://lists.linux.it/listinfo/ltp
> 

  reply	other threads:[~2016-01-07 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 12:25 [LTP] [PATCH V2] Use a union of sigval instead of sigval_t Khem Raj
2016-01-07 13:43 ` Jan Stancek [this message]
2016-01-07 14:08   ` Cyril Hrubis
2016-01-07 14:24     ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370167031.5338451.1452174207521.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.