From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2] Use a union of sigval instead of sigval_t
Date: Thu, 7 Jan 2016 09:24:01 -0500 (EST) [thread overview]
Message-ID: <415704325.5352146.1452176641402.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160107140850.GB13423@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: "Khem Raj" <raj.khem@gmail.com>, ltp@lists.linux.it
> Sent: Thursday, 7 January, 2016 3:08:51 PM
> Subject: Re: [LTP] [PATCH V2] Use a union of sigval instead of sigval_t
>
> Hi!
> > > sigval_t is glibc only construct, we use a union of sigval
> > > which pretty much is same effect as sigval_t
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >
> > Reviewed-by: Jan Stancek <jstancek@redhat.com>
> >
> > Looks good to me, I think this should be safe to apply before release.
> > (I tested it across RHEL5.6/6.0/7.0)
> >
> > Cyril, do you agree?
>
> Looking into POSIX it explicitly says that the callback takes union
> sigval paramter and not sigval_t.
> (http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html)
>
> So this change should not break anything. Acked to go in before release
> by me as well.
Pushed with 2nd fwd declaration removed too and added POSIX reference
to commit message.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2016-01-07 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 12:25 [LTP] [PATCH V2] Use a union of sigval instead of sigval_t Khem Raj
2016-01-07 13:43 ` Jan Stancek
2016-01-07 14:08 ` Cyril Hrubis
2016-01-07 14:24 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415704325.5352146.1452176641402.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.