From: "Alexander Shiyan" <shc_work@mail.ru>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Re
Date: Wed, 05 Jun 2013 11:43:07 +0000 [thread overview]
Message-ID: <1370432587.906000493@f233.mail.ru> (raw)
In-Reply-To: <201306051336.49776.arnd@arndb.de>
> On Wednesday 05 June 2013, Alexander Shiyan wrote:
> > Well, let's leave the kconfig symbol as is. But about the rest, that mc13783_*
> > symbols in the log (debug) will say a developer who does not know about
> > mc13892 compatibility with mc13783? I still believe that this should be reflected.
>
> If the log messages use dev_printk, they will use the correct device name already,
> if not, that can be fixed.
>
> I agree with Jean: we don't just rename things unless there is a significant
> benefit, which I don't see here. There is also the risk that we need to support
> a different chip named mc13xxx in the future that is different enough to require
> a new driver and then the naming is even more screwed up.
It is a pity that the revision and updating of the code of this driver died.
Well, lets drop thesepatches.
Thanks.
---
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[4]: [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips
Date: Wed, 05 Jun 2013 15:43:07 +0400 [thread overview]
Message-ID: <1370432587.906000493@f233.mail.ru> (raw)
In-Reply-To: <201306051336.49776.arnd@arndb.de>
> On Wednesday 05 June 2013, Alexander Shiyan wrote:
> > Well, let's leave the kconfig symbol as is. But about the rest, that mc13783_*
> > symbols in the log (debug) will say a developer who does not know about
> > mc13892 compatibility with mc13783? I still believe that this should be reflected.
>
> If the log messages use dev_printk, they will use the correct device name already,
> if not, that can be fixed.
>
> I agree with Jean: we don't just rename things unless there is a significant
> benefit, which I don't see here. There is also the risk that we need to support
> a different chip named mc13xxx in the future that is different enough to require
> a new driver and then the naming is even more screwed up.
It is a pity that the revision and updating of the code of this driver died.
Well, lets drop thesepatches.
Thanks.
---
next prev parent reply other threads:[~2013-06-05 11:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 8:57 [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips Alexander Shiyan
2013-06-05 8:57 ` Alexander Shiyan
2013-06-05 8:57 ` [lm-sensors] [PATCH 2/2] hwmon: mc13783-adc: Rename unit to indicate various MC13xxx chips support Alexander Shiyan
2013-06-05 8:57 ` Alexander Shiyan
2013-06-05 9:02 ` [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips Jean Delvare
2013-06-05 9:02 ` Jean Delvare
2013-06-05 9:19 ` [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Re Alexander Shiyan
2013-06-05 9:19 ` Re[2]: [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips Alexander Shiyan
2013-06-05 10:53 ` [lm-sensors] " Jean Delvare
2013-06-05 10:53 ` Jean Delvare
2013-06-05 11:14 ` [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Re Alexander Shiyan
2013-06-05 11:14 ` Re[2]: [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips Alexander Shiyan
2013-06-05 11:36 ` [lm-sensors] " Arnd Bergmann
2013-06-05 11:36 ` Arnd Bergmann
2013-06-05 11:43 ` Alexander Shiyan [this message]
2013-06-05 11:43 ` Re[4]: " Alexander Shiyan
2013-06-05 11:45 ` [lm-sensors] " Jean Delvare
2013-06-05 11:45 ` Jean Delvare
2013-06-05 12:01 ` [lm-sensors] [PATCH 1/2] hwmon: mc13783-adc: Re Alexander Shiyan
2013-06-05 12:01 ` Re[2]: [PATCH 1/2] hwmon: mc13783-adc: Refactor source to indicate various mc13xxx chips Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370432587.906000493@f233.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.