From: Matthew Garrett <matthew.garrett@nebula.com>
To: Adam Lee <adam.lee@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"ibm-acpi-devel@lists.sourceforge.net"
<ibm-acpi-devel@lists.sourceforge.net>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Alex Hung <alex.hung@canonical.com>, Bjorn Mork <bjorn@mork.no>
Subject: Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs
Date: Fri, 7 Jun 2013 13:22:39 +0000 [thread overview]
Message-ID: <1370611358.6315.48.camel@x230.lan> (raw)
In-Reply-To: <1370593209-21358-4-git-send-email-adam.lee@canonical.com>
On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote:
> Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs.
> This patch adds their quirks.
Can you detect this case? If this is a new way of doing things then
you're going to have to add new entries to the quirk list every time
Lenovo release a new machine, which isn't really going to work.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: Adam Lee <adam.lee@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"ibm-acpi-devel@lists.sourceforge.net"
<ibm-acpi-devel@lists.sourceforge.net>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Alex Hung <alex.hung@canonical.com>, Bjorn Mork <bjorn@mork.no>
Subject: Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs
Date: Fri, 7 Jun 2013 13:22:39 +0000 [thread overview]
Message-ID: <1370611358.6315.48.camel@x230.lan> (raw)
In-Reply-To: <1370593209-21358-4-git-send-email-adam.lee@canonical.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 559 bytes --]
On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote:
> Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs.
> This patch adds their quirks.
Can you detect this case? If this is a new way of doing things then
you're going to have to add new entries to the quirk list every time
Lenovo release a new machine, which isn't really going to work.
--
Matthew Garrett | mjg59@srcf.ucam.org
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2013-06-07 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:20 [PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs Adam Lee
2013-06-07 8:20 ` [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs Adam Lee
2013-06-07 8:53 ` Bjørn Mork
2013-06-07 8:59 ` Adam Lee
2013-06-18 0:12 ` Henrique de Moraes Holschuh
2013-06-18 0:18 ` Henrique de Moraes Holschuh
2013-06-07 8:20 ` [PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk Adam Lee
2013-06-18 0:19 ` Henrique de Moraes Holschuh
2013-06-07 8:20 ` [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs Adam Lee
2013-06-07 13:22 ` Matthew Garrett [this message]
2013-06-07 13:22 ` Matthew Garrett
2013-06-07 15:06 ` Adam Lee
2013-06-07 20:16 ` Henrique de Moraes Holschuh
2013-06-07 20:16 ` Henrique de Moraes Holschuh
2013-06-08 9:04 ` Adam Lee
2013-06-18 0:20 ` Henrique de Moraes Holschuh
2013-06-07 9:05 ` [PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs Adam Lee
2013-06-08 2:19 ` Amos Kong
2013-06-08 8:51 ` [PATCH 1/3 v3] " Adam Lee
2013-06-18 0:17 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370611358.6315.48.camel@x230.lan \
--to=matthew.garrett@nebula.com \
--cc=adam.lee@canonical.com \
--cc=alex.hung@canonical.com \
--cc=bjorn@mork.no \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.