All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Mihai Caraman <mihai.caraman@freescale.com>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/8] kvm/ppc: fixes for 3.10
Date: Mon, 10 Jun 2013 19:52:49 +0000	[thread overview]
Message-ID: <1370893969.18413.14@snotra> (raw)
In-Reply-To: <20130609080921.GF4725@redhat.com> (from gleb@redhat.com on Sun Jun  9 03:09:21 2013)

On 06/09/2013 03:09:21 AM, Gleb Natapov wrote:
> On Thu, Jun 06, 2013 at 07:16:28PM -0500, Scott Wood wrote:
> > Most of these have been posted before, but I grouped them together  
> as
> > there are some contextual dependencies between them.
> >
> > Gleb/Paolo: As Alex doesn't appear to be back yet, can you apply  
> these
> > if there's no objection over the next few days?
> >
> Well we are at -rc5 now and Linus specifically said that if he sees  
> one
> more "cleanup" he will be less then happy [1]. Looks like this patch
> series does have some cleanups that can be postponed to 3.11.
> Patches 1-4,7 looks like 3.10 material to me. 5 and 6 a cleanups that  
> can
> wait for 3.11. Not sure about 8, if 8 fixes serious problem please
> specify it in the commit message.

Agreed.

8 did fix a BUG_ON before patch 7 came along, but now it looks  
non-critical.

5 only affects IRQ tracing, and it's not a regression, so also probably  
not critical.  I'll resend patch 7 so that it applies without needing  
patch 5.

6 is mainly doing things that we originally thought were a fix to lazy  
ee handling, until we noticed code elsewhere handling it in a hackier  
way.  There's still a bugfix in that previously kvm_guest_exit() was  
called in the wrong place which could occasionally mess up virtual time  
accounting, but that's also not a regression and not critical.

-Scott

WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Alexander Graf <agraf@suse.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Mihai Caraman <mihai.caraman@freescale.com>,
	<kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH 0/8] kvm/ppc: fixes for 3.10
Date: Mon, 10 Jun 2013 14:52:49 -0500	[thread overview]
Message-ID: <1370893969.18413.14@snotra> (raw)
In-Reply-To: <20130609080921.GF4725@redhat.com> (from gleb@redhat.com on Sun Jun  9 03:09:21 2013)

On 06/09/2013 03:09:21 AM, Gleb Natapov wrote:
> On Thu, Jun 06, 2013 at 07:16:28PM -0500, Scott Wood wrote:
> > Most of these have been posted before, but I grouped them together  
> as
> > there are some contextual dependencies between them.
> >
> > Gleb/Paolo: As Alex doesn't appear to be back yet, can you apply  
> these
> > if there's no objection over the next few days?
> >
> Well we are at -rc5 now and Linus specifically said that if he sees  
> one
> more "cleanup" he will be less then happy [1]. Looks like this patch
> series does have some cleanups that can be postponed to 3.11.
> Patches 1-4,7 looks like 3.10 material to me. 5 and 6 a cleanups that  
> can
> wait for 3.11. Not sure about 8, if 8 fixes serious problem please
> specify it in the commit message.

Agreed.

8 did fix a BUG_ON before patch 7 came along, but now it looks  
non-critical.

5 only affects IRQ tracing, and it's not a regression, so also probably  
not critical.  I'll resend patch 7 so that it applies without needing  
patch 5.

6 is mainly doing things that we originally thought were a fix to lazy  
ee handling, until we noticed code elsewhere handling it in a hackier  
way.  There's still a bugfix in that previously kvm_guest_exit() was  
called in the wrong place which could occasionally mess up virtual time  
accounting, but that's also not a regression and not critical.

-Scott

  reply	other threads:[~2013-06-10 19:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07  0:16 [PATCH 0/8] kvm/ppc: fixes for 3.10 Scott Wood
2013-06-07  0:16 ` Scott Wood
2013-06-07  0:16 ` [PATCH 1/8] kvm/ppc/booke64: Fix AltiVec interrupt numbers and build breakage Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 2/8] kvm/ppc/booke64: Disable e6500 support Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 3/8] kvm/ppc/booke: Hold srcu lock when calling gfn functions Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 4/8] kvm/ppc/booke64: Fix lazy ee handling in kvmppc_handle_exit() Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 5/8] kvm/ppc: Call trace_hardirqs_on before entry Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 6/8] kvm/ppc: IRQ disabling cleanup Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 7/8] kvm/ppc/booke: Delay kvmppc_fix_ee_before_entry Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-07  0:16 ` [PATCH 8/8] kvm/ppc/booke: Don't call kvm_guest_enter twice Scott Wood
2013-06-07  0:16   ` Scott Wood
2013-06-09  8:09 ` [PATCH 0/8] kvm/ppc: fixes for 3.10 Gleb Natapov
2013-06-09  8:09   ` Gleb Natapov
2013-06-10 19:52   ` Scott Wood [this message]
2013-06-10 19:52     ` Scott Wood
2013-06-17 15:27     ` Paolo Bonzini
2013-06-17 15:27       ` Paolo Bonzini
2013-07-09  7:21 ` tiejun.chen
2013-07-09  7:21   ` tiejun.chen
2013-07-09  8:53   ` Alexander Graf
2013-07-09  8:53     ` Alexander Graf
2013-07-09  9:09     ` tiejun.chen
2013-07-09  9:09       ` tiejun.chen
2013-07-09 21:33       ` Alexander Graf
2013-07-09 21:33         ` Alexander Graf
2013-07-10  6:03         ` tiejun.chen
2013-07-10  6:03           ` tiejun.chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370893969.18413.14@snotra \
    --to=scottwood@freescale.com \
    --cc=agraf@suse.de \
    --cc=gleb@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mihai.caraman@freescale.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.