All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates
Date: Tue, 11 Jun 2013 21:55:23 +0200	[thread overview]
Message-ID: <1370980523.8356.70.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130611171304.GA2189@gmail.com> (sfid-20130611_191323_492868_156158C4)

Now the subject should no longer say "mac80211:" :)

However... given that ieee80211_get_tx_rates() actually *copies* the
rates into the parameter, I guess it should do the rcu_read_lock()
internally. I guess I wasn't paying attention previously. Felix?

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Calvin Owens <jcalvinowens@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Felix Fietkau <nbd@openwrt.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates
Date: Tue, 11 Jun 2013 21:55:23 +0200	[thread overview]
Message-ID: <1370980523.8356.70.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130611171304.GA2189@gmail.com> (sfid-20130611_191323_492868_156158C4)

Now the subject should no longer say "mac80211:" :)

However... given that ieee80211_get_tx_rates() actually *copies* the
rates into the parameter, I guess it should do the rcu_read_lock()
internally. I guess I wasn't paying attention previously. Felix?

johannes



WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Calvin Owens <jcalvinowens@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Felix Fietkau <nbd@openwrt.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org
Subject: Re: [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates
Date: Tue, 11 Jun 2013 21:55:23 +0200	[thread overview]
Message-ID: <1370980523.8356.70.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130611171304.GA2189@gmail.com> (sfid-20130611_191323_492868_156158C4)

Now the subject should no longer say "mac80211:" :)

However... given that ieee80211_get_tx_rates() actually *copies* the
rates into the parameter, I guess it should do the rcu_read_lock()
internally. I guess I wasn't paying attention previously. Felix?

johannes



  reply	other threads:[~2013-06-11 19:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-09 22:51 rcu Calvin Owens
2013-06-10  4:29 ` [PATCH] mac80211: Fix bogus RCU warning from ieee80211_get_tx_rates (Was: Re: rcu) Calvin Owens
2013-06-11 11:42   ` Johannes Berg
2013-06-11 17:13     ` [ath9k-devel] [PATCH] mac80211: ath9k: Use RCU protection calling ieee80211_get_tx_rates Calvin Owens
2013-06-11 17:13       ` Calvin Owens
2013-06-11 17:13       ` Calvin Owens
2013-06-11 19:55       ` Johannes Berg [this message]
2013-06-11 19:55         ` Johannes Berg
2013-06-11 19:55         ` Johannes Berg
2013-06-12  6:37         ` [ath9k-devel] " Kalle Valo
2013-06-12  6:37           ` Kalle Valo
2013-06-12  6:37           ` Kalle Valo
2013-06-12  6:37           ` Kalle Valo
2013-06-12  7:56         ` [ath9k-devel] " Calvin Owens
2013-06-12  7:56           ` Calvin Owens
2013-06-12  7:56           ` Calvin Owens
2013-06-12  8:00           ` [ath9k-devel] [PATCH] mac80211: Use RCU protection in ieee80211_get_tx_rates() Calvin Owens
2013-06-12  8:00             ` Calvin Owens
2013-06-12  8:00             ` Calvin Owens
2013-06-12  9:47             ` [ath9k-devel] " Felix Fietkau
2013-06-12  9:47               ` Felix Fietkau
2013-06-12  9:47               ` Felix Fietkau
2013-06-13 15:27               ` [ath9k-devel] " Calvin Owens
2013-06-13 15:27                 ` Calvin Owens
2013-06-13 15:27                 ` Calvin Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370980523.8356.70.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.