From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 8/9] kvm/openpic: in-kernel mpic support
Date: Wed, 12 Jun 2013 15:36:11 -0500 [thread overview]
Message-ID: <1371069371.18413.50@snotra> (raw)
In-Reply-To: <B3B2436D-9F3B-478E-BEBF-677760CE0765@suse.de> (from agraf@suse.de on Wed Jun 12 08:01:06 2013)
On 06/12/2013 08:01:06 AM, Alexander Graf wrote:
>
> On 01.05.2013, at 03:48, Scott Wood wrote:
> > +static void kvm_openpic_region_add(MemoryListener *listener,
> > + MemoryRegionSection *section)
> > +{
> > + KVMOpenPICState *opp = container_of(listener, KVMOpenPICState,
> > + mem_listener);
> > + struct kvm_device_attr attr;
> > + uint64_t reg_base;
> > + int ret;
> > +
> > + if (section->address_space != &address_space_memory) {
> > + abort();
> > + }
> > +
> > + if (reg_base) {
>
> Check on uninitialized variable.
Oops, leftover debug code from when the code looked a bit different. :-P
I wonder why GCC (4.5) didn't warn about this.
-Scott
next prev parent reply other threads:[~2013-06-12 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 1:48 [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 2/9] KVM: PPC: Add dummy kvm_arch_init_irq_routing() Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 3/9] linux-headers: update to kvm next Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 4/9] KVM: Export kvm_init_irq_routing Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 5/9] KVM: MSI: Swap payload to native endianness Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 6/9] openpic: factor out some common defines into openpic.h Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 7/9] PPC: e500: factor out mpic init code Scott Wood
2013-05-01 1:48 ` [Qemu-devel] [PATCH 8/9] kvm/openpic: in-kernel mpic support Scott Wood
2013-06-12 13:01 ` Alexander Graf
2013-06-12 20:36 ` Scott Wood [this message]
2013-05-01 1:48 ` [Qemu-devel] [PATCH 9/9] KVM: PIC: Only commit irq routing when necessary Scott Wood
2013-06-12 13:04 ` [Qemu-devel] [PATCH v3 1/9] KVM: Don't assume that mpstate exists with in-kernel PIC always Alexander Graf
2013-06-12 20:16 ` Scott Wood
2013-06-12 20:54 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371069371.18413.50@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.