All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/edid: Don't print messages regarding stereo or csync by default
@ 2013-06-13 19:01 Egbert Eich
  2013-06-13 19:52 ` Adam Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Egbert Eich @ 2013-06-13 19:01 UTC (permalink / raw)
  To: dri-devel; +Cc: Dave Airlie, Jean Delvare, Egbert Eich

drm_mode_detailed() is called quite often, therefore when a monitor
that has a detailed timing mode marked DRM_EDID_PT_STEREO or requiring
composite sync, warning messages will clutter up the kernel log.
Like we already do for incorrect hsync/vsync pluse widths, print these
messages only when KMS debugging is enabled.

Signed-off-by: Egbert Eich <eich@suse.com>
---
 drivers/gpu/drm/drm_edid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index e8d17ee..2dc1a60 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1706,11 +1706,11 @@ static struct drm_display_mode *drm_mode_detailed(struct drm_device *dev,
 		return NULL;
 
 	if (pt->misc & DRM_EDID_PT_STEREO) {
-		printk(KERN_WARNING "stereo mode not supported\n");
+		DRM_DEBUG_KMS("stereo mode not supported\n");
 		return NULL;
 	}
 	if (!(pt->misc & DRM_EDID_PT_SEPARATE_SYNC)) {
-		printk(KERN_WARNING "composite sync not supported\n");
+		DRM_DEBUG_KMS("composite sync not supported\n");
 	}
 
 	/* it is incorrect if hsync/vsync width is zero */
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/edid: Don't print messages regarding stereo or csync by default
  2013-06-13 19:01 [PATCH] drm/edid: Don't print messages regarding stereo or csync by default Egbert Eich
@ 2013-06-13 19:52 ` Adam Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Adam Jackson @ 2013-06-13 19:52 UTC (permalink / raw)
  To: Egbert Eich; +Cc: Dave Airlie, Jean Delvare, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 512 bytes --]

On Thu, 2013-06-13 at 21:01 +0200, Egbert Eich wrote:
> drm_mode_detailed() is called quite often, therefore when a monitor
> that has a detailed timing mode marked DRM_EDID_PT_STEREO or requiring
> composite sync, warning messages will clutter up the kernel log.
> Like we already do for incorrect hsync/vsync pluse widths, print these
> messages only when KMS debugging is enabled.

Oof, yes, a thousand times yes, how were we still doing this.

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-13 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-13 19:01 [PATCH] drm/edid: Don't print messages regarding stereo or csync by default Egbert Eich
2013-06-13 19:52 ` Adam Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.