From: Heiko Stuebner <heiko@sntech.de>
To: linux-mediatek@lists.infradead.org, CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Paul Bolle <pebolle@tiscali.nl>,
Jitao Shi <jitao.shi@mediatek.com>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 2/2] drm/bridge: Add IT6151 bridge driver
Date: Thu, 12 Mar 2015 11:24:10 +0100 [thread overview]
Message-ID: <13714812.stPyeO78Dq@phil> (raw)
In-Reply-To: <1426150847.5304.22.camel@x220>
Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle:
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/it6151.c
> >
> > +#include <linux/module.h>
>
> This file can only be built-in. So I couldn't help but notice this
> include. And if I remove it
> make drivers/gpu/drm/bridge/it6151.o
>
> still runs without warning or errors. Unless I've missed something
> non-obvious I'd say it is not needed.
I think the more interesting question would be, why can it only be built in
:-) .
The drm/bridge series from Ajay Kumar [0] made it into 4.0-rc that enables
drm-bridges to be regular platform/i2c devices, see [1] for example.
So I think any new bridge driver should use this approach and can thus also be
build as module.
Heiko
[0] http://www.spinics.net/lists/linux-samsung-soc/msg41403.html
[1] http://www.spinics.net/lists/linux-samsung-soc/msg41406.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: linux-mediatek@lists.infradead.org, CK Hu <ck.hu@mediatek.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Jitao Shi <jitao.shi@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>,
srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH 2/2] drm/bridge: Add IT6151 bridge driver
Date: Thu, 12 Mar 2015 11:24:10 +0100 [thread overview]
Message-ID: <13714812.stPyeO78Dq@phil> (raw)
In-Reply-To: <1426150847.5304.22.camel@x220>
Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle:
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/it6151.c
> >
> > +#include <linux/module.h>
>
> This file can only be built-in. So I couldn't help but notice this
> include. And if I remove it
> make drivers/gpu/drm/bridge/it6151.o
>
> still runs without warning or errors. Unless I've missed something
> non-obvious I'd say it is not needed.
I think the more interesting question would be, why can it only be built in
:-) .
The drm/bridge series from Ajay Kumar [0] made it into 4.0-rc that enables
drm-bridges to be regular platform/i2c devices, see [1] for example.
So I think any new bridge driver should use this approach and can thus also be
build as module.
Heiko
[0] http://www.spinics.net/lists/linux-samsung-soc/msg41403.html
[1] http://www.spinics.net/lists/linux-samsung-soc/msg41406.html
next prev parent reply other threads:[~2015-03-12 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 6:18 [PATCH 1/2] dt-bindings: drm/bridge: Add IT6151 bridge chip driver bindings CK Hu
2015-03-11 6:18 ` CK Hu
2015-03-11 6:18 ` [PATCH 2/2] drm/bridge: Add IT6151 bridge driver CK Hu
2015-03-11 6:18 ` CK Hu
2015-03-12 9:00 ` Paul Bolle
2015-03-12 10:24 ` Heiko Stuebner [this message]
2015-03-12 10:24 ` Heiko Stuebner
[not found] ` <1426054733-54378-1-git-send-email-ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-12 10:35 ` [PATCH 1/2] dt-bindings: drm/bridge: Add IT6151 bridge chip driver bindings Matthias Brugger
2015-03-12 10:35 ` Matthias Brugger
-- strict thread matches above, loose matches on Subject: below --
2015-03-11 3:25 CK Hu
[not found] ` <1426044356-54844-1-git-send-email-ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-03-11 3:25 ` [PATCH 2/2] drm/bridge: Add IT6151 bridge driver CK Hu
2015-03-11 3:25 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13714812.stPyeO78Dq@phil \
--to=heiko@sntech.de \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.