Re: [PATCHv2 2/5] nl80211/cfg80211: add channel switch command

[Johannes Berg <johannes@sipsolutions.net>]

> +/* struct cfg80211_csa_settings - channel switch settings
> + *

/**
 * struct ...
 * ...

> + * @NL80211_ATTR_CH_SWITCH_COUNT: u32 attribute specifying the number of TBTT's
> + *	until the channel switch event.
> + * @NL80211_ATTR_CH_SWITCH_BLOCK_TX: flag attribute specifying that transmission
> + *	must be blocked on the current channel (before the channel switch
> + *	operation).
> + * @NL80211_ATTR_CSA_IES: Nested set of attributes containing the IE information
> + *	for the time while performing a channel switch.
> + * @NL80211_ATTR_CSA_C_OFF_BEACON: Offset of the channel switch counter
> + *	field in the beacons tail (%NL80211_ATTR_BEACON_TAIL).
> + * @NL80211_ATTR_CSA_C_OFF_PRESP: Offset of the channel switch counter
> + *	field in the probe response (%NL80211_ATTR_PROBE_RESP).

Shouldn't the offset be into the CSA_IES?

> +	struct nlattr *csa_ies[NL80211_ATTR_MAX+1];

Hmm, this doesn't seem right.

> +	err = nla_parse_nested(csa_ies, NL80211_ATTR_MAX,
> +				   info->attrs[NL80211_ATTR_CSA_IES],
> +				   nl80211_policy);

(Indentation)

If you're going to use nested IEs, shouldn't you define a separate
namespace to be used within the nesting?

johannes