All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org,
	Simon Wunderlich <siwu@hrz.tu-chemnitz.de>,
	Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>
Subject: Re: [PATCHv2 3/5] mac80211: add functions to duplicate a cfg80211_beacon
Date: Tue, 18 Jun 2013 16:49:32 +0200	[thread overview]
Message-ID: <1371566972.8318.33.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1371212124-26264-4-git-send-email-siwu@hrz.tu-chemnitz.de>

On Fri, 2013-06-14 at 14:15 +0200, Simon Wunderlich wrote:

> +static struct cfg80211_beacon_data *
> +cfg80211_beacon_dup(struct cfg80211_beacon_data *beacon)
> +{
> +	struct cfg80211_beacon_data *new_beacon;
> +	new_beacon = kzalloc(sizeof(*new_beacon), GFP_KERNEL);
> +	if (!beacon)
> +		return NULL;

Why not allocate one bigger block and use pointers into it? There's no
(reasonable) way that it'd get really big ...

johannes



  reply	other threads:[~2013-06-18 14:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 12:15 [PATCHv2 0/5] add master channel switch announcement support Simon Wunderlich
2013-06-14 12:15 ` [PATCHv2 1/5] nl80211: use attributes to parse beacons Simon Wunderlich
2013-06-18 13:56   ` Johannes Berg
2013-06-14 12:15 ` [PATCHv2 2/5] nl80211/cfg80211: add channel switch command Simon Wunderlich
2013-06-18 14:48   ` Johannes Berg
2013-06-18 15:14     ` Simon Wunderlich
2013-06-18 15:21       ` Johannes Berg
2013-06-18 14:50   ` Johannes Berg
2013-06-18 15:18     ` Simon Wunderlich
2013-06-18 15:20       ` Johannes Berg
2013-06-14 12:15 ` [PATCHv2 3/5] mac80211: add functions to duplicate a cfg80211_beacon Simon Wunderlich
2013-06-18 14:49   ` Johannes Berg [this message]
2013-06-18 15:20     ` Simon Wunderlich
2013-06-14 12:15 ` [PATCHv2 4/5] mac80211: add channel switch command and beacon callbacks Simon Wunderlich
2013-06-18 15:00   ` Johannes Berg
2013-06-18 17:27     ` Simon Wunderlich
2013-06-14 12:15 ` [PATCHv2 5/5] ath9k: enable CSA functionality in ath9k Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371566972.8318.33.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=simon.wunderlich@s2003.tu-chemnitz.de \
    --cc=siwu@hrz.tu-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.