From: Scott Wood <scottwood@freescale.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linuxppc-dev@lists.ozlabs.org,
Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 8/8] KVM: PPC: Add hugepage support for IOMMU in-kernel handling
Date: Thu, 27 Jun 2013 18:39:23 +0000 [thread overview]
Message-ID: <1372358363.8183.53@snotra> (raw)
In-Reply-To: <1372309356-28320-9-git-send-email-aik@ozlabs.ru> (from aik@ozlabs.ru on Thu Jun 27 00:02:36 2013)
On 06/27/2013 12:02:36 AM, Alexey Kardashevskiy wrote:
> +/*
> + * The KVM guest can be backed with 16MB pages.
> + * In this case, we cannot do page counting from the real mode
> + * as the compound pages are used - they are linked in a list
> + * with pointers as virtual addresses which are inaccessible
> + * in real mode.
> + *
> + * The code below keeps a 16MB pages list and uses page struct
> + * in real mode if it is already locked in RAM and inserted into
> + * the list or switches to the virtual mode where it can be
> + * handled in a usual manner.
> + */
> +#define KVMPPC_HUGEPAGE_HASH(gpa) hash_32(gpa >> 24, 32)
> +
> +struct kvmppc_iommu_hugepage {
> + struct hlist_node hash_node;
> + unsigned long gpa; /* Guest physical address */
> + unsigned long hpa; /* Host physical address */
> + struct page *page; /* page struct of the very first
> subpage */
> + unsigned long size; /* Huge page size (always 16MB at the
> moment) */
> +};
Shouldn't this be namespaced to something like "book3s" or "spapr"?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 8/8] KVM: PPC: Add hugepage support for IOMMU in-kernel handling
Date: Thu, 27 Jun 2013 13:39:23 -0500 [thread overview]
Message-ID: <1372358363.8183.53@snotra> (raw)
In-Reply-To: <1372309356-28320-9-git-send-email-aik@ozlabs.ru> (from aik@ozlabs.ru on Thu Jun 27 00:02:36 2013)
On 06/27/2013 12:02:36 AM, Alexey Kardashevskiy wrote:
> +/*
> + * The KVM guest can be backed with 16MB pages.
> + * In this case, we cannot do page counting from the real mode
> + * as the compound pages are used - they are linked in a list
> + * with pointers as virtual addresses which are inaccessible
> + * in real mode.
> + *
> + * The code below keeps a 16MB pages list and uses page struct
> + * in real mode if it is already locked in RAM and inserted into
> + * the list or switches to the virtual mode where it can be
> + * handled in a usual manner.
> + */
> +#define KVMPPC_HUGEPAGE_HASH(gpa) hash_32(gpa >> 24, 32)
> +
> +struct kvmppc_iommu_hugepage {
> + struct hlist_node hash_node;
> + unsigned long gpa; /* Guest physical address */
> + unsigned long hpa; /* Host physical address */
> + struct page *page; /* page struct of the very first =20
> subpage */
> + unsigned long size; /* Huge page size (always 16MB at the =20
> moment) */
> +};
Shouldn't this be namespaced to something like "book3s" or "spapr"?
-Scott=
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: <linuxppc-dev@lists.ozlabs.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
David Gibson <david@gibson.dropbear.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Alexander Graf <agraf@suse.de>, Paul Mackerras <paulus@samba.org>,
Alex Williamson <alex.williamson@redhat.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
<kvm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kvm-ppc@vger.kernel.org>
Subject: Re: [PATCH 8/8] KVM: PPC: Add hugepage support for IOMMU in-kernel handling
Date: Thu, 27 Jun 2013 13:39:23 -0500 [thread overview]
Message-ID: <1372358363.8183.53@snotra> (raw)
In-Reply-To: <1372309356-28320-9-git-send-email-aik@ozlabs.ru> (from aik@ozlabs.ru on Thu Jun 27 00:02:36 2013)
On 06/27/2013 12:02:36 AM, Alexey Kardashevskiy wrote:
> +/*
> + * The KVM guest can be backed with 16MB pages.
> + * In this case, we cannot do page counting from the real mode
> + * as the compound pages are used - they are linked in a list
> + * with pointers as virtual addresses which are inaccessible
> + * in real mode.
> + *
> + * The code below keeps a 16MB pages list and uses page struct
> + * in real mode if it is already locked in RAM and inserted into
> + * the list or switches to the virtual mode where it can be
> + * handled in a usual manner.
> + */
> +#define KVMPPC_HUGEPAGE_HASH(gpa) hash_32(gpa >> 24, 32)
> +
> +struct kvmppc_iommu_hugepage {
> + struct hlist_node hash_node;
> + unsigned long gpa; /* Guest physical address */
> + unsigned long hpa; /* Host physical address */
> + struct page *page; /* page struct of the very first
> subpage */
> + unsigned long size; /* Huge page size (always 16MB at the
> moment) */
> +};
Shouldn't this be namespaced to something like "book3s" or "spapr"?
-Scott
next prev parent reply other threads:[~2013-06-27 18:39 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 5:02 [PATCH 0/8 v4] KVM: PPC: IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 1/8] KVM: PPC: reserve a capability number for multitce support Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-07-09 15:35 ` Alexander Graf
2013-07-09 15:35 ` Alexander Graf
2013-07-09 15:35 ` Alexander Graf
2013-07-09 23:35 ` Alexey Kardashevskiy
2013-07-09 23:35 ` Alexey Kardashevskiy
2013-07-09 23:35 ` Alexey Kardashevskiy
2013-07-10 10:27 ` Alexander Graf
2013-07-10 10:27 ` Alexander Graf
2013-07-10 10:27 ` Alexander Graf
2013-07-10 14:17 ` Alexey Kardashevskiy
2013-07-10 14:17 ` Alexey Kardashevskiy
2013-07-10 14:17 ` Alexey Kardashevskiy
2013-07-10 15:00 ` Alexander Graf
2013-07-10 15:00 ` Alexander Graf
2013-07-10 15:00 ` Alexander Graf
2013-06-27 5:02 ` [PATCH 3/8] vfio: add external user support Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 6:47 ` Stephen Rothwell
2013-06-27 6:47 ` Stephen Rothwell
2013-06-27 6:47 ` Stephen Rothwell
2013-06-27 7:14 ` [PATCH v2] " Alexey Kardashevskiy
2013-06-27 7:14 ` Alexey Kardashevskiy
2013-06-27 7:50 ` Stephen Rothwell
2013-06-27 15:44 ` Alex Williamson
2013-06-27 15:44 ` Alex Williamson
2013-06-27 22:57 ` Alexey Kardashevskiy
2013-06-27 22:57 ` Alexey Kardashevskiy
2013-06-28 0:41 ` Alex Williamson
2013-06-28 0:41 ` Alex Williamson
2013-06-28 1:38 ` Alexey Kardashevskiy
2013-06-28 1:38 ` Alexey Kardashevskiy
2013-06-28 2:37 ` Alex Williamson
2013-06-28 2:37 ` Alex Williamson
2013-06-28 3:10 ` Alexey Kardashevskiy
2013-06-28 3:10 ` Alexey Kardashevskiy
2013-06-27 6:59 ` [PATCH 3/8] " Stephen Rothwell
2013-06-27 6:59 ` Stephen Rothwell
2013-06-27 6:59 ` Stephen Rothwell
2013-06-27 9:42 ` Benjamin Herrenschmidt
2013-06-27 9:42 ` Benjamin Herrenschmidt
2013-06-27 9:42 ` Benjamin Herrenschmidt
2013-06-27 10:48 ` Alexey Kardashevskiy
2013-06-27 10:48 ` Alexey Kardashevskiy
2013-06-27 10:48 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 4/8] hashtable: add hash_for_each_possible_rcu_notrace() Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 5/8] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 7/8] KVM: PPC: Add support for IOMMU in-kernel handling Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` [PATCH 8/8] KVM: PPC: Add hugepage " Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 5:02 ` Alexey Kardashevskiy
2013-06-27 18:39 ` Scott Wood [this message]
2013-06-27 18:39 ` Scott Wood
2013-06-27 18:39 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2013-07-06 15:06 [PATCH 0/8 v5] KVM: PPC: " Alexey Kardashevskiy
2013-07-06 15:07 ` [PATCH 8/8] KVM: PPC: Add hugepage support for " Alexey Kardashevskiy
2013-07-06 15:07 ` Alexey Kardashevskiy
2013-07-06 15:07 ` Alexey Kardashevskiy
2013-07-09 17:32 ` Alexander Graf
2013-07-09 17:32 ` Alexander Graf
2013-07-09 17:32 ` Alexander Graf
2013-07-09 23:29 ` Alexey Kardashevskiy
2013-07-09 23:29 ` Alexey Kardashevskiy
2013-07-09 23:29 ` Alexey Kardashevskiy
2013-07-10 10:33 ` Alexander Graf
2013-07-10 10:33 ` Alexander Graf
2013-07-10 10:33 ` Alexander Graf
2013-07-10 10:39 ` Benjamin Herrenschmidt
2013-07-10 10:39 ` Benjamin Herrenschmidt
2013-07-10 10:39 ` Benjamin Herrenschmidt
2013-07-10 10:40 ` Alexander Graf
2013-07-10 10:40 ` Alexander Graf
2013-07-10 10:40 ` Alexander Graf
2013-07-10 10:42 ` Alexander Graf
2013-07-10 10:42 ` Alexander Graf
2013-07-10 10:42 ` Alexander Graf
2013-07-11 8:57 ` Alexey Kardashevskiy
2013-07-11 8:57 ` Alexey Kardashevskiy
2013-07-11 8:57 ` Alexey Kardashevskiy
2013-07-11 9:52 ` Alexander Graf
2013-07-11 9:52 ` Alexander Graf
2013-07-11 9:52 ` Alexander Graf
2013-07-11 12:37 ` Benjamin Herrenschmidt
2013-07-11 12:37 ` Benjamin Herrenschmidt
2013-07-11 12:37 ` Benjamin Herrenschmidt
2013-07-11 12:50 ` Alexander Graf
2013-07-11 12:50 ` Alexander Graf
2013-07-11 12:50 ` Alexander Graf
2013-07-11 12:56 ` Benjamin Herrenschmidt
2013-07-11 12:56 ` Benjamin Herrenschmidt
2013-07-11 12:56 ` Benjamin Herrenschmidt
2013-07-11 13:41 ` chandrashekar shastri
2013-07-11 13:53 ` chandrashekar shastri
2013-07-11 13:41 ` chandrashekar shastri
2013-07-11 13:44 ` Alexander Graf
2013-07-11 13:44 ` Alexander Graf
2013-07-11 13:44 ` Alexander Graf
2013-07-11 13:46 ` Alexey Kardashevskiy
2013-07-11 13:46 ` Alexey Kardashevskiy
2013-07-11 13:46 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372358363.8183.53@snotra \
--to=scottwood@freescale.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.