All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Dajun Chen <david.chen@diasemi.com>,
	Ashish Jangam <ashish.jangam@kpitcummins.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: Multiple DA9055 chips
Date: Tue, 2 Jul 2013 15:32:37 +0530	[thread overview]
Message-ID: <1372759357.29900.3.camel@matrix> (raw)
In-Reply-To: <20130702093130.GX27646@sirena.org.uk>

On Tue, 2013-07-02 at 10:31 +0100, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
> > On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
> > > It seems we have two drivers in mainline for da9055 on I2C.  We've got
> > > one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
> > > both registering themselves identically.  What's going on here?  Is this
> > > a combined CODEC and PMIC, has someone decided to release two chips with
> > > the same name or is one of the drivers misnamed?
> 
> > Yes, this is a combined CODEC and PMIC.
> 
> OK, in that case the CODEC driver is just plain broken then.  Did anyone
> actually test this stuff?  Please fix.

Yes, I think so. Actually the CODEC driver was merged before PMIC ino
main line and was tested at that time. I will check with PMIC team if
they did test with CODEC.

I guess the fix should be in PMIC, right?

WARNING: multiple messages have this Message-ID (diff)
From: Ashish Chavan <ashish.chavan@kpitcummins.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Dajun Chen <david.chen@diasemi.com>,
	Ashish Jangam <ashish.jangam@kpitcummins.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: Multiple DA9055 chips
Date: Tue, 2 Jul 2013 15:32:37 +0530	[thread overview]
Message-ID: <1372759357.29900.3.camel@matrix> (raw)
In-Reply-To: <20130702093130.GX27646@sirena.org.uk>

On Tue, 2013-07-02 at 10:31 +0100, Mark Brown wrote:
> On Tue, Jul 02, 2013 at 03:01:53PM +0530, Ashish Chavan wrote:
> > On Mon, 2013-07-01 at 17:48 +0100, Mark Brown wrote:
> > > It seems we have two drivers in mainline for da9055 on I2C.  We've got
> > > one in sound/soc/codecs/da9055.c and one in drivers/mfd/da9055-i2c.c,
> > > both registering themselves identically.  What's going on here?  Is this
> > > a combined CODEC and PMIC, has someone decided to release two chips with
> > > the same name or is one of the drivers misnamed?
> 
> > Yes, this is a combined CODEC and PMIC.
> 
> OK, in that case the CODEC driver is just plain broken then.  Did anyone
> actually test this stuff?  Please fix.

Yes, I think so. Actually the CODEC driver was merged before PMIC ino
main line and was tested at that time. I will check with PMIC team if
they did test with CODEC.

I guess the fix should be in PMIC, right?



  reply	other threads:[~2013-07-02 10:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 16:48 Multiple DA9055 chips Mark Brown
2013-07-02  9:31 ` Ashish Chavan
2013-07-02  9:31   ` Ashish Chavan
2013-07-02  9:31   ` Mark Brown
2013-07-02  9:31     ` Mark Brown
2013-07-02 10:02     ` Ashish Chavan [this message]
2013-07-02 10:02       ` Ashish Chavan
2013-07-02 10:31       ` Mark Brown
2013-07-02 10:31         ` Mark Brown
2013-07-02 11:07         ` Ashish Chavan
2013-07-02 11:07           ` Ashish Chavan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372759357.29900.3.camel@matrix \
    --to=ashish.chavan@kpitcummins.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=broonie@kernel.org \
    --cc=david.chen@diasemi.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.