From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()
Date: Sat, 06 Jul 2013 09:05:11 +1000 [thread overview]
Message-ID: <1373065511.4446.11.camel@pasglop> (raw)
In-Reply-To: <CAErSpo52hic4nb-RtTT+e1nhXFeuWUJWajEzMy3j6wzWHVaG4A@mail.gmail.com>
On Fri, 2013-07-05 at 16:49 -0600, Bjorn Helgaas wrote:
> I know we have paths where we save config space, do a reset, and
> restore config space. I don't like those because some quirks aren't
> applied and I don't believe restoring config space is sufficient to
> make the device safe to use. There could be internal state that we
> aren't restoring. It's also possible that a firmware update means the
> device is different than it was before the reset, e.g., BARs could be
> different types or sizes.
True. Ok, I'll stick to the actual hotplug path then, you make
good points.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()
Date: Sat, 06 Jul 2013 09:05:11 +1000 [thread overview]
Message-ID: <1373065511.4446.11.camel@pasglop> (raw)
In-Reply-To: <CAErSpo52hic4nb-RtTT+e1nhXFeuWUJWajEzMy3j6wzWHVaG4A@mail.gmail.com>
On Fri, 2013-07-05 at 16:49 -0600, Bjorn Helgaas wrote:
> I know we have paths where we save config space, do a reset, and
> restore config space. I don't like those because some quirks aren't
> applied and I don't believe restoring config space is sufficient to
> make the device safe to use. There could be internal state that we
> aren't restoring. It's also possible that a firmware update means the
> device is different than it was before the reset, e.g., BARs could be
> different types or sizes.
True. Ok, I'll stick to the actual hotplug path then, you make
good points.
Cheers,
Ben.
next prev parent reply other threads:[~2013-07-05 23:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 2:57 [PATCH v1 0/8] EEH Followup Fixes (II) Gavin Shan
2013-07-05 2:57 ` [PATCH 1/8] PCI: Add pcibios_stop_dev() Gavin Shan
2013-07-05 2:57 ` Gavin Shan
2013-07-05 3:08 ` Benjamin Herrenschmidt
2013-07-05 3:08 ` Benjamin Herrenschmidt
2013-07-05 18:49 ` Bjorn Helgaas
2013-07-05 18:49 ` Bjorn Helgaas
2013-07-05 22:36 ` Benjamin Herrenschmidt
2013-07-05 22:36 ` Benjamin Herrenschmidt
2013-07-05 22:49 ` Bjorn Helgaas
2013-07-05 22:49 ` Bjorn Helgaas
2013-07-05 23:05 ` Benjamin Herrenschmidt [this message]
2013-07-05 23:05 ` Benjamin Herrenschmidt
2013-07-05 2:57 ` [PATCH 2/8] powerpc/eeh: Export functions for hotplug Gavin Shan
2013-07-05 2:57 ` [PATCH 3/8] powerpc/pci: Override pcibios_stop_dev() Gavin Shan
2013-07-05 2:57 ` [PATCH 4/8] PCI/hotplug: Needn't remove EEH cache again Gavin Shan
2013-07-05 2:57 ` Gavin Shan
2013-07-05 18:51 ` Bjorn Helgaas
2013-07-05 18:51 ` Bjorn Helgaas
2013-07-05 2:57 ` [PATCH 5/8] powerpc/eeh: Keep PE during hotplug Gavin Shan
2013-07-05 2:57 ` [PATCH 6/8] powerpc/eeh: Tranverse EEH devices with safe mode Gavin Shan
2013-07-05 2:57 ` [PATCH 7/8] powerpc/pci: Partial hotplug support Gavin Shan
2013-07-05 2:57 ` [PATCH 8/8] powerpc/eeh: Support partial hotplug Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373065511.4446.11.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.