[meta-oe][PATCH] samba: remove /var/run from package

[meta-oe][PATCH] samba: remove /var/run from package

[Jonathan Liu]

The /var/run and /var/run/lock directories are already created by
base-files.

Signed-off-by: Jonathan Liu <net147@gmail.com>
---
 meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
index a27a28c..6bd6644 100644
--- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
+++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
@@ -57,3 +57,8 @@ do_configure() {
 do_compile () {
     base_do_compile
 }
+
+do_install_append() {
+    rm -rf "${D}${localstatedir}/run"
+    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
-- 
1.8.3.2

Re: [meta-oe][PATCH] samba: remove /var/run from package

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Sat, Jul 06, 2013 at 10:03:45PM +1000, Jonathan Liu wrote:
> The /var/run and /var/run/lock directories are already created by
> base-files.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> index a27a28c..6bd6644 100644
> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> @@ -57,3 +57,8 @@ do_configure() {
>  do_compile () {
>      base_do_compile
>  }
> +
> +do_install_append() {
> +    rm -rf "${D}${localstatedir}/run"

Seems like lock removal is missing here.

samba-3.6.8: samba: Files/directories were installed but not shipped
  /run
  /run/lock

Thanks a lot for this patchset, now with libdir and infodir QA checks
we'll see a lot more QA issues in world builds, so it's great to have
this /run gone.


> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
> +}
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-oe][PATCH] samba: remove /var/run from package

[Jonathan Liu]

On 8 July 2013 02:20, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sat, Jul 06, 2013 at 10:03:45PM +1000, Jonathan Liu wrote:
>> The /var/run and /var/run/lock directories are already created by
>> base-files.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>>  meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> index a27a28c..6bd6644 100644
>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> @@ -57,3 +57,8 @@ do_configure() {
>>  do_compile () {
>>      base_do_compile
>>  }
>> +
>> +do_install_append() {
>> +    rm -rf "${D}${localstatedir}/run"
>
> Seems like lock removal is missing here.
>
> samba-3.6.8: samba: Files/directories were installed but not shipped
>   /run
>   /run/lock
>
> Thanks a lot for this patchset, now with libdir and infodir QA checks
> we'll see a lot more QA issues in world builds, so it's great to have
> this /run gone.
>
I have submitted V2 patch for samba. I haven't got around to fixing
nostromo yet.

Regards,
Jonathan

>
>> +    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>> +}
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>