diff for duplicates of <1373552117.8183.243@snotra> diff --git a/a/1.txt b/N1/1.txt index 76ea81e..5d8394d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,17 @@ On 07/11/2013 03:43:35 AM, David Laight wrote: > > > +#define IS_SVR_REV(svr, maj, min) \ -> > > + ((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min))) +> > > + ((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min))) > > > > I don't think IS_SVR_REV is needed. Callers can just do "if -> > (SVR_REV(svr) == 0x30)" or whatever, especially since we're relying +> > (SVR_REV(svr) =3D=3D 0x30)" or whatever, especially since we're relying= + =20 > on > > them to do this for greater/less than comparisons. -> +>=20 > Not only that, I'd guess that 'maj' and 'min' are likely to be > constants - so you'd want to combine them and compare against 'svr' > rather than have two conditionals. Yes, that's what I meant -- 0x30 would represent revision 3.0. --Scott +-Scott= diff --git a/a/content_digest b/N1/content_digest index 72e7287..21fe0a0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,32 +5,33 @@ "Subject\0Re: [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection\0" "Date\0Thu, 11 Jul 2013 09:15:17 -0500\0" "To\0David Laight <David.Laight@aculab.com>\0" - "Cc\0Haijun Zhang <Haijun.Zhang@freescale.com>" - Zhao Chenhui <chenhui.zhao@freescale.com> + "Cc\0Zhao Chenhui <chenhui.zhao@freescale.com>" linux-mmc@vger.kernel.org r39252@freescale.com - AFLEMING@freescale.comhaijun Zhang <Haijun.Zhang@freescale.com> + AFLEMING@freescale.com + X.Xie@freescale.com cbouatmailru@gmail.com cjb@laptop.org linuxppc-dev@lists.ozlabs.org - " X.Xie@freescale.com\0" + " Haijun Zhang <Haijun.Zhang@freescale.com>\0" "\00:1\0" "b\0" "On 07/11/2013 03:43:35 AM, David Laight wrote:\n" "> > > +#define IS_SVR_REV(svr, maj, min) \\\n" - "> > > +\t((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min)))\n" + "> > > +\t((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min)))\n" "> >\n" "> > I don't think IS_SVR_REV is needed. Callers can just do \"if\n" - "> > (SVR_REV(svr) == 0x30)\" or whatever, especially since we're relying \n" + "> > (SVR_REV(svr) =3D=3D 0x30)\" or whatever, especially since we're relying=\n" + " =20\n" "> on\n" "> > them to do this for greater/less than comparisons.\n" - "> \n" + ">=20\n" "> Not only that, I'd guess that 'maj' and 'min' are likely to be\n" "> constants - so you'd want to combine them and compare against 'svr'\n" "> rather than have two conditionals.\n" "\n" "Yes, that's what I meant -- 0x30 would represent revision 3.0.\n" "\n" - -Scott + -Scott= -5323eece5bfbe5c01b09e4c6b3572bd8058285d9b57e5be1081e15062d509969 +421eca3d4e2f77650aaf54fae9b25e6d7c8d23f5fabcfa098599389944f1c07a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.