From: Scott Wood <scottwood@freescale.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Haijun Zhang <Haijun.Zhang@freescale.com>,
Zhao Chenhui <chenhui.zhao@freescale.com>,
linux-mmc@vger.kernel.org, r39252@freescale.com,
AFLEMING@freescale.comHaijun Zhang <Haijun.Zhang@freescale.com>,
cbouatmailru@gmail.com, cjb@laptop.org,
linuxppc-dev@lists.ozlabs.org, X.Xie@freescale.com
Subject: Re: [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection
Date: Thu, 11 Jul 2013 09:15:17 -0500 [thread overview]
Message-ID: <1373552117.8183.243@snotra> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B72DE@saturn3.aculab.com> (from David.Laight@ACULAB.COM on Thu Jul 11 03:43:35 2013)
On 07/11/2013 03:43:35 AM, David Laight wrote:
> > > +#define IS_SVR_REV(svr, maj, min) \
> > > + ((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min)))
> >
> > I don't think IS_SVR_REV is needed. Callers can just do "if
> > (SVR_REV(svr) == 0x30)" or whatever, especially since we're relying
> on
> > them to do this for greater/less than comparisons.
>
> Not only that, I'd guess that 'maj' and 'min' are likely to be
> constants - so you'd want to combine them and compare against 'svr'
> rather than have two conditionals.
Yes, that's what I meant -- 0x30 would represent revision 3.0.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Zhao Chenhui <chenhui.zhao@freescale.com>,
linux-mmc@vger.kernel.org, r39252@freescale.com,
AFLEMING@freescale.com, X.Xie@freescale.com,
cbouatmailru@gmail.com, cjb@laptop.org,
linuxppc-dev@lists.ozlabs.org,
Haijun Zhang <Haijun.Zhang@freescale.com>
Subject: Re: [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection
Date: Thu, 11 Jul 2013 09:15:17 -0500 [thread overview]
Message-ID: <1373552117.8183.243@snotra> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B72DE@saturn3.aculab.com> (from David.Laight@ACULAB.COM on Thu Jul 11 03:43:35 2013)
On 07/11/2013 03:43:35 AM, David Laight wrote:
> > > +#define IS_SVR_REV(svr, maj, min) \
> > > + ((SVR_MAJ(svr) =3D=3D (maj)) && (SVR_MIN(svr) =3D=3D (min)))
> >
> > I don't think IS_SVR_REV is needed. Callers can just do "if
> > (SVR_REV(svr) =3D=3D 0x30)" or whatever, especially since we're relying=
=20
> on
> > them to do this for greater/less than comparisons.
>=20
> Not only that, I'd guess that 'maj' and 'min' are likely to be
> constants - so you'd want to combine them and compare against 'svr'
> rather than have two conditionals.
Yes, that's what I meant -- 0x30 would represent revision 3.0.
-Scott=
next prev parent reply other threads:[~2013-07-11 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 7:39 [PATCH 1/4 V2] powerpc/85xx: Add support for 85xx cpu type detection Haijun Zhang
2013-07-10 7:39 ` Haijun Zhang
2013-07-10 21:48 ` Scott Wood
2013-07-10 21:48 ` Scott Wood
2013-07-11 8:43 ` David Laight
2013-07-11 8:43 ` David Laight
2013-07-11 9:02 ` Zhang Haijun-B42677
2013-07-11 9:02 ` Zhang Haijun-B42677
2013-07-11 14:15 ` Scott Wood [this message]
2013-07-11 14:15 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373552117.8183.243@snotra \
--to=scottwood@freescale.com \
--cc=AFLEMING@freescale.comHaijun \
--cc=David.Laight@ACULAB.COM \
--cc=Haijun.Zhang@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=r39252@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.