All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 3/7] inetpeer: use generic union inet_addr
Date: Tue, 23 Jul 2013 10:05:31 +0800	[thread overview]
Message-ID: <1374545131.24933.4.camel@cr0> (raw)
In-Reply-To: <1374506315.4990.14.camel@edumazet-glaptop>

On Mon, 2013-07-22 at 08:18 -0700, Eric Dumazet wrote:
> On Mon, 2013-07-22 at 15:05 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> > 
> > struct inetpeer_addr is pretty similar to generic union inet_addr,
> > therefore can be safely converted to it.
> 
> Its 'safe' but adds 50% increase for struct tcp_metrics_block
> 
> I fail to see this mentioned in the changelog.

I asked you in RFC, but you don't give me any response, this is the
reason. :)

> I guess its no big deal, but why do you think this code used hand coded
> functions instead of generic ?
> 
> 
> 

I don't understand what you are asking here, seems totally unrelated
with the point you raised above, therefore I am completely confused...

Thanks.

  reply	other threads:[~2013-07-23  2:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  7:05 [Patch net-next 0/7] net: introduce generic type and helpers for IP address Cong Wang
2013-07-22  7:05 ` [Patch net-next 1/7] net: introduce generic union inet_addr Cong Wang
2013-07-22  7:05 ` [Patch net-next 2/7] net: introduce generic simple_inet_pton() Cong Wang
2013-07-22  7:05 ` [Patch net-next 3/7] inetpeer: use generic union inet_addr Cong Wang
2013-07-22 15:18   ` Eric Dumazet
2013-07-23  2:05     ` Cong Wang [this message]
2013-07-23  2:26       ` Eric Dumazet
2013-07-23  3:38         ` Cong Wang
2013-07-22  7:05 ` [Patch net-next 4/7] sunrpc: " Cong Wang
2013-07-23 16:40   ` J. Bruce Fields
2013-07-23 16:40     ` J. Bruce Fields
2013-07-25 12:34     ` Cong Wang
2013-07-25 12:34       ` Cong Wang
2013-07-25 12:54       ` J. Bruce Fields
2013-07-22  7:05 ` [Cluster-devel] [Patch net-next 5/7] fs: use generic union inet_addr and help functions Cong Wang
2013-07-22  7:05   ` Cong Wang
2013-07-22  7:05 ` [Patch net-next 6/7] sctp: use generic union inet_addr Cong Wang
2013-07-22  7:05 ` [Patch net-next 7/7] selinux: " Cong Wang
2013-07-22 20:36   ` Paul Moore
2013-07-23  2:07     ` Cong Wang
2013-07-22 20:44 ` [Patch net-next 0/7] net: introduce generic type and helpers for IP address Joe Perches
2013-07-23  2:00   ` Cong Wang
2013-07-23  2:16     ` Joe Perches
2013-07-23  2:26       ` Cong Wang
2013-07-24 21:28 ` David Miller
2013-07-25 12:30   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374545131.24933.4.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.