From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 3/7] inetpeer: use generic union inet_addr
Date: Tue, 23 Jul 2013 11:38:15 +0800 [thread overview]
Message-ID: <1374550695.24933.19.camel@cr0> (raw)
In-Reply-To: <1374546371.4990.113.camel@edumazet-glaptop>
On Mon, 2013-07-22 at 19:26 -0700, Eric Dumazet wrote:
> You are sending a patch with possible performance impact, and you only
> says "its safe", without any real study. It might have an impact, who
> knows.
>
> I said "its no big deal", so consider this as an informative message.
Yeah.
So changing from struct inetpeer_addr to union inet_addr just adds few
bytes (8 bytes if I don't make mistake) to struct tcp_metrics_block,
therefore should not cause performance issue on 32bit and 64bit?
BTW, I tried to use pahole to get the offsets of these fields, but it
doesn't work for me.
Thanks!
next prev parent reply other threads:[~2013-07-23 3:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 7:05 [Patch net-next 0/7] net: introduce generic type and helpers for IP address Cong Wang
2013-07-22 7:05 ` [Patch net-next 1/7] net: introduce generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 2/7] net: introduce generic simple_inet_pton() Cong Wang
2013-07-22 7:05 ` [Patch net-next 3/7] inetpeer: use generic union inet_addr Cong Wang
2013-07-22 15:18 ` Eric Dumazet
2013-07-23 2:05 ` Cong Wang
2013-07-23 2:26 ` Eric Dumazet
2013-07-23 3:38 ` Cong Wang [this message]
2013-07-22 7:05 ` [Patch net-next 4/7] sunrpc: " Cong Wang
2013-07-23 16:40 ` J. Bruce Fields
2013-07-23 16:40 ` J. Bruce Fields
2013-07-25 12:34 ` Cong Wang
2013-07-25 12:34 ` Cong Wang
2013-07-25 12:54 ` J. Bruce Fields
2013-07-22 7:05 ` [Cluster-devel] [Patch net-next 5/7] fs: use generic union inet_addr and help functions Cong Wang
2013-07-22 7:05 ` Cong Wang
2013-07-22 7:05 ` [Patch net-next 6/7] sctp: use generic union inet_addr Cong Wang
2013-07-22 7:05 ` [Patch net-next 7/7] selinux: " Cong Wang
2013-07-22 20:36 ` Paul Moore
2013-07-23 2:07 ` Cong Wang
2013-07-22 20:44 ` [Patch net-next 0/7] net: introduce generic type and helpers for IP address Joe Perches
2013-07-23 2:00 ` Cong Wang
2013-07-23 2:16 ` Joe Perches
2013-07-23 2:26 ` Cong Wang
2013-07-24 21:28 ` David Miller
2013-07-25 12:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374550695.24933.19.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.