From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: chenhui.zhao@freescale.com, "paulus@samba.org" <paulus@samba.org>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2] powerpc: kernel: remove useless code which related with 'max_cpus'
Date: Thu, 25 Jul 2013 17:33:12 +1000 [thread overview]
Message-ID: <1374737592.6142.67.camel@pasglop> (raw)
In-Reply-To: <51F0C2E8.3050005@asianux.com>
On Thu, 2013-07-25 at 14:17 +0800, Chen Gang wrote:
>
> Hmm... for an extern function (espeically have been implemented in
> various modules), normally, we can assume it may fail in some cases
> (although now, we don't know what cases can cause its failure).
>
> If "we don't have a good way to handle the failure", "print the related
> warning message" is an executable choice (or "BUG_ON()", if it is critical).
>
> So, if the performance is not sensible, I still suggest to let extern
> function have return value.
This is not a module function. We are not doing a uni course on how to
write C code here. Be real.
Ben.
next prev parent reply other threads:[~2013-07-25 7:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 5:58 [PATCH] powerpc: kernel: remove useless code which related with 'max_cpus' Chen Gang
2013-07-22 6:18 ` Srivatsa S. Bhat
2013-07-22 6:27 ` Chen Gang
2013-07-22 6:40 ` [PATCH v2] " Chen Gang
2013-07-22 6:51 ` Srivatsa S. Bhat
2013-07-22 7:03 ` Chen Gang
2013-07-23 13:44 ` Michael Ellerman
2013-07-24 0:28 ` Chen Gang
2013-07-24 1:16 ` Michael Ellerman
2013-07-24 2:09 ` Chen Gang
2013-07-25 3:15 ` Michael Ellerman
2013-07-25 4:02 ` Chen Gang
2013-07-25 5:16 ` Benjamin Herrenschmidt
2013-07-25 5:24 ` Chen Gang
2013-07-25 5:51 ` Benjamin Herrenschmidt
2013-07-25 6:03 ` Benjamin Herrenschmidt
2013-07-25 6:30 ` Chen Gang
2013-07-25 6:17 ` Chen Gang
2013-07-25 7:33 ` Benjamin Herrenschmidt [this message]
2013-07-25 7:59 ` Chen Gang
2013-07-25 8:06 ` Benjamin Herrenschmidt
2013-07-25 8:22 ` Chen Gang
2013-07-25 8:28 ` Benjamin Herrenschmidt
2013-07-25 8:36 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374737592.6142.67.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=chenhui.zhao@freescale.com \
--cc=gang.chen@asianux.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.