From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data
Date: Mon, 29 Jul 2013 22:02:58 +0300 [thread overview]
Message-ID: <1375124578.5444.2.camel@localhost> (raw)
In-Reply-To: <20130729122344.GH24801@radagast>
Hi,
> > Cc: Bryan Huntsman <bryanh@codeaurora.org>
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > Cc: linux-usb at vger.kernel.org
> >
> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > ---
> > arch/arm/mach-msm/board-msm7x30.c | 35 +++++++++++++++++++++++
> > arch/arm/mach-msm/board-qsd8x50.c | 35 +++++++++++++++++++++++
>
> I need acks for these.
>
> > drivers/usb/phy/phy-msm-usb.c | 55 ++++++++++---------------------------
> > include/linux/usb/msm_hsusb.h | 3 ++
> > 4 files changed, 87 insertions(+), 41 deletions(-)
> >
> > diff --git a/arch/arm/mach-msm/board-msm7x30.c b/arch/arm/mach-msm/board-msm7x30.c
> > index db3d8c0..6b35953 100644
> > --- a/arch/arm/mach-msm/board-msm7x30.c
> > +++ b/arch/arm/mach-msm/board-msm7x30.c
> > @@ -31,6 +31,7 @@
> > #include <asm/setup.h>
> >
> > #include <mach/board.h>
> > +#include <mach/clk.h>
> > #include <mach/msm_iomap.h>
> > #include <mach/dma.h>
> >
> > @@ -61,10 +62,44 @@ static int hsusb_phy_init_seq[] = {
> > -1
> > };
> >
> > +static int hsusb_link_clk_reset(struct clk *link_clk, bool assert)
>
> looks like you should be using the reset controller framework ?
> (drivers/reset)
Probably, but there still nothing in place in the msm,
which provide this functionality. I am looking it to
right now.
Regards,
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: balbi@ti.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data
Date: Mon, 29 Jul 2013 22:02:58 +0300 [thread overview]
Message-ID: <1375124578.5444.2.camel@localhost> (raw)
In-Reply-To: <20130729122344.GH24801@radagast>
Hi,
> > Cc: Bryan Huntsman <bryanh@codeaurora.org>
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-usb@vger.kernel.org
> >
> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > ---
> > arch/arm/mach-msm/board-msm7x30.c | 35 +++++++++++++++++++++++
> > arch/arm/mach-msm/board-qsd8x50.c | 35 +++++++++++++++++++++++
>
> I need acks for these.
>
> > drivers/usb/phy/phy-msm-usb.c | 55 ++++++++++---------------------------
> > include/linux/usb/msm_hsusb.h | 3 ++
> > 4 files changed, 87 insertions(+), 41 deletions(-)
> >
> > diff --git a/arch/arm/mach-msm/board-msm7x30.c b/arch/arm/mach-msm/board-msm7x30.c
> > index db3d8c0..6b35953 100644
> > --- a/arch/arm/mach-msm/board-msm7x30.c
> > +++ b/arch/arm/mach-msm/board-msm7x30.c
> > @@ -31,6 +31,7 @@
> > #include <asm/setup.h>
> >
> > #include <mach/board.h>
> > +#include <mach/clk.h>
> > #include <mach/msm_iomap.h>
> > #include <mach/dma.h>
> >
> > @@ -61,10 +62,44 @@ static int hsusb_phy_init_seq[] = {
> > -1
> > };
> >
> > +static int hsusb_link_clk_reset(struct clk *link_clk, bool assert)
>
> looks like you should be using the reset controller framework ?
> (drivers/reset)
Probably, but there still nothing in place in the msm,
which provide this functionality. I am looking it to
right now.
Regards,
Ivan
next prev parent reply other threads:[~2013-07-29 19:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:04 [PATCH v2 0/6] usb: phy: msm: Fixes and cleanups Ivan T. Ivanov
2013-07-29 7:04 ` [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data Ivan T. Ivanov
2013-07-29 7:04 ` Ivan T. Ivanov
2013-07-29 12:23 ` Felipe Balbi
2013-07-29 12:23 ` Felipe Balbi
2013-07-29 19:02 ` Ivan T. Ivanov [this message]
2013-07-29 19:02 ` Ivan T. Ivanov
2013-07-29 17:43 ` David Brown
2013-07-29 17:43 ` David Brown
2013-07-29 7:04 ` [PATCH v2 2/6] usb: phy: msm: move global regulators variables to driver state Ivan T. Ivanov
2013-07-29 7:04 ` [PATCH v2 3/6] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2013-07-29 12:25 ` Felipe Balbi
2013-08-12 8:52 ` Ivan T. Ivanov
2013-07-29 7:04 ` [PATCH v2 4/6] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2013-07-29 7:04 ` [PATCH v2 5/6] usb: phy: msm: Fix WARNING: quoted string split across lines Ivan T. Ivanov
2013-07-29 7:04 ` [PATCH v2 6/6] usb: phy: msm: Fix WARNING: Prefer seq_puts to seq_printf Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375124578.5444.2.camel@localhost \
--to=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.