* [PATCH] regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call
@ 2013-08-03 9:10 Axel Lin
2013-08-13 10:18 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-08-03 9:10 UTC (permalink / raw)
To: Mark Brown
Cc: Yadwinder Singh Brar, Sangbeom Kim, Liam Girdwood, linux-kernel
Current code calls regmap_update_bits() with mask and val arguments swapped.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/s2mps11.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index f047d36..89140ae 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -207,8 +207,8 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
ramp_val << ramp_shift, 1 << ramp_shift);
ramp_disable:
- return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, 0,
- 1 << enable_shift);
+ return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
+ 1 << enable_shift, 0);
}
static struct regulator_ops s2mps11_ldo_ops = {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call
2013-08-03 9:10 [PATCH] regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call Axel Lin
@ 2013-08-13 10:18 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-08-13 10:18 UTC (permalink / raw)
To: Axel Lin; +Cc: Yadwinder Singh Brar, Sangbeom Kim, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
On Sat, Aug 03, 2013 at 05:10:42PM +0800, Axel Lin wrote:
> Current code calls regmap_update_bits() with mask and val arguments swapped.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-13 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-03 9:10 [PATCH] regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call Axel Lin
2013-08-13 10:18 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.