All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linaro-kernel@lists.linaro.org,
	linux-omap@vger.kernel.org, Andy Green <andy.green@linaro.org>,
	Mark Brown <broonie@linaro.org>
Subject: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used
Date: Tue,  6 Aug 2013 16:49:26 +0100	[thread overview]
Message-ID: <1375804166-3205-1-git-send-email-broonie@kernel.org> (raw)

From: Andy Green <andy.green@linaro.org>

You might have CONFIG_PM, but you might not have CONFIG_SUSPEND, in which
case these are unused.

Signed-off-by: Andy Green <andy.green@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/usb/dwc3/dwc3-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 5d746e5..4902021 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -191,7 +191,7 @@ static DEFINE_PCI_DEVICE_TABLE(dwc3_pci_id_table) = {
 };
 MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_SUSPEND
 static int dwc3_pci_suspend(struct device *dev)
 {
 	struct pci_dev	*pci = to_pci_dev(dev);
-- 
1.8.4.rc1


             reply	other threads:[~2013-08-06 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 15:49 Mark Brown [this message]
2013-08-07  1:35 ` [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used Fabio Estevam
2013-08-07  9:34   ` Mark Brown
2013-08-07 10:01     ` Andy Green
2013-08-09 13:26       ` Felipe Balbi
2013-08-09 14:58         ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375804166-3205-1-git-send-email-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=andy.green@linaro.org \
    --cc=balbi@ti.com \
    --cc=broonie@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.