From: Felipe Balbi <balbi@ti.com>
To: Andy Green <andy.green@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
linaro-kernel <linaro-kernel@lists.linaro.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used
Date: Fri, 9 Aug 2013 16:26:15 +0300 [thread overview]
Message-ID: <20130809132615.GE12041@radagast> (raw)
In-Reply-To: <CAAfg0W5fWdvX7aU8y29op70SFod=xqrr9kpxUUi=NKy71Y89Wg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Wed, Aug 07, 2013 at 06:01:00PM +0800, Andy Green wrote:
> On 7 August 2013 17:34, Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Aug 06, 2013 at 10:35:52PM -0300, Fabio Estevam wrote:
> >> On Tue, Aug 6, 2013 at 12:49 PM, Mark Brown <broonie@kernel.org> wrote:
> >> > From: Andy Green <andy.green@linaro.org>
> >> >
> >> > You might have CONFIG_PM, but you might not have CONFIG_SUSPEND, in which
> >> > case these are unused.
> >> >
> >> > Signed-off-by: Andy Green <andy.green@linaro.org>
> >> > Signed-off-by: Mark Brown <broonie@linaro.org>
> >
> >> What about doing this instead?
> >
> > Makes sense to me - Andy?
>
> Sure, it seems a much more complete solution.
looks good to me too, please send it as a real patch (if you already
have, sorry about that, catching up with my inbox now).
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-09 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 15:49 [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used Mark Brown
2013-08-07 1:35 ` Fabio Estevam
2013-08-07 9:34 ` Mark Brown
2013-08-07 10:01 ` Andy Green
2013-08-09 13:26 ` Felipe Balbi [this message]
2013-08-09 14:58 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809132615.GE12041@radagast \
--to=balbi@ti.com \
--cc=andy.green@linaro.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.