From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Maen Suleiman <maen@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCHv8 04/10] of: pci: add registry of MSI chips
Date: Fri, 09 Aug 2013 15:49:06 +1000 [thread overview]
Message-ID: <1376027346.32100.8.camel@pasglop> (raw)
In-Reply-To: <1376000268-18397-5-git-send-email-thomas.petazzoni@free-electrons.com>
On Fri, 2013-08-09 at 00:17 +0200, Thomas Petazzoni wrote:
>
> +#if defined(CONFIG_OF) && defined(CONFIG_PCI_MSI)
> +int of_pci_msi_chip_add(struct msi_chip *chip);
> +void of_pci_msi_chip_remove(struct msi_chip *chip);
> +struct msi_chip *of_pci_find_msi_chip_by_node(struct device_node
> *of_node);
> +#else
> +static inline int of_pci_msi_chip_add(struct msi_chip *chip) { return
> -EINVAL; }
> +static inline void of_pci_msi_chip_remove(struct msi_chip *chip) { }
Missing a ; at the end of the above line... breaks the build of
CONFIG_PCI_MSI is not set.
> +static inline struct msi_chip *
> +of_pci_find_msi_chip_by_node(struct device_node *of_node) { return
> NULL };
> +#endif
> +
> #endif
WARNING: multiple messages have this Message-ID (diff)
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv8 04/10] of: pci: add registry of MSI chips
Date: Fri, 09 Aug 2013 15:49:06 +1000 [thread overview]
Message-ID: <1376027346.32100.8.camel@pasglop> (raw)
In-Reply-To: <1376000268-18397-5-git-send-email-thomas.petazzoni@free-electrons.com>
On Fri, 2013-08-09 at 00:17 +0200, Thomas Petazzoni wrote:
>
> +#if defined(CONFIG_OF) && defined(CONFIG_PCI_MSI)
> +int of_pci_msi_chip_add(struct msi_chip *chip);
> +void of_pci_msi_chip_remove(struct msi_chip *chip);
> +struct msi_chip *of_pci_find_msi_chip_by_node(struct device_node
> *of_node);
> +#else
> +static inline int of_pci_msi_chip_add(struct msi_chip *chip) { return
> -EINVAL; }
> +static inline void of_pci_msi_chip_remove(struct msi_chip *chip) { }
Missing a ; at the end of the above line... breaks the build of
CONFIG_PCI_MSI is not set.
> +static inline struct msi_chip *
> +of_pci_find_msi_chip_by_node(struct device_node *of_node) { return
> NULL };
> +#endif
> +
> #endif
next prev parent reply other threads:[~2013-08-09 5:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 22:17 [PATCHv8 00/10] MSI support for Marvell EBU PCIe driver Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` [PATCHv8 01/10] PCI: use weak functions for MSI arch-specific functions Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:17 ` [PATCHv8 02/10] PCI: remove ARCH_SUPPORTS_MSI kconfig option Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:39 ` Benjamin Herrenschmidt
2013-08-08 22:17 ` [PATCHv8 03/10] PCI: Introduce new MSI chip infrastructure Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` [PATCHv8 04/10] of: pci: add registry of MSI chips Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-09 5:49 ` Benjamin Herrenschmidt [this message]
2013-08-09 5:49 ` Benjamin Herrenschmidt
2013-08-09 11:42 ` Jason Cooper
2013-08-09 11:42 ` Jason Cooper
2013-08-09 13:44 ` Jason Cooper
2013-08-09 13:44 ` Jason Cooper
2013-08-09 14:18 ` Thierry Reding
2013-08-09 14:18 ` Thierry Reding
2013-08-09 14:27 ` Jason Cooper
2013-08-09 14:27 ` Jason Cooper
2013-08-09 21:54 ` Benjamin Herrenschmidt
2013-08-09 21:54 ` Benjamin Herrenschmidt
2013-08-09 5:59 ` Benjamin Herrenschmidt
2013-08-09 5:59 ` Benjamin Herrenschmidt
2013-08-08 22:17 ` [PATCHv8 05/10] irqchip: armada-370-xp: properly request resources Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-09 6:44 ` Gregory CLEMENT
2013-08-09 6:44 ` Gregory CLEMENT
2013-08-08 22:17 ` [PATCHv8 06/10] irqchip: armada-370-xp: implement MSI support Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-09 5:56 ` Benjamin Herrenschmidt
2013-08-09 5:56 ` Benjamin Herrenschmidt
2013-08-09 6:44 ` Gregory CLEMENT
2013-08-09 6:44 ` Gregory CLEMENT
2013-08-08 22:17 ` [PATCHv8 07/10] ARM: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` [PATCHv8 08/10] ARM: mvebu: the MPIC now provides MSI controller features Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-09 6:45 ` Gregory CLEMENT
2013-08-09 6:45 ` Gregory CLEMENT
2013-08-08 22:17 ` [PATCHv8 09/10] PCI: mvebu: add support for MSI Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-08 22:17 ` [PATCHv8 10/10] ARM: mvebu: link PCIe controllers to the MSI controller Thomas Petazzoni
2013-08-08 22:17 ` Thomas Petazzoni
2013-08-09 6:45 ` Gregory CLEMENT
2013-08-09 6:45 ` Gregory CLEMENT
2013-08-09 5:58 ` [PATCHv8 00/10] MSI support for Marvell EBU PCIe driver Benjamin Herrenschmidt
2013-08-09 5:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376027346.32100.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.