* [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS
@ 2013-08-09 16:25 Axel Lin
2013-08-09 16:41 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2013-08-09 16:25 UTC (permalink / raw)
To: Mark Brown; +Cc: Steve Twiss, Liam Girdwood, linux-kernel
The modalias is set by the MODULE_DEVICE_TABLE, thus remove redundant
MODULE_ALIAS. Also Fix trivial typo for the author name.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/da9210-regulator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/da9210-regulator.c b/drivers/regulator/da9210-regulator.c
index bf492bc..1597bf8 100644
--- a/drivers/regulator/da9210-regulator.c
+++ b/drivers/regulator/da9210-regulator.c
@@ -191,7 +191,6 @@ static struct i2c_driver da9210_regulator_driver = {
module_i2c_driver(da9210_regulator_driver);
-MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
+MODULE_AUTHOR("Steve Twiss <stwiss.opensource@diasemi.com>");
MODULE_DESCRIPTION("Regulator device driver for Dialog DA9210");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("i2c:da9210");
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS
2013-08-09 16:25 [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS Axel Lin
@ 2013-08-09 16:41 ` Mark Brown
2013-08-10 2:13 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-08-09 16:41 UTC (permalink / raw)
To: Axel Lin; +Cc: Steve Twiss, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
On Sat, Aug 10, 2013 at 12:25:58AM +0800, Axel Lin wrote:
> -MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
> +MODULE_AUTHOR("Steve Twiss <stwiss.opensource@diasemi.com>");
It's perfectly reasonable for someone to want to be referred to by their
initial, or their full spelled out name, or a nickname, or...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS
2013-08-09 16:41 ` Mark Brown
@ 2013-08-10 2:13 ` Axel Lin
2013-08-11 14:42 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2013-08-10 2:13 UTC (permalink / raw)
To: Mark Brown; +Cc: Steve Twiss, Liam Girdwood, linux-kernel@vger.kernel.org
2013/8/10 Mark Brown <broonie@kernel.org>:
> On Sat, Aug 10, 2013 at 12:25:58AM +0800, Axel Lin wrote:
>
>> -MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
>> +MODULE_AUTHOR("Steve Twiss <stwiss.opensource@diasemi.com>");
>
> It's perfectly reasonable for someone to want to be referred to by their
> initial, or their full spelled out name, or a nickname, or...
Oh, I didn't realize that naming could be intentional....
If Steve does not confirm this fix is good, I'll send a v2.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS
2013-08-10 2:13 ` Axel Lin
@ 2013-08-11 14:42 ` Mark Brown
2013-08-11 15:04 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-08-11 14:42 UTC (permalink / raw)
To: Axel Lin; +Cc: Steve Twiss, Liam Girdwood, linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On Sat, Aug 10, 2013 at 10:13:23AM +0800, Axel Lin wrote:
> 2013/8/10 Mark Brown <broonie@kernel.org>:
> > On Sat, Aug 10, 2013 at 12:25:58AM +0800, Axel Lin wrote:
> >> -MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
> >> +MODULE_AUTHOR("Steve Twiss <stwiss.opensource@diasemi.com>");
> > It's perfectly reasonable for someone to want to be referred to by their
> > initial, or their full spelled out name, or a nickname, or...
> Oh, I didn't realize that naming could be intentional....
> If Steve does not confirm this fix is good, I'll send a v2.
Think JK Rowling or CS Lewis :)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS
2013-08-11 14:42 ` Mark Brown
@ 2013-08-11 15:04 ` Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2013-08-11 15:04 UTC (permalink / raw)
To: Mark Brown; +Cc: Steve Twiss, Liam Girdwood, linux-kernel@vger.kernel.org
2013/8/11 Mark Brown <broonie@kernel.org>:
> On Sat, Aug 10, 2013 at 10:13:23AM +0800, Axel Lin wrote:
>> 2013/8/10 Mark Brown <broonie@kernel.org>:
>> > On Sat, Aug 10, 2013 at 12:25:58AM +0800, Axel Lin wrote:
>
>> >> -MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
>> >> +MODULE_AUTHOR("Steve Twiss <stwiss.opensource@diasemi.com>");
>
>> > It's perfectly reasonable for someone to want to be referred to by their
>> > initial, or their full spelled out name, or a nickname, or...
>
>> Oh, I didn't realize that naming could be intentional....
>> If Steve does not confirm this fix is good, I'll send a v2.
>
> Think JK Rowling or CS Lewis :)
Haha, Probably just because I speak Mandarin and I don't really understand the
English naming rule. I'm sending v2 right now.
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-11 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 16:25 [PATCH] regulator: da9210: Remove redundant MODULE_ALIAS Axel Lin
2013-08-09 16:41 ` Mark Brown
2013-08-10 2:13 ` Axel Lin
2013-08-11 14:42 ` Mark Brown
2013-08-11 15:04 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.