[PATCH] busybox: enable eject

[PATCH] busybox: enable eject

[Andreas Müller]

In xfce-environment ejecting USB-memory stick caused:
Error starting job: Failed to execute child process "eject" (No such file or directory)

size of armv7a busybox binary increases from 2427962 to 2430389 bytes

run-tested with angstrom/meta-oe environment on overo

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.3.bb        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
index 372d7b5..279933b 100644
--- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
@@ -669,7 +669,7 @@ CONFIG_DC=y
 # CONFIG_DEVFSD_VERBOSE is not set
 # CONFIG_FEATURE_DEVFS is not set
 # CONFIG_DEVMEM is not set
-# CONFIG_EJECT is not set
+CONFIG_EJECT=y
 # CONFIG_FEATURE_EJECT_SCSI is not set
 # CONFIG_FBSPLASH is not set
 # CONFIG_FLASHCP is not set
diff --git a/meta/recipes-core/busybox/busybox_1.19.3.bb b/meta/recipes-core/busybox/busybox_1.19.3.bb
index 49ac859..728b74e 100644
--- a/meta/recipes-core/busybox/busybox_1.19.3.bb
+++ b/meta/recipes-core/busybox/busybox_1.19.3.bb
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r5"
+PR = "r6"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
-- 
1.7.6.5

[PATCH] busybox: enable eject

[Andreas Müller]

v1 -> v2:
follow busybox-1.19.3 -> busybox-1.19.4

Andreas Müller (1):
  busybox: enable eject

 meta/recipes-core/busybox/busybox-1.19.4/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.4.bb        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.4.4

[PATCH] busybox: enable eject

[Andreas Müller]

In xfce-environment ejecting USB-memory stick caused:
Error starting job: Failed to execute child process "eject" (No such file or directory)

run-tested with angstrom/meta-oe environment on overo
---
 meta/recipes-core/busybox/busybox-1.19.4/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.4.bb        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox-1.19.4/defconfig b/meta/recipes-core/busybox/busybox-1.19.4/defconfig
index 372d7b5..279933b 100644
--- a/meta/recipes-core/busybox/busybox-1.19.4/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.4/defconfig
@@ -669,7 +669,7 @@ CONFIG_DC=y
 # CONFIG_DEVFSD_VERBOSE is not set
 # CONFIG_FEATURE_DEVFS is not set
 # CONFIG_DEVMEM is not set
-# CONFIG_EJECT is not set
+CONFIG_EJECT=y
 # CONFIG_FEATURE_EJECT_SCSI is not set
 # CONFIG_FBSPLASH is not set
 # CONFIG_FLASHCP is not set
diff --git a/meta/recipes-core/busybox/busybox_1.19.4.bb b/meta/recipes-core/busybox/busybox_1.19.4.bb
index dff616d..01dd9be 100644
--- a/meta/recipes-core/busybox/busybox_1.19.4.bb
+++ b/meta/recipes-core/busybox/busybox_1.19.4.bb
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
-- 
1.7.4.4

Re: [PATCH] busybox: enable eject

[Paul Eggleton]

On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
> In xfce-environment ejecting USB-memory stick caused:
> Error starting job: Failed to execute child process "eject" (No such file or
> directory)

Not to say we shouldn't merge this, but I'm concerned if this continues we 
could end up with busybox in the default configuration creeping up in size as 
more and more features get enabled.

Where do we draw the line?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] busybox: enable eject

[McClintock Matthew-B29882]

On Thu, Mar 22, 2012 at 9:41 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
>> In xfce-environment ejecting USB-memory stick caused:
>> Error starting job: Failed to execute child process "eject" (No such file or
>> directory)
>
> Not to say we shouldn't merge this, but I'm concerned if this continues we
> could end up with busybox in the default configuration creeping up in size as
> more and more features get enabled.
>
> Where do we draw the line?

Perhaps it should be the default settings? We always have 'bitbake -c
menuconfig busybox' for the "small" cases?

-M

Re: [PATCH] busybox: enable eject

[Koen Kooi]

Op 22 mrt. 2012, om 15:41 heeft Paul Eggleton het volgende geschreven:

> On Thursday 22 March 2012 12:10:27 Andreas Müller wrote:
>> In xfce-environment ejecting USB-memory stick caused:
>> Error starting job: Failed to execute child process "eject" (No such file or
>> directory)
> 
> Not to say we shouldn't merge this, but I'm concerned if this continues we 
> could end up with busybox in the default configuration creeping up in size as 
> more and more features get enabled.
> 
> Where do we draw the line?

FWIW, the standalone 'eject' is in meta-oe, so xfce could RDEPEND on that. I don't have a strong opinion on the busybox patch. 

regards,

Koen