All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Cc: fenghua.yu@intel.com, bp@suse.de, gregkh@linuxfoundation.org,
	x86@kernel.org, linux-kernel@vger.kernel.org, rjw@sisk.pl,
	isimatu.yasuaki@jp.fujitsu.com, mingo@redhat.com,
	srivatsa.bhat@linux.vnet.ibm.com, tglx@linutronix.de,
	hpa@linux.intel.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()
Date: Mon, 19 Aug 2013 09:23:22 -0600	[thread overview]
Message-ID: <1376925802.10300.452.camel@misato.fc.hp.com> (raw)
In-Reply-To: <521237A9.8010109@linux.vnet.ibm.com>

On Mon, 2013-08-19 at 10:20 -0500, Nathan Fontenot wrote:
> On 08/17/2013 02:46 PM, Toshi Kani wrote:
> > cpu_hotplug_driver_lock() serializes CPU online/offline operations
> > when ARCH_CPU_PROBE_RELEASE is set.  This lock interface is no longer
> > necessary with the following reason:
> > 
> >  - lock_device_hotplug() now protects CPU online/offline operations,
> >    including the probe & release interfaces enabled by
> >    ARCH_CPU_PROBE_RELEASE.  The use of cpu_hotplug_driver_lock() is
> >    redundant.
> >  - cpu_hotplug_driver_lock() is only valid when ARCH_CPU_PROBE_RELEASE
> >    is defined, which is misleading and is only enabled on powerpc.
> > 
> > This patch removes the cpu_hotplug_driver_lock() interface.  As
> > a result, ARCH_CPU_PROBE_RELEASE only enables / disables the cpu
> > probe & release interface as intended.  There is no functional change
> > in this patch.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> 
> Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>

Thanks Nathan!
-Toshi

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Cc: mingo@redhat.com, hpa@linux.intel.com, tglx@linutronix.de,
	gregkh@linuxfoundation.org, benh@kernel.crashing.org,
	fenghua.yu@intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, rjw@sisk.pl,
	isimatu.yasuaki@jp.fujitsu.com, srivatsa.bhat@linux.vnet.ibm.com,
	bp@suse.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()
Date: Mon, 19 Aug 2013 09:23:22 -0600	[thread overview]
Message-ID: <1376925802.10300.452.camel@misato.fc.hp.com> (raw)
In-Reply-To: <521237A9.8010109@linux.vnet.ibm.com>

On Mon, 2013-08-19 at 10:20 -0500, Nathan Fontenot wrote:
> On 08/17/2013 02:46 PM, Toshi Kani wrote:
> > cpu_hotplug_driver_lock() serializes CPU online/offline operations
> > when ARCH_CPU_PROBE_RELEASE is set.  This lock interface is no longer
> > necessary with the following reason:
> > 
> >  - lock_device_hotplug() now protects CPU online/offline operations,
> >    including the probe & release interfaces enabled by
> >    ARCH_CPU_PROBE_RELEASE.  The use of cpu_hotplug_driver_lock() is
> >    redundant.
> >  - cpu_hotplug_driver_lock() is only valid when ARCH_CPU_PROBE_RELEASE
> >    is defined, which is misleading and is only enabled on powerpc.
> > 
> > This patch removes the cpu_hotplug_driver_lock() interface.  As
> > a result, ARCH_CPU_PROBE_RELEASE only enables / disables the cpu
> > probe & release interface as intended.  There is no functional change
> > in this patch.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> 
> Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>

Thanks Nathan!
-Toshi


  reply	other threads:[~2013-08-19 15:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 19:46 [PATCH 0/4] Unify CPU hotplug lock interface Toshi Kani
2013-08-17 19:46 ` Toshi Kani
2013-08-17 19:46 ` [PATCH 1/4] hotplug, x86: Fix online state in cpu0 debug interface Toshi Kani
2013-08-17 19:46   ` Toshi Kani
2013-08-18  0:59   ` Rafael J. Wysocki
2013-08-18  0:59     ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places Toshi Kani
2013-08-17 19:46   ` Toshi Kani
2013-08-17 23:15   ` Greg KH
2013-08-17 23:15     ` Greg KH
2013-08-19 14:53     ` Toshi Kani
2013-08-19 14:53       ` Toshi Kani
2013-08-18  0:59   ` Rafael J. Wysocki
2013-08-18  0:59     ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 3/4] hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86 Toshi Kani
2013-08-17 19:46   ` Toshi Kani
2013-08-18  1:00   ` Rafael J. Wysocki
2013-08-18  1:00     ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock() Toshi Kani
2013-08-17 19:46   ` Toshi Kani
2013-08-18  1:01   ` Rafael J. Wysocki
2013-08-18  1:01     ` Rafael J. Wysocki
2013-08-19 15:20   ` Nathan Fontenot
2013-08-19 15:20     ` Nathan Fontenot
2013-08-19 15:23     ` Toshi Kani [this message]
2013-08-19 15:23       ` Toshi Kani
2013-08-18  1:02 ` [PATCH 0/4] Unify CPU hotplug lock interface Rafael J. Wysocki
2013-08-18  1:02   ` Rafael J. Wysocki
2013-08-19 14:54   ` Toshi Kani
2013-08-19 14:54     ` Toshi Kani
2013-08-29 17:15   ` Toshi Kani
2013-08-29 17:15     ` Toshi Kani
2013-08-30  0:06     ` Rafael J. Wysocki
2013-08-30  0:06       ` Rafael J. Wysocki
2013-08-30  0:12       ` Toshi Kani
2013-08-30  0:12         ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376925802.10300.452.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=bp@suse.de \
    --cc=fenghua.yu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@linux.intel.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=rjw@sisk.pl \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.