[PATCH] SDK_NAME: Change to include image name and machine.

[PATCH] SDK_NAME: Change to include image name and machine.

[Elizabeth Flanagan]

[YOCTO #4618]

When building out multiple toolchains with the same target arch
you can end up having toolchains with the same name. Making
the naming a bit more granular by adding IMAGE_BASENAME and
MACHINE to SDK_NAME

Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
---
 meta-yocto/conf/distro/poky.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-yocto/conf/distro/poky.conf b/meta-yocto/conf/distro/poky.conf
index 7be7d92..f0da032 100644
--- a/meta-yocto/conf/distro/poky.conf
+++ b/meta-yocto/conf/distro/poky.conf
@@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
 PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
 
-SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
+SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
 SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
 
 EXTRAOPKGCONFIG = "poky-feed-config-opkg"
-- 
1.8.1.2

Re: [PATCH] SDK_NAME: Change to include image name and machine.

[Richard Purdie]

On Mon, 2013-08-19 at 14:45 -0700, Elizabeth Flanagan wrote:
> [YOCTO #4618]
> 
> When building out multiple toolchains with the same target arch
> you can end up having toolchains with the same name. Making
> the naming a bit more granular by adding IMAGE_BASENAME and
> MACHINE to SDK_NAME
> 
> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
> ---
>  meta-yocto/conf/distro/poky.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-yocto/conf/distro/poky.conf b/meta-yocto/conf/distro/poky.conf
> index 7be7d92..f0da032 100644
> --- a/meta-yocto/conf/distro/poky.conf
> +++ b/meta-yocto/conf/distro/poky.conf
> @@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
>  PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
>  PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
>  
> -SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
> +SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
>  SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
>  
>  EXTRAOPKGCONFIG = "poky-feed-config-opkg"

Are there differences in the SDK/ADT tarball between machines?

I appreciate its theoretically possible but in reality, they should be
the same and if they're not we have various problems.

Cheers,

Richard

Re: [PATCH] SDK_NAME: Change to include image name and machine.

[Flanagan, Elizabeth]

There apparently are differences caused by each machines tunings (for
example, meta-fsl-arm's imx53qsb is armv7a-vfp-neon, whereas qemuarm
is armv5te). With SDK_NAME as it is, you'd end up with two files that
have the exact same name and toolchains builds that are different.
Example. qemuarm's toolchain env setup should be named
'environment-setup-armv5te-poky-linux-gnueabi' but the toolchain I
just downloaded from the last master build is
'environment-setup-armv7a-vfp-neon-poky-linux-gnueabi' because it's
the toolchain from the meta-fsl-arm build. I'm not sure how deep the
issues go outside of these relatively small naming issues. ccing: Yi
Zhao as I'm sure he can tell us more.

I agree that TUNE_PKGARCH is probably a better solution than
TARGET_ARCH but with how I'm generating toolchains now (bitbake
core-image-sato  -c populate_sdk) I can see a day when having the
IMAGE_BASENAME included would be a very useful thing.

So, would anyone be opposed to:

SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${TUNE_PKGARCH}"

-b

On Mon, Aug 19, 2013 at 2:58 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Mon, 2013-08-19 at 14:45 -0700, Elizabeth Flanagan wrote:
>> [YOCTO #4618]
>>
>> When building out multiple toolchains with the same target arch
>> you can end up having toolchains with the same name. Making
>> the naming a bit more granular by adding IMAGE_BASENAME and
>> MACHINE to SDK_NAME
>>
>> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
>> ---
>>  meta-yocto/conf/distro/poky.conf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-yocto/conf/distro/poky.conf b/meta-yocto/conf/distro/poky.conf
>> index 7be7d92..f0da032 100644
>> --- a/meta-yocto/conf/distro/poky.conf
>> +++ b/meta-yocto/conf/distro/poky.conf
>> @@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
>>  PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
>>  PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
>>
>> -SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
>> +SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
>>  SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
>>
>>  EXTRAOPKGCONFIG = "poky-feed-config-opkg"
>
> Are there differences in the SDK/ADT tarball between machines?
>
> I appreciate its theoretically possible but in reality, they should be
> the same and if they're not we have various problems.
>
> Cheers,
>
> Richard
>



-- 
Elizabeth Flanagan
Yocto Project
Build and Release

Re: [PATCH] SDK_NAME: Change to include image name and machine.

[Richard Purdie]

On Mon, 2013-08-19 at 16:10 -0700, Flanagan, Elizabeth wrote:
> There apparently are differences caused by each machines tunings (for
> example, meta-fsl-arm's imx53qsb is armv7a-vfp-neon, whereas qemuarm
> is armv5te). With SDK_NAME as it is, you'd end up with two files that
> have the exact same name and toolchains builds that are different.
> Example. qemuarm's toolchain env setup should be named
> 'environment-setup-armv5te-poky-linux-gnueabi' but the toolchain I
> just downloaded from the last master build is
> 'environment-setup-armv7a-vfp-neon-poky-linux-gnueabi' because it's
> the toolchain from the meta-fsl-arm build. I'm not sure how deep the
> issues go outside of these relatively small naming issues. ccing: Yi
> Zhao as I'm sure he can tell us more.
> 
> I agree that TUNE_PKGARCH is probably a better solution than
> TARGET_ARCH but with how I'm generating toolchains now (bitbake
> core-image-sato  -c populate_sdk) I can see a day when having the
> IMAGE_BASENAME included would be a very useful thing.
> 
> So, would anyone be opposed to:
> 
> SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${TUNE_PKGARCH}"

Looks good to me, it was ${MACHINE} which worried me, TUNE_PKGARCH is
the right thing.

We should also remove [nostamp] from any SDK/ADT bits where it remains.

Cheers,

Richard

Re: [PATCH] SDK_NAME: Change to include image name and machine.

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

On Mon, Aug 19, 2013 at 02:45:17PM -0700, Elizabeth Flanagan wrote:
> [YOCTO #4618]
> 
> When building out multiple toolchains with the same target arch
> you can end up having toolchains with the same name. Making
> the naming a bit more granular by adding IMAGE_BASENAME and
> MACHINE to SDK_NAME

What about using TUNE_PKGARCH as oe-core does since
5a1f172d35be610688842a8a9a84f24edb9aeb51 ?

> 
> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
> ---
>  meta-yocto/conf/distro/poky.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-yocto/conf/distro/poky.conf b/meta-yocto/conf/distro/poky.conf
> index 7be7d92..f0da032 100644
> --- a/meta-yocto/conf/distro/poky.conf
> +++ b/meta-yocto/conf/distro/poky.conf
> @@ -22,7 +22,7 @@ PREFERRED_VERSION_linux-yocto_qemumips ?= "3.8%"
>  PREFERRED_VERSION_linux-yocto_qemumips64 ?= "3.8%"
>  PREFERRED_VERSION_linux-yocto_qemuppc ?= "3.8%"
>  
> -SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
> +SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${IMAGE_BASENAME}-${MACHINE}-${TARGET_ARCH}"
>  SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
>  
>  EXTRAOPKGCONFIG = "poky-feed-config-opkg"
> -- 
> 1.8.1.2
> 
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]